Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b215a2fa
Commit
b215a2fa
authored
Jan 11, 2021
by
Alper Akgun
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove email confirmation in onboarding
In group creation
parent
851161ad
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
29 additions
and
0 deletions
+29
-0
ee/app/controllers/registrations/groups_controller.rb
ee/app/controllers/registrations/groups_controller.rb
+6
-0
ee/spec/controllers/registrations/groups_controller_spec.rb
ee/spec/controllers/registrations/groups_controller_spec.rb
+23
-0
No files found.
ee/app/controllers/registrations/groups_controller.rb
View file @
b215a2fa
...
...
@@ -45,6 +45,12 @@ module Registrations
redirect_to
new_users_sign_up_project_path
(
url_params
)
end
protected
def
show_confirm_warning?
false
end
private
def
authorize_create_group!
...
...
ee/spec/controllers/registrations/groups_controller_spec.rb
View file @
b215a2fa
...
...
@@ -5,6 +5,26 @@ require 'spec_helper'
RSpec
.
describe
Registrations
::
GroupsController
do
let_it_be
(
:user
)
{
create
(
:user
)
}
shared_examples
'hides email confirmation warning'
do
RSpec
::
Matchers
.
define
:set_confirm_warning_for
do
|
email
|
match
do
|
response
|
expect
(
response
).
to
set_flash
.
now
[
:warning
].
to
include
(
"Please check your email (
#{
email
}
) to verify that you own this address and unlock the power of CI/CD."
)
end
end
context
'with an unconfirmed email address present'
do
let
(
:user
)
{
create
(
:user
,
confirmed_at:
nil
,
unconfirmed_email:
'unconfirmed@gitlab.com'
)
}
it
{
is_expected
.
not_to
set_confirm_warning_for
(
user
.
unconfirmed_email
)
}
end
context
'without an unconfirmed email address present'
do
let
(
:user
)
{
create
(
:user
,
confirmed_at:
nil
)
}
it
{
is_expected
.
not_to
set_confirm_warning_for
(
user
.
email
)
}
end
end
describe
'GET #new'
do
subject
{
get
:new
}
...
...
@@ -48,6 +68,8 @@ RSpec.describe Registrations::GroupsController do
it
{
is_expected
.
to
have_gitlab_http_status
(
:not_found
)
}
end
it_behaves_like
'hides email confirmation warning'
end
end
...
...
@@ -172,6 +194,7 @@ RSpec.describe Registrations::GroupsController do
end
end
it_behaves_like
'hides email confirmation warning'
it_behaves_like
GroupInviteMembers
context
'when the trial onboarding is active'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment