Merge branch 'fixup-deployment-model' into 'master'

Make ref_path Private in Deployment

See merge request gitlab-org/gitlab!26310

app/models/deployment.rb

@@ -280,12 +280,12 @@ class Deployment < ApplicationRecord
     errors.add(:ref, _('The branch or tag does not exist'))
   end
 
+  private
+
   def ref_path
     File.join(environment.ref_path, 'deployments', iid.to_s)
   end
 
-  private
-
   def legacy_finished_at
     self.created_at if success? && !read_attribute(:finished_at)
   end

spec/services/deployments/after_create_service_spec.rb

@@ -49,7 +49,7 @@ describe Deployments::AfterCreateService do
     it 'creates ref' do
       expect_any_instance_of(Repository)
         .to receive(:create_ref)
-        .with(deployment.sha, deployment.send(:ref_path))
+        .with(deployment.sha, "refs/environments/production/deployments/#{deployment.iid}")
 
       service.execute
     end