Add full request test for new graphql endpoint

Final clean up of the code, adding a full stack test
For the new endpoint
Co-authored-by: Tetiana Chupryna <tchupryna@gitlab.com>
Co-authored-by: David Fernandez <dfernandez@gitlab.com>
Co-authored-by: Nick Kipling <nkipling@gitlab.com>
Co-authored-by: Steve Abrams <sabrams@gitlab.com>

doc/api/graphql/reference/gitlab_schema.graphql

@@ -6640,6 +6640,76 @@ interface Noteable {
   ): NoteConnection!
 }
 
+"""
+Represents a package
+"""
+type Package {
+  """
+  The created date
+  """
+  createdAt: Time!
+
+  """
+  The ID of the package
+  """
+  id: ID!
+
+  """
+  The name of the package
+  """
+  name: String!
+
+  """
+  The type of the package
+  """
+  packageType: PackageTypeEnum!
+
+  """
+  The update date
+  """
+  updatedAt: Time!
+
+  """
+  The version of the package
+  """
+  version: String
+}
+
+"""
+The connection type for Package.
+"""
+type PackageConnection {
+  """
+  A list of edges.
+  """
+  edges: [PackageEdge]
+
+  """
+  A list of nodes.
+  """
+  nodes: [Package]
+
+  """
+  Information to aid in pagination.
+  """
+  pageInfo: PageInfo!
+}
+
+"""
+An edge in a connection.
+"""
+type PackageEdge {
+  """
+  A cursor for use in pagination.
+  """
+  cursor: String!
+
+  """
+  The item at the end of the edge.
+  """
+  node: Package
+}
+
 """
 Represents the sync and verification state of a package file
 """
@@ -6720,6 +6790,38 @@ type PackageFileRegistryEdge {
   node: PackageFileRegistry
 }
 
+enum PackageTypeEnum {
+  """
+  Packages from the composer package manager
+  """
+  COMPOSER
+
+  """
+  Packages from the conan package manager
+  """
+  CONAN
+
+  """
+  Packages from the maven package manager
+  """
+  MAVEN
+
+  """
+  Packages from the npm package manager
+  """
+  NPM
+
+  """
+  Packages from the nuget package manager
+  """
+  NUGET
+
+  """
+  Packages from the pypi package manager
+  """
+  PYPI
+}
+
 """
 Information about pagination in a connection.
 """
@@ -7417,6 +7519,31 @@ type Project {
   """
   openIssuesCount: Int
 
+  """
+  Packages of the project
+  """
+  packages(
+    """
+    Returns the elements in the list that come after the specified cursor.
+    """
+    after: String
+
+    """
+    Returns the elements in the list that come before the specified cursor.
+    """
+    before: String
+
+    """
+    Returns the first _n_ elements from the list.
+    """
+    first: Int
+
+    """
+    Returns the last _n_ elements from the list.
+    """
+    last: Int
+  ): PackageConnection
+
   """
   Path of the project
   """

doc/api/graphql/reference/gitlab_schema.json

@@ -19790,6 +19790,235 @@
             }
           ]
         },
+        {
+          "kind": "OBJECT",
+          "name": "Package",
+          "description": "Represents a package",
+          "fields": [
+            {
+              "name": "createdAt",
+              "description": "The created date",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "NON_NULL",
+                "name": null,
+                "ofType": {
+                  "kind": "SCALAR",
+                  "name": "Time",
+                  "ofType": null
+                }
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "id",
+              "description": "The ID of the package",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "NON_NULL",
+                "name": null,
+                "ofType": {
+                  "kind": "SCALAR",
+                  "name": "ID",
+                  "ofType": null
+                }
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "name",
+              "description": "The name of the package",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "NON_NULL",
+                "name": null,
+                "ofType": {
+                  "kind": "SCALAR",
+                  "name": "String",
+                  "ofType": null
+                }
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "packageType",
+              "description": "The type of the package",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "NON_NULL",
+                "name": null,
+                "ofType": {
+                  "kind": "ENUM",
+                  "name": "PackageTypeEnum",
+                  "ofType": null
+                }
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "updatedAt",
+              "description": "The update date",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "NON_NULL",
+                "name": null,
+                "ofType": {
+                  "kind": "SCALAR",
+                  "name": "Time",
+                  "ofType": null
+                }
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "version",
+              "description": "The version of the package",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "SCALAR",
+                "name": "String",
+                "ofType": null
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            }
+          ],
+          "inputFields": null,
+          "interfaces": [
+
+          ],
+          "enumValues": null,
+          "possibleTypes": null
+        },
+        {
+          "kind": "OBJECT",
+          "name": "PackageConnection",
+          "description": "The connection type for Package.",
+          "fields": [
+            {
+              "name": "edges",
+              "description": "A list of edges.",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "LIST",
+                "name": null,
+                "ofType": {
+                  "kind": "OBJECT",
+                  "name": "PackageEdge",
+                  "ofType": null
+                }
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "nodes",
+              "description": "A list of nodes.",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "LIST",
+                "name": null,
+                "ofType": {
+                  "kind": "OBJECT",
+                  "name": "Package",
+                  "ofType": null
+                }
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "pageInfo",
+              "description": "Information to aid in pagination.",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "NON_NULL",
+                "name": null,
+                "ofType": {
+                  "kind": "OBJECT",
+                  "name": "PageInfo",
+                  "ofType": null
+                }
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            }
+          ],
+          "inputFields": null,
+          "interfaces": [
+
+          ],
+          "enumValues": null,
+          "possibleTypes": null
+        },
+        {
+          "kind": "OBJECT",
+          "name": "PackageEdge",
+          "description": "An edge in a connection.",
+          "fields": [
+            {
+              "name": "cursor",
+              "description": "A cursor for use in pagination.",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "NON_NULL",
+                "name": null,
+                "ofType": {
+                  "kind": "SCALAR",
+                  "name": "String",
+                  "ofType": null
+                }
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "node",
+              "description": "The item at the end of the edge.",
+              "args": [
+
+              ],
+              "type": {
+                "kind": "OBJECT",
+                "name": "Package",
+                "ofType": null
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            }
+          ],
+          "inputFields": null,
+          "interfaces": [
+
+          ],
+          "enumValues": null,
+          "possibleTypes": null
+        },
         {
           "kind": "OBJECT",
           "name": "PackageFileRegistry",
@@ -20035,6 +20264,53 @@
           "enumValues": null,
           "possibleTypes": null
         },
+        {
+          "kind": "ENUM",
+          "name": "PackageTypeEnum",
+          "description": null,
+          "fields": null,
+          "inputFields": null,
+          "interfaces": null,
+          "enumValues": [
+            {
+              "name": "MAVEN",
+              "description": "Packages from the maven package manager",
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "NPM",
+              "description": "Packages from the npm package manager",
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "CONAN",
+              "description": "Packages from the conan package manager",
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "NUGET",
+              "description": "Packages from the nuget package manager",
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "PYPI",
+              "description": "Packages from the pypi package manager",
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
+            {
+              "name": "COMPOSER",
+              "description": "Packages from the composer package manager",
+              "isDeprecated": false,
+              "deprecationReason": null
+            }
+          ],
+          "possibleTypes": null
+        },
         {
           "kind": "OBJECT",
           "name": "PageInfo",
@@ -21904,6 +22180,59 @@
               "isDeprecated": false,
               "deprecationReason": null
             },
+            {
+              "name": "packages",
+              "description": "Packages of the project",
+              "args": [
+                {
+                  "name": "after",
+                  "description": "Returns the elements in the list that come after the specified cursor.",
+                  "type": {
+                    "kind": "SCALAR",
+                    "name": "String",
+                    "ofType": null
+                  },
+                  "defaultValue": null
+                },
+                {
+                  "name": "before",
+                  "description": "Returns the elements in the list that come before the specified cursor.",
+                  "type": {
+                    "kind": "SCALAR",
+                    "name": "String",
+                    "ofType": null
+                  },
+                  "defaultValue": null
+                },
+                {
+                  "name": "first",
+                  "description": "Returns the first _n_ elements from the list.",
+                  "type": {
+                    "kind": "SCALAR",
+                    "name": "Int",
+                    "ofType": null
+                  },
+                  "defaultValue": null
+                },
+                {
+                  "name": "last",
+                  "description": "Returns the last _n_ elements from the list.",
+                  "type": {
+                    "kind": "SCALAR",
+                    "name": "Int",
+                    "ofType": null
+                  },
+                  "defaultValue": null
+                }
+              ],
+              "type": {
+                "kind": "OBJECT",
+                "name": "PackageConnection",
+                "ofType": null
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
+            },
             {
               "name": "path",
               "description": "Path of the project",

doc/api/graphql/reference/index.md

@@ -984,6 +984,19 @@ Represents a milestone.
 | `readNote` | Boolean! | Indicates the user can perform `read_note` on this resource |
 | `resolveNote` | Boolean! | Indicates the user can perform `resolve_note` on this resource |
 
+## Package
+
+Represents a package
+
+| Name  | Type  | Description |
+| ---   |  ---- | ----------  |
+| `createdAt` | Time! | The created date |
+| `id` | ID! | The ID of the package |
+| `name` | String! | The name of the package |
+| `packageType` | PackageTypeEnum! | The type of the package |
+| `updatedAt` | Time! | The update date |
+| `version` | String | The version of the package |
+
 ## PackageFileRegistry
 
 Represents the sync and verification state of a package file

ee/app/graphql/resolvers/packages_resolver.rb

@@ -6,6 +6,7 @@ module Resolvers
 
     def resolve(**args)
       return unless packages_available?(object, current_user)
+
       ::Packages::PackagesFinder.new(object).execute
     end
 
@@ -16,4 +17,3 @@ module Resolvers
     end
   end
 end
-  
\ No newline at end of file

ee/app/graphql/types/package_type_enum.rb

@@ -3,8 +3,7 @@
 module Types
   class PackageTypeEnum < BaseEnum
     ::Packages::Package.package_types.keys.each do |package_type|
-        value package_type.to_s.upcase, value: package_type.to_s
+      value package_type.to_s.upcase, "Packages from the #{package_type} package manager", value: package_type.to_s
     end
   end
 end
-  
\ No newline at end of file

ee/changelogs/unreleased/216794-add-a-graphql-endpoint-for-package-registry.yml

+---
+title: Add graphql endpoint for project packages list
+merge_request: 31344
+author:
+type: added

ee/spec/graphql/resolvers/packages_resolver_spec.rb

@@ -9,7 +9,6 @@ describe Resolvers::PackagesResolver do
   let_it_be(:project) { create(:project) }
   let_it_be(:package) { create(:package, project: project) }
 
- 
   describe '#resolve' do
     subject(:packages) { resolve(described_class, ctx: { current_user: user }, obj: project) }
 
@@ -46,8 +45,11 @@ describe Resolvers::PackagesResolver do
     end
 
     context 'when the package feature is not enabled' do
+      before do
+        stub_licensed_features(packages: false)
+      end
+
       it { is_expected.to be_nil }
     end
   end
-
 end

ee/spec/requests/api/graphql/project/packages_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'getting a package list for a project' do
+  include GraphqlHelpers
+
+  let_it_be(:project) { create(:project) }
+  let_it_be(:current_user) { create(:user) }
+  let_it_be(:package) { create(:package, project: project) }
+  let(:packages_data) { graphql_data['project']['packages']['edges'] }
+
+  let(:fields) do
+    <<~QUERY
+    edges {
+      node {
+        #{all_graphql_fields_for('packages'.classify)}
+      }
+    }
+    QUERY
+  end
+
+  let(:query) do
+    graphql_query_for(
+      'project',
+      { 'fullPath' => project.full_path },
+      query_graphql_field('packages', {}, fields)
+    )
+  end
+
+  context 'when package feature is available' do
+    before do
+      stub_licensed_features(packages: true)
+    end
+
+    context 'when user has access to the project' do
+      before do
+        project.add_reporter(current_user)
+      end
+
+      it_behaves_like 'a working graphql query' do
+        before do
+          post_graphql(query, current_user: current_user)
+        end
+      end
+
+      it 'returns packages successfully' do
+        post_graphql(query, current_user: current_user)
+
+        expect(graphql_errors).to be_nil
+        expect(packages_data[0]['node']['name']).to eq package.name
+      end
+    end
+
+    context 'when the user does not have access to the packages' do
+      it 'returns nil' do
+        post_graphql(query)
+
+        expect(graphql_data['project']).to be_nil
+      end
+    end
+  end
+
+  context 'when package feature is not available' do
+    before do
+      stub_licensed_features(packages: false)
+      project.add_reporter(current_user)
+    end
+
+    it 'returns nil' do
+      post_graphql(query)
+
+      expect(graphql_data['project']).to be_nil
+    end
+  end
+end