Merge branch 'ml-update-login-process-no-tabs' into 'master'

[QA] Fix login test

Closes #35875

See merge request gitlab-org/gitlab!20683

qa/qa/page/main/login.rb

@@ -42,6 +42,10 @@ module QA
           element :login_page, required: true
         end
 
+        def can_sign_in?
+          has_element?(:sign_in_button)
+        end
+
         def sign_in_using_credentials(user: nil, skip_page_validation: false)
           # Don't try to log-in if we're already logged-in
           return if Page::Main::Menu.perform(&:signed_in?)

qa/qa/specs/features/browser_ui/1_manage/login/log_in_spec.rb

@@ -14,11 +14,11 @@ module QA
         Support::Retrier.retry_until(sleep_interval: 0.5) do
           Page::Main::Menu.perform(&:sign_out)
 
-          Page::Main::Login.perform(&:has_sign_in_tab?)
+          Page::Main::Login.perform(&:can_sign_in?)
         end
 
         Page::Main::Login.perform do |form|
-          expect(form.sign_in_tab?).to be(true)
+          expect(form.can_sign_in?).to be(true)
         end
       end
     end