Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b493ec7b
Commit
b493ec7b
authored
Aug 09, 2021
by
Angelo Gulina
Committed by
Vitaly Slobodin
Aug 09, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Display subtotal and tax line in Subscription Purchase
parent
521671b1
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
97 additions
and
43 deletions
+97
-43
ee/app/assets/javascripts/subscriptions/new/components/order_summary/summary_details.vue
...riptions/new/components/order_summary/summary_details.vue
+34
-10
ee/spec/frontend/subscriptions/new/components/checkout/order_summary_spec.js
...bscriptions/new/components/checkout/order_summary_spec.js
+60
-33
locale/gitlab.pot
locale/gitlab.pot
+3
-0
No files found.
ee/app/assets/javascripts/subscriptions/new/components/order_summary/summary_details.vue
View file @
b493ec7b
<
script
>
import
{
GlLink
,
GlSprintf
}
from
'
@gitlab/ui
'
;
import
{
mapState
,
mapGetters
}
from
'
vuex
'
;
import
{
s__
}
from
'
~/locale
'
;
import
formattingMixins
from
'
../../formatting_mixins
'
;
export
default
{
components
:
{
GlLink
,
GlSprintf
,
},
mixins
:
[
formattingMixins
],
computed
:
{
...
mapState
([
'
startDate
'
,
'
taxRate
'
,
'
numberOfUsers
'
]),
...
...
@@ -16,6 +21,12 @@ export default {
'
totalAmount
'
,
'
usersPresent
'
,
]),
taxAmount
()
{
return
this
.
taxRate
?
this
.
formatAmount
(
this
.
vat
,
this
.
usersPresent
)
:
'
–
'
;
},
taxLine
()
{
return
`
${
this
.
$options
.
i18n
.
tax
}
${
this
.
$options
.
i18n
.
taxNote
}
`
;
},
},
i18n
:
{
selectedPlanText
:
s__
(
'
Checkout|%{selectedPlanText} plan
'
),
...
...
@@ -24,13 +35,14 @@ export default {
dates
:
s__
(
'
Checkout|%{startDate} - %{endDate}
'
),
subtotal
:
s__
(
'
Checkout|Subtotal
'
),
tax
:
s__
(
'
Checkout|Tax
'
),
taxNote
:
s__
(
'
Checkout|(may be %{linkStart}charged upon purchase%{linkEnd})
'
),
total
:
s__
(
'
Checkout|Total
'
),
},
};
</
script
>
<
template
>
<div>
<div
class=
"
d-flex justify-content-between bold gl-mt-3 gl-mb
-3"
>
<div
class=
"
gl-display-flex gl-justify-content-space-between gl-font-weight-bold gl-my
-3"
>
<div
class=
"js-selected-plan"
>
{{
sprintf
(
$options
.
i18n
.
selectedPlanText
,
{
selectedPlanText
}
)
}}
<
span
v
-
if
=
"
usersPresent
"
class
=
"
js-number-of-users
"
>
{{
...
...
@@ -39,14 +51,14 @@ export default {
<
/div
>
<
div
class
=
"
js-amount
"
>
{{
formatAmount
(
totalExVat
,
usersPresent
)
}}
<
/div
>
<
/div
>
<
div
class
=
"
text-secondary
js-per-user
"
>
<
div
class
=
"
gl-text-gray-500
js-per-user
"
>
{{
sprintf
(
$options
.
i18n
.
pricePerUserPerYear
,
{
selectedPlanPrice
:
selectedPlanPrice
.
toLocaleString
(),
}
)
}}
<
/div
>
<
div
class
=
"
text-secondary
js-dates
"
>
<
div
class
=
"
gl-text-gray-500
js-dates
"
>
{{
sprintf
(
$options
.
i18n
.
dates
,
{
startDate
:
formatDate
(
startDate
),
...
...
@@ -54,19 +66,31 @@ export default {
}
)
}}
<
/div
>
<
div
v
-
if
=
"
taxRate
"
>
<
div
>
<
div
class
=
"
border-bottom gl-mt-3 gl-mb-3
"
><
/div
>
<
div
class
=
"
d-flex justify-content-between text-secondary
"
>
<
div
class
=
"
gl-display-flex gl-justify-content-space-between gl-text-gray-500
"
>
<
div
>
{{
$options
.
i18n
.
subtotal
}}
<
/div
>
<
div
class
=
"
js-total-ex-vat
"
>
{{
formatAmount
(
totalExVat
,
usersPresent
)
}}
<
/div
>
<
/div
>
<
div
class
=
"
d-flex justify-content-between text-secondary
"
>
<
div
>
{{
$options
.
i18n
.
tax
}}
<
/div
>
<
div
class
=
"
js-vat
"
>
{{
formatAmount
(
vat
,
usersPresent
)
}}
<
/div
>
<
div
class
=
"
gl-display-flex gl-justify-content-space-between gl-text-gray-500
"
>
<
div
data
-
testid
=
"
tax-info-line
"
>
<
gl
-
sprintf
:
message
=
"
taxLine
"
>
<
template
#
link
=
"
{ content
}
"
>
<
gl
-
link
class
=
"
gl-text-decoration-underline gl-text-gray-500
"
href
=
"
https://about.gitlab.com/handbook/tax/#indirect-taxes-management
"
target
=
"
_blank
"
data
-
testid
=
"
tax-help-link
"
>
{{
content
}}
<
/gl-lin
k
>
<
/template
>
<
/gl-sprintf
>
<
/div
>
<
div
class
=
"
js-vat
"
>
{{
taxAmount
}}
<
/div
>
<
/div
>
<
div
class
=
"
border-bottom gl-mt-3 gl-mb-3
"
><
/div
>
<
div
class
=
"
d-flex justify-content-between bold gl-font-lg
"
>
<
/div
>
<
div
class
=
"
gl-border-b-1 gl-border-b-gray-100 gl-border-b-solid gl-mt-3 gl-mb-3
"
><
/div
>
<
div
class
=
"
gl-display-flex gl-justify-content-space-between gl-font-lg gl-font-weight-bold
"
>
<
div
>
{{
$options
.
i18n
.
total
}}
<
/div
>
<
div
class
=
"
js-total-amount
"
>
{{
formatAmount
(
totalAmount
,
usersPresent
)
}}
<
/div
>
<
/div
>
...
...
ee/spec/frontend/subscriptions/new/components/checkout/order_summary_spec.js
View file @
b493ec7b
import
{
mount
,
createLocalVue
}
from
'
@vue/test-utils
'
;
import
{
createLocalVue
}
from
'
@vue/test-utils
'
;
import
Vuex
from
'
vuex
'
;
import
Component
from
'
ee/subscriptions/new/components/order_summary.vue
'
;
import
createStore
from
'
ee/subscriptions/new/store
'
;
import
*
as
types
from
'
ee/subscriptions/new/store/mutation_types
'
;
import
{
mountExtended
}
from
'
helpers/vue_test_utils_helper
'
;
describe
(
'
Order Summary
'
,
()
=>
{
const
localVue
=
createLocalVue
();
...
...
@@ -23,10 +24,12 @@ describe('Order Summary', () => {
fullName
:
'
Full Name
'
,
};
const
store
=
createStore
(
initialData
);
const
findTaxInfoLine
=
()
=>
wrapper
.
findByTestId
(
'
tax-info-line
'
);
const
findTaxHelpLink
=
()
=>
wrapper
.
findByTestId
(
'
tax-help-link
'
);
const
store
=
createStore
(
initialData
);
const
createComponent
=
(
opts
=
{})
=>
{
wrapper
=
mount
(
Component
,
{
wrapper
=
mount
Extended
(
Component
,
{
localVue
,
store
,
...
opts
,
...
...
@@ -47,7 +50,7 @@ describe('Order Summary', () => {
store
.
commit
(
types
.
UPDATE_IS_SETUP_FOR_COMPANY
,
false
);
});
it
(
'
should display
the title with the passed name
'
,
()
=>
{
it
(
'
displays
the title with the passed name
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
h4
'
).
text
()).
toContain
(
"
Full Name's GitLab subscription
"
);
});
});
...
...
@@ -58,7 +61,7 @@ describe('Order Summary', () => {
});
describe
(
'
Without a group name provided
'
,
()
=>
{
it
(
'
should display
the title with the default name
'
,
()
=>
{
it
(
'
displays
the title with the default name
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
h4
'
).
text
()).
toContain
(
"
Your organization's GitLab subscription
"
);
});
});
...
...
@@ -68,7 +71,7 @@ describe('Order Summary', () => {
store
.
commit
(
types
.
UPDATE_ORGANIZATION_NAME
,
'
My group
'
);
});
it
(
'
when given a group name, it should display
the title with the group name
'
,
()
=>
{
it
(
'
displays
the title with the group name
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
h4
'
).
text
()).
toContain
(
"
My group's GitLab subscription
"
);
});
});
...
...
@@ -77,30 +80,30 @@ describe('Order Summary', () => {
describe
(
'
Changing the plan
'
,
()
=>
{
describe
(
'
the selected plan
'
,
()
=>
{
it
(
'
should display
the chosen plan
'
,
()
=>
{
it
(
'
displays
the chosen plan
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-selected-plan
'
).
text
()).
toContain
(
'
Gold plan
'
);
});
it
(
'
should display
the correct formatted amount price per user
'
,
()
=>
{
it
(
'
displays
the correct formatted amount price per user
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-per-user
'
).
text
()).
toContain
(
'
$1,188 per user per year
'
);
});
});
describe
(
'
the default plan
'
,
()
=>
{
describe
(
'
with
the default plan
'
,
()
=>
{
beforeEach
(()
=>
{
store
.
commit
(
types
.
UPDATE_SELECTED_PLAN
,
'
firstPlanId
'
);
store
.
commit
(
types
.
UPDATE_NUMBER_OF_USERS
,
1
);
});
it
(
'
should display
the chosen plan
'
,
()
=>
{
it
(
'
displays
the chosen plan
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-selected-plan
'
).
text
()).
toContain
(
'
Bronze plan
'
);
});
it
(
'
should display
the correct formatted amount price per user
'
,
()
=>
{
it
(
'
displays
the correct formatted amount price per user
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-per-user
'
).
text
()).
toContain
(
'
$48 per user per year
'
);
});
it
(
'
should display
the correct formatted total amount
'
,
()
=>
{
it
(
'
displays
the correct formatted total amount
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-total-amount
'
).
text
()).
toContain
(
'
$48
'
);
});
});
...
...
@@ -112,48 +115,48 @@ describe('Order Summary', () => {
store
.
commit
(
types
.
UPDATE_NUMBER_OF_USERS
,
1
);
});
describe
(
'
the default of 1 selected user
'
,
()
=>
{
it
(
'
should display
the correct number of users
'
,
()
=>
{
describe
(
'
with
the default of 1 selected user
'
,
()
=>
{
it
(
'
displays
the correct number of users
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-number-of-users
'
).
text
()).
toContain
(
'
(x1)
'
);
});
it
(
'
should display
the correct formatted amount price per user
'
,
()
=>
{
it
(
'
displays
the correct formatted amount price per user
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-per-user
'
).
text
()).
toContain
(
'
$1,188 per user per year
'
);
});
it
(
'
should display
the correct multiplied formatted amount of the chosen plan
'
,
()
=>
{
it
(
'
displays
the correct multiplied formatted amount of the chosen plan
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-amount
'
).
text
()).
toContain
(
'
$1,188
'
);
});
it
(
'
should display
the correct formatted total amount
'
,
()
=>
{
it
(
'
displays
the correct formatted total amount
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-total-amount
'
).
text
()).
toContain
(
'
$1,188
'
);
});
});
describe
(
'
3 selected users
'
,
()
=>
{
describe
(
'
with
3 selected users
'
,
()
=>
{
beforeEach
(()
=>
{
store
.
commit
(
types
.
UPDATE_SELECTED_PLAN
,
'
thirdPlanId
'
);
store
.
commit
(
types
.
UPDATE_NUMBER_OF_USERS
,
3
);
});
it
(
'
should display
the correct number of users
'
,
()
=>
{
it
(
'
displays
the correct number of users
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-number-of-users
'
).
text
()).
toContain
(
'
(x3)
'
);
});
it
(
'
should display
the correct formatted amount price per user
'
,
()
=>
{
it
(
'
displays
the correct formatted amount price per user
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-per-user
'
).
text
()).
toContain
(
'
$1,188 per user per year
'
);
});
it
(
'
should display
the correct multiplied formatted amount of the chosen plan
'
,
()
=>
{
it
(
'
displays
the correct multiplied formatted amount of the chosen plan
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-amount
'
).
text
()).
toContain
(
'
$3,564
'
);
});
it
(
'
should display
the correct formatted total amount
'
,
()
=>
{
it
(
'
displays
the correct formatted total amount
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-total-amount
'
).
text
()).
toContain
(
'
$3,564
'
);
});
});
describe
(
'
no selected users
'
,
()
=>
{
describe
(
'
with
no selected users
'
,
()
=>
{
beforeEach
(()
=>
{
store
.
commit
(
types
.
UPDATE_SELECTED_PLAN
,
'
thirdPlanId
'
);
store
.
commit
(
types
.
UPDATE_NUMBER_OF_USERS
,
0
);
...
...
@@ -163,7 +166,7 @@ describe('Order Summary', () => {
expect
(
wrapper
.
find
(
'
.js-number-of-users
'
).
exists
()).
toBe
(
false
);
});
it
(
'
should display
the correct formatted amount price per user
'
,
()
=>
{
it
(
'
displays
the correct formatted amount price per user
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-per-user
'
).
text
()).
toContain
(
'
$1,188 per user per year
'
);
});
...
...
@@ -171,7 +174,7 @@ describe('Order Summary', () => {
expect
(
wrapper
.
find
(
'
.js-amount
'
).
text
()).
toContain
(
'
-
'
);
});
it
(
'
should display
the correct formatted total amount
'
,
()
=>
{
it
(
'
displays
the correct formatted total amount
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-total-amount
'
).
text
()).
toContain
(
'
-
'
);
});
});
...
...
@@ -187,13 +190,25 @@ describe('Order Summary', () => {
});
describe
(
'
tax rate
'
,
()
=>
{
describe
(
'
a tax rate of 0
'
,
()
=>
{
it
(
'
should not display the total amount excluding vat
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-total-ex-vat
'
).
exists
()).
toBe
(
false
);
describe
(
'
with a tax rate of 0
'
,
()
=>
{
it
(
'
displays the total amount excluding vat
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-total-ex-vat
'
).
exists
()).
toBe
(
true
);
});
it
(
'
displays the vat amount with a stopgap
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-vat
'
).
text
()).
toBe
(
'
–
'
);
});
it
(
'
displays an info line
'
,
()
=>
{
expect
(
findTaxInfoLine
().
text
()).
toMatchInterpolatedText
(
'
Tax (may be charged upon purchase)
'
,
);
});
it
(
'
should not display the vat amount
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-vat
'
).
exists
()).
toBe
(
false
);
it
(
'
contains a help link
'
,
()
=>
{
expect
(
findTaxHelpLink
().
attributes
(
'
href
'
)).
toBe
(
'
https://about.gitlab.com/handbook/tax/#indirect-taxes-management
'
,
);
});
});
...
...
@@ -202,17 +217,29 @@ describe('Order Summary', () => {
store
.
state
.
taxRate
=
0.08
;
});
it
(
'
should display
the total amount excluding vat
'
,
()
=>
{
it
(
'
displays
the total amount excluding vat
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-total-ex-vat
'
).
text
()).
toContain
(
'
$1,188
'
);
});
it
(
'
should display
the vat amount
'
,
()
=>
{
it
(
'
displays
the vat amount
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-vat
'
).
text
()).
toContain
(
'
$95.04
'
);
});
it
(
'
should display
the total amount including the vat
'
,
()
=>
{
it
(
'
displays
the total amount including the vat
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-total-amount
'
).
text
()).
toContain
(
'
$1,283.04
'
);
});
it
(
'
displays an info line
'
,
()
=>
{
expect
(
findTaxInfoLine
().
text
()).
toMatchInterpolatedText
(
'
Tax (may be charged upon purchase)
'
,
);
});
it
(
'
contains a help link
'
,
()
=>
{
expect
(
findTaxHelpLink
().
attributes
(
'
href
'
)).
toBe
(
'
https://about.gitlab.com/handbook/tax/#indirect-taxes-management
'
,
);
});
});
});
});
...
...
locale/gitlab.pot
View file @
b493ec7b
...
...
@@ -6497,6 +6497,9 @@ msgstr ""
msgid "Checkout|%{totalCiMinutes} CI minutes"
msgstr ""
msgid "Checkout|(may be %{linkStart}charged upon purchase%{linkEnd})"
msgstr ""
msgid "Checkout|(x%{numberOfUsers})"
msgstr ""
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment