Commit b82ba9b5 authored by Miguel Rincon's avatar Miguel Rincon

Improve descriptions of router tests

parent 6f1dda13
...@@ -49,14 +49,14 @@ describe('Monitoring router', () => { ...@@ -49,14 +49,14 @@ describe('Monitoring router', () => {
window.location.hash = ''; window.location.hash = '';
}); });
describe('support legacy URL with full dashboard path to visit dashboard page', () => { describe('support legacy URLs with full dashboard path to visit dashboard page', () => {
it.each` it.each`
route | currentDashboard path | currentDashboard
${'/dashboard.yml'} | ${'dashboard.yml'} ${'/dashboard.yml'} | ${'dashboard.yml'}
${'/folder1/dashboard.yml'} | ${'folder1/dashboard.yml'} ${'/folder1/dashboard.yml'} | ${'folder1/dashboard.yml'}
${'/?dashboard=dashboard.yml'} | ${'dashboard.yml'} ${'/?dashboard=dashboard.yml'} | ${'dashboard.yml'}
`('sets component as $componentName for path "$route"', ({ route, currentDashboard }) => { `('"$path" renders page with dashboard "$currentDashboard"', ({ path, currentDashboard }) => {
const wrapper = createWrapper(LEGACY_BASE_PATH, route); const wrapper = createWrapper(LEGACY_BASE_PATH, path);
expect(store.dispatch).toHaveBeenCalledWith('monitoringDashboard/setCurrentDashboard', { expect(store.dispatch).toHaveBeenCalledWith('monitoringDashboard/setCurrentDashboard', {
currentDashboard, currentDashboard,
...@@ -72,9 +72,9 @@ describe('Monitoring router', () => { ...@@ -72,9 +72,9 @@ describe('Monitoring router', () => {
}); });
}); });
describe('supports URL to visit dashboard page', () => { describe('supports URLs to visit dashboard page', () => {
it.each` it.each`
route | currentDashboard path | currentDashboard
${'/'} | ${null} ${'/'} | ${null}
${'/dashboard.yml'} | ${'dashboard.yml'} ${'/dashboard.yml'} | ${'dashboard.yml'}
${'/folder1/dashboard.yml'} | ${'folder1/dashboard.yml'} ${'/folder1/dashboard.yml'} | ${'folder1/dashboard.yml'}
...@@ -83,8 +83,8 @@ describe('Monitoring router', () => { ...@@ -83,8 +83,8 @@ describe('Monitoring router', () => {
${'/config/prometheus/common_metrics.yml'} | ${'config/prometheus/common_metrics.yml'} ${'/config/prometheus/common_metrics.yml'} | ${'config/prometheus/common_metrics.yml'}
${'/config/prometheus/pod_metrics.yml'} | ${'config/prometheus/pod_metrics.yml'} ${'/config/prometheus/pod_metrics.yml'} | ${'config/prometheus/pod_metrics.yml'}
${'/config%2Fprometheus%2Fpod_metrics.yml'} | ${'config/prometheus/pod_metrics.yml'} ${'/config%2Fprometheus%2Fpod_metrics.yml'} | ${'config/prometheus/pod_metrics.yml'}
`('sets component as $componentName for path "$route"', ({ route, currentDashboard }) => { `('"$path" renders page with dashboard "$currentDashboard"', ({ path, currentDashboard }) => {
const wrapper = createWrapper(BASE_PATH, route); const wrapper = createWrapper(BASE_PATH, path);
expect(store.dispatch).toHaveBeenCalledWith('monitoringDashboard/setCurrentDashboard', { expect(store.dispatch).toHaveBeenCalledWith('monitoringDashboard/setCurrentDashboard', {
currentDashboard, currentDashboard,
...@@ -100,21 +100,18 @@ describe('Monitoring router', () => { ...@@ -100,21 +100,18 @@ describe('Monitoring router', () => {
}); });
}); });
describe('supports URL to visit new panel page', () => { describe('supports URLs to visit new panel page', () => {
it.each` it.each`
route | currentDashboard path | currentDashboard
${'/panel/new'} | ${undefined} ${'/panel/new'} | ${undefined}
${'/dashboard.yml/panel/new'} | ${'dashboard.yml'} ${'/dashboard.yml/panel/new'} | ${'dashboard.yml'}
${'/config/prometheus/common_metrics.yml/panel/new'} | ${'config/prometheus/common_metrics.yml'} ${'/config/prometheus/common_metrics.yml/panel/new'} | ${'config/prometheus/common_metrics.yml'}
${'/config%2Fprometheus%2Fcommon_metrics.yml/panel/new'} | ${'config/prometheus/common_metrics.yml'} ${'/config%2Fprometheus%2Fcommon_metrics.yml/panel/new'} | ${'config/prometheus/common_metrics.yml'}
`( `('"$path" renders page with dashboard "$currentDashboard"', ({ path, currentDashboard }) => {
'displays the new panel page for path "$route" with route param $currentDashboard', const wrapper = createWrapper(BASE_PATH, path);
({ route, currentDashboard }) => {
const wrapper = createWrapper(BASE_PATH, route);
expect(wrapper.vm.$route.params.dashboard).toBe(currentDashboard); expect(wrapper.vm.$route.params.dashboard).toBe(currentDashboard);
expect(wrapper.find(PanelNewPage).exists()).toBe(true); expect(wrapper.find(PanelNewPage).exists()).toBe(true);
}, });
);
}); });
}); });
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment