Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b943596e
Commit
b943596e
authored
May 18, 2017
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed assignees tooltip clipping in sidebar
Closes
https://gitlab.com/gitlab-org/gitlab-ce/issues/32512
parent
1552a182
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
0 deletions
+16
-0
app/assets/javascripts/sidebar/components/assignees/assignees.js
...ets/javascripts/sidebar/components/assignees/assignees.js
+1
-0
spec/javascripts/sidebar/assignees_spec.js
spec/javascripts/sidebar/assignees_spec.js
+15
-0
No files found.
app/assets/javascripts/sidebar/components/assignees/assignees.js
View file @
b943596e
...
@@ -187,6 +187,7 @@ export default {
...
@@ -187,6 +187,7 @@ export default {
>
>
<a
<a
class="user-link has-tooltip"
class="user-link has-tooltip"
data-container="body"
data-placement="bottom"
data-placement="bottom"
:href="assigneeUrl(user)"
:href="assigneeUrl(user)"
:data-title="user.name"
:data-title="user.name"
...
...
spec/javascripts/sidebar/assignees_spec.js
View file @
b943596e
...
@@ -187,6 +187,21 @@ describe('Assignee component', () => {
...
@@ -187,6 +187,21 @@ describe('Assignee component', () => {
expect
(
component
.
$el
.
querySelector
(
'
.user-list-more
'
)).
toBe
(
null
);
expect
(
component
.
$el
.
querySelector
(
'
.user-list-more
'
)).
toBe
(
null
);
});
});
it
(
'
sets tooltip container to body
'
,
()
=>
{
const
users
=
UsersMockHelper
.
createNumberRandomUsers
(
2
);
component
=
new
AssigneeComponent
({
propsData
:
{
rootPath
:
'
http://localhost:3000
'
,
users
,
editable
:
true
,
},
}).
$mount
();
expect
(
component
.
$el
.
querySelector
(
'
.user-link
'
).
getAttribute
(
'
data-container
'
),
).
toBe
(
'
body
'
);
});
it
(
'
Shows the "show-less" assignees label
'
,
(
done
)
=>
{
it
(
'
Shows the "show-less" assignees label
'
,
(
done
)
=>
{
const
users
=
UsersMockHelper
.
createNumberRandomUsers
(
6
);
const
users
=
UsersMockHelper
.
createNumberRandomUsers
(
6
);
component
=
new
AssigneeComponent
({
component
=
new
AssigneeComponent
({
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment