Merge branch 'no-default-export' into 'master'

Disable default export rules

See merge request gitlab-org/gitlab!37252

.eslintrc.yml

@@ -17,6 +17,7 @@ settings:
       config: './config/webpack.config.js'
 rules:
   import/no-commonjs: error
+  import/no-default-export: off
   no-underscore-dangle:
     - error
     - allow:

app/assets/javascripts/admin/statistics_panel/store/getters.js

@@ -3,7 +3,6 @@
  * and returns an array of the following form:
  * [{ key: "forks", label: "Forks", value: 50 }]
  */
-// eslint-disable-next-line import/prefer-default-export
 export const getStatistics = state => labels =>
   Object.keys(labels).map(key => {
     const result = {

app/assets/javascripts/batch_comments/index.js

@@ -3,7 +3,6 @@ import { mapActions } from 'vuex';
 import store from '~/mr_notes/stores';
 import ReviewBar from './components/review_bar.vue';
 
-// eslint-disable-next-line import/prefer-default-export
 export const initReviewBar = () => {
   const el = document.getElementById('js-review-bar');
 

app/assets/javascripts/ci_variable_list/constants.js

 import { __ } from '~/locale';
 
-// eslint-disable import/prefer-default-export
 export const ADD_CI_VARIABLE_MODAL_ID = 'add-ci-variable';
 
 export const displayText = {

app/assets/javascripts/ci_variable_list/store/getters.js

-/* eslint-disable import/prefer-default-export */
-// Disabling import/prefer-default-export can be
-// removed once a second getter is added to this file
 import { uniq } from 'lodash';
 
 export const joinedEnvironments = state => {

app/assets/javascripts/contributors/stores/actions.js

@@ -3,7 +3,6 @@ import { __ } from '~/locale';
 import service from '../services/contributors_service';
 import * as types from './mutation_types';
 
-// eslint-disable-next-line import/prefer-default-export
 export const fetchChartData = ({ commit }, endpoint) => {
   commit(types.SET_LOADING_STATE, true);
 

app/assets/javascripts/create_cluster/eks_cluster/constants.js

-// eslint-disable-next-line import/prefer-default-export
 export const KUBERNETES_VERSIONS = [{ name: '1.14', value: '1.14' }];

app/assets/javascripts/create_cluster/eks_cluster/store/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const subnetValid = ({ selectedSubnet }) =>
   Array.isArray(selectedSubnet) && selectedSubnet.length >= 2;

app/assets/javascripts/design_management/utils/tracking.js

@@ -5,7 +5,6 @@ const DESIGN_TRACKING_CONTEXT_SCHEMA = 'iglu:com.gitlab/design_management_contex
 const DESIGN_TRACKING_PAGE_NAME = 'projects:issues:design';
 const DESIGN_TRACKING_EVENT_NAME = 'view_design';
 
-// eslint-disable-next-line import/prefer-default-export
 export function trackDesignDetailView(
   referer = '',
   owner = '',

app/assets/javascripts/design_management_legacy/utils/tracking.js

@@ -5,7 +5,6 @@ const DESIGN_TRACKING_CONTEXT_SCHEMA = 'iglu:com.gitlab/design_management_contex
 const DESIGN_TRACKING_PAGE_NAME = 'projects:issues:design';
 const DESIGN_TRACKING_EVENT_NAME = 'view_design';
 
-// eslint-disable-next-line import/prefer-default-export
 export function trackDesignDetailView(
   referer = '',
   owner = '',

app/assets/javascripts/diffs/diff_file.js

@@ -18,7 +18,6 @@ function fileSymlinkInformation(file, fileList) {
   );
 }
 
-/* eslint-disable-next-line import/prefer-default-export */
 export function prepareRawDiffFile({ file, allFiles }) {
   Object.assign(file, {
     brokenSymlink: fileSymlinkInformation(file, allFiles),

app/assets/javascripts/diffs/utils/uuids.js

@@ -11,9 +11,6 @@
  * @typedef {String} UUIDv4
  */
 
-// https://gitlab.com/gitlab-org/frontend/rfcs/-/issues/20
-/* eslint-disable import/prefer-default-export */
-
 import MersenneTwister from 'mersenne-twister';
 import stringHash from 'string-hash';
 import { isString } from 'lodash';

app/assets/javascripts/environments/stores/helpers.js

@@ -4,5 +4,4 @@
  * @param {Object} environment
  * @returns {Object}
  */
-// eslint-disable-next-line import/prefer-default-export
 export const setDeployBoard = (oldEnvironmentState, environment) => environment;

app/assets/javascripts/error_tracking/store/details/actions.js

@@ -10,7 +10,6 @@ const stopPolling = poll => {
   if (poll) poll.stop();
 };
 
-// eslint-disable-next-line import/prefer-default-export
 export function startPollingStacktrace({ commit }, endpoint) {
   stackTracePoll = new Poll({
     resource: service,

app/assets/javascripts/error_tracking/store/details/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const stacktrace = state =>
   state.stacktraceData.stack_trace_entries
     ? state.stacktraceData.stack_trace_entries.reverse()

app/assets/javascripts/frequent_items/store/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const hasSearchQuery = state => state.searchQuery !== '';

app/assets/javascripts/ide/ide_router.js

@@ -33,7 +33,6 @@ const EmptyRouterComponent = {
   },
 };
 
-// eslint-disable-next-line import/prefer-default-export
 export const createRouter = store => {
   const router = new IdeRouter({
     mode: 'history',

app/assets/javascripts/ide/lib/diff/diff.js

 import { diffLines } from 'diff';
 import { defaultDiffOptions } from '../editor_options';
 
-// See: https://gitlab.com/gitlab-org/frontend/rfcs/-/issues/20
-// eslint-disable-next-line import/prefer-default-export
 export const computeDiff = (originalContent, newContent) => {
   // prevent EOL changes from highlighting the entire file
   const changes = diffLines(

app/assets/javascripts/ide/lib/editorconfig/parser.js

@@ -42,7 +42,6 @@ function getRulesWithConfigs(filePath, configFiles = [], rules = {}) {
   return isRoot ? result : getRulesWithConfigs(filePath, nextConfigs, result);
 }
 
-// eslint-disable-next-line import/prefer-default-export
 export function getRulesWithTraversal(filePath, getFileContent) {
   const editorconfigPaths = [
     ...getPathParents(filePath).map(x => `${x}/.editorconfig`),

app/assets/javascripts/ide/services/gql.js

@@ -17,5 +17,4 @@ const getClient = memoize(() =>
   ),
 );
 
-// eslint-disable-next-line import/prefer-default-export
 export const query = (...args) => getClient().query(...args);

app/assets/javascripts/ide/stores/modules/pane/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const isAliveView = state => view =>
   state.keepAliveViews[view] || (state.isOpen && state.currentView === view);

app/assets/javascripts/ide/stores/modules/pipelines/constants.js

-// eslint-disable-next-line import/prefer-default-export
 export const states = {
   failed: 'failed',
 };

app/assets/javascripts/ide/stores/modules/pipelines/utils.js

-// eslint-disable-next-line import/prefer-default-export
 export const normalizeJob = job => ({
   id: job.id,
   name: job.name,

app/assets/javascripts/ide/stores/modules/router/actions.js

 import * as types from './mutation_types';
 
-// eslint-disable-next-line import/prefer-default-export
 export const push = ({ commit }, fullPath) => {
   commit(types.PUSH, fullPath);
 };

app/assets/javascripts/ide/stores/modules/router/mutation_types.js

-// eslint-disable-next-line import/prefer-default-export
 export const PUSH = 'PUSH';

app/assets/javascripts/ide/stores/modules/terminal/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const allCheck = state => {
   const checks = Object.values(state.checks);
 

app/assets/javascripts/ide/sync_router_and_store.js

-/* eslint-disable import/prefer-default-export */
 /**
  * This method adds listeners to the given router and store and syncs their state with eachother
  *

app/assets/javascripts/import_projects/utils.js

 import { STATUSES } from './constants';
 
 // Will be expanded in future
-// eslint-disable-next-line import/prefer-default-export
 export function isProjectImportable(project) {
   return project.importStatus === STATUSES.NONE && !project.importSource.incompatible;
 }

app/assets/javascripts/integrations/edit/store/actions.js

 import * as types from './mutation_types';
 
-// eslint-disable-next-line import/prefer-default-export
 export const setOverride = ({ commit }, override) => commit(types.SET_OVERRIDE, override);

app/assets/javascripts/integrations/edit/store/index.js

@@ -7,7 +7,6 @@ import createState from './state';
 
 Vue.use(Vuex);
 
-// eslint-disable-next-line import/prefer-default-export
 export const createStore = (initialState = {}) =>
   new Vuex.Store({
     actions,

app/assets/javascripts/integrations/edit/store/mutation_types.js

-// eslint-disable-next-line import/prefer-default-export
 export const SET_OVERRIDE = 'SET_OVERRIDE';

app/assets/javascripts/issuables_list/service_desk_helper.js

@@ -3,7 +3,6 @@ import { __ } from '~/locale';
 /**
  * Returns the attributes used for gl-empty-state in the Service Desk issues list.
  */
-// eslint-disable-next-line import/prefer-default-export
 export function emptyStateHelper(emptyStateMeta) {
   const { isServiceDeskSupported, svgPath, serviceDeskHelpPage } = emptyStateMeta;
 

app/assets/javascripts/lib/utils/image_utility.js

-/* eslint-disable import/prefer-default-export */
-
 export function isImageLoaded(element) {
   return element.complete && element.naturalHeight !== 0;
 }

app/assets/javascripts/lib/utils/set.js

@@ -4,6 +4,5 @@
  * @param {Set} superset The set to be considered as the superset.
  * @returns {boolean}
  */
-// eslint-disable-next-line import/prefer-default-export
 export const isSubset = (subset, superset) =>
   Array.from(subset).every(value => superset.has(value));

app/assets/javascripts/lib/utils/type_utility.js

-// eslint-disable-next-line import/prefer-default-export
 export const isObject = obj => obj && obj.constructor === Object;

app/assets/javascripts/lib/utils/webpack.js

 import { joinPaths } from '~/lib/utils/url_utility';
 
 // tell webpack to load assets from origin so that web workers don't break
-// eslint-disable-next-line import/prefer-default-export
 export function resetServiceWorkersPublicPath() {
   // __webpack_public_path__ is a global variable that can be used to adjust
   // the webpack publicPath setting at runtime.

app/assets/javascripts/monitoring/csv_export.js

@@ -125,7 +125,6 @@ const csvData = (metricHeaders, metricValues) => {
  * @param {Object} graphData - Panel contents
  * @returns {String}
  */
-// eslint-disable-next-line import/prefer-default-export
 export const graphDataToCsv = graphData => {
   const delimiter = ',';
   const br = '\r\n';

app/assets/javascripts/monitoring/stores/embed_group/actions.js

 import * as types from './mutation_types';
 
-// eslint-disable-next-line import/prefer-default-export
 export const addModule = ({ commit }, data) => commit(types.ADD_MODULE, data);

app/assets/javascripts/monitoring/stores/embed_group/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const metricsWithData = (state, getters, rootState, rootGetters) =>
   state.modules.map(module => rootGetters[`${module}/metricsWithData`]().length);

app/assets/javascripts/monitoring/stores/embed_group/mutation_types.js

-// eslint-disable-next-line import/prefer-default-export
 export const ADD_MODULE = 'ADD_MODULE';

app/assets/javascripts/pages/constants.js

-/* eslint-disable import/prefer-default-export  */
-
 export const FILTERED_SEARCH = {
   MERGE_REQUESTS: 'merge_requests',
   ISSUES: 'issues',

app/assets/javascripts/pages/projects/constants.js

-/* eslint-disable import/prefer-default-export  */
-
 export const ISSUABLE_INDEX = {
   MERGE_REQUEST: 'merge_request_',
   ISSUE: 'issue_',

app/assets/javascripts/pipelines/utils.js

 import { pickBy } from 'lodash';
 import { SUPPORTED_FILTER_PARAMETERS } from './constants';
 
-// eslint-disable-next-line import/prefer-default-export
 export const validateParams = params => {
   return pickBy(params, (val, key) => SUPPORTED_FILTER_PARAMETERS.includes(key) && val);
 };

app/assets/javascripts/registry/explorer/stores/index.js

@@ -7,7 +7,6 @@ import state from './state';
 
 Vue.use(Vuex);
 
-// eslint-disable-next-line import/prefer-default-export
 export const createStore = () =>
   new Vuex.Store({
     state,

app/assets/javascripts/registry/explorer/utils.js

-// eslint-disable-next-line import/prefer-default-export
 export const decodeAndParse = param => JSON.parse(window.atob(param));

app/assets/javascripts/reports/store/getters.js

 import { LOADING, ERROR, SUCCESS, STATUS_FAILED } from '../constants';
 
-// eslint-disable-next-line import/prefer-default-export
 export const summaryStatus = state => {
   if (state.isLoading) {
     return LOADING;

app/assets/javascripts/repository/utils/commit.js

-// eslint-disable-next-line import/prefer-default-export
 export function normalizeData(data, path, extra = () => {}) {
   return data.map(d => ({
     sha: d.commit.id,

app/assets/javascripts/repository/utils/icon.js

@@ -88,7 +88,6 @@ const fileTypeIcons = [
   },
 ];
 
-// eslint-disable-next-line import/prefer-default-export
 export const getIconName = (type, path) => {
   if (entryTypeIcons[type]) return entryTypeIcons[type];
 

app/assets/javascripts/repository/utils/readme.js

@@ -28,5 +28,4 @@ const isPlainReadme = file => {
   return re.test(file.name);
 };
 
-// eslint-disable-next-line import/prefer-default-export
 export const readmeFile = blobs => blobs.find(isRichReadme) || blobs.find(isPlainReadme);

app/assets/javascripts/snippets/mixins/snippets.js

@@ -2,7 +2,6 @@ import GetSnippetQuery from '../queries/snippet.query.graphql';
 
 const blobsDefault = [];
 
-// eslint-disable-next-line import/prefer-default-export
 export const getSnippetMixin = {
   apollo: {
     snippet: {

app/assets/javascripts/static_site_editor/services/image_service.js

-// eslint-disable-next-line import/prefer-default-export
 export const getBinary = file => {
   return new Promise((resolve, reject) => {
     const reader = new FileReader();

app/assets/javascripts/vue_merge_request_widget/stores/artifacts_list/getters.js

 import { s__, n__ } from '~/locale';
 
-// eslint-disable-next-line import/prefer-default-export
 export const title = state => {
   if (state.isLoading) {
     return s__('BuildArtifacts|Loading artifacts');

app/assets/javascripts/vue_shared/components/filtered_search_bar/filtered_search_utils.js

-// eslint-disable-next-line import/prefer-default-export
 export const stripQuotes = value => {
   return value.includes(' ') ? value.slice(1, -1) : value;
 };

app/assets/javascripts/vue_shared/components/lib/utils/diff_utils.js

-/* eslint-disable import/prefer-default-export */
-
 function trimFirstCharOfLineContent(text) {
   if (!text) {
     return text;

app/assets/javascripts/vuex_shared/bindings.js

@@ -9,7 +9,6 @@
  * @param {string} root - the key of the state where to search fo they keys described in list
  * @returns {Object} a dictionary with all the computed properties generated
  */
-// eslint-disable-next-line import/prefer-default-export
 export const mapComputed = (list, defaultUpdateFn, root) => {
   const result = {};
   list.forEach(item => {

doc/development/fe_guide/vuex.md

@@ -55,10 +55,6 @@ export const createStore = () =>
   });
 ```
 
-_Note:_ Until this
-[RFC](https://gitlab.com/gitlab-org/frontend/rfcs/-/issues/20) is implemented,
-the above will need to disable the `import/prefer-default-export` ESLint rule.
-
 ### `state.js`
 
 The first thing you should do before writing any code is to design the state.

ee/app/assets/javascripts/analytics/cycle_analytics/store/modules/custom_stages/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const customStageFormActive = ({ isCreatingCustomStage, isEditingCustomStage }) =>
   Boolean(isCreatingCustomStage || isEditingCustomStage);

ee/app/assets/javascripts/analytics/merge_request_analytics/utils.js

@@ -18,7 +18,6 @@ import { dateFormats } from '../shared/constants';
  *
  * @return {Array} the computed month data
  */
-// eslint-disable-next-line import/prefer-default-export
 export const computeMonthRangeData = (startDate, endDate, format = dateFormats.isoDate) => {
   const monthData = [];
   const monthNames = getMonthNames(true);

ee/app/assets/javascripts/analytics/productivity_analytics/store/actions.js

 import SET_ENDPOINT from './mutation_types';
 
-// eslint-disable-next-line import/prefer-default-export
 export const setEndpoint = ({ commit }, endpoint) => commit(SET_ENDPOINT, endpoint);

ee/app/assets/javascripts/analytics/productivity_analytics/store/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const getMetricTypes = state => chartKey =>
   state.metricTypes.filter(m => m.charts.indexOf(chartKey) !== -1);

ee/app/assets/javascripts/approvals/stores/modules/base/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const isEmpty = state => !state.rules || !state.rules.length;

ee/app/assets/javascripts/billings/stores/modules/subscription/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const isFreePlan = state => state.plan.code === null;

ee/app/assets/javascripts/dependencies/components/constants.js

 // Limit the number of vulnerabilities to display so as to avoid jank.
 // In practice, this limit will probably never be reached, since the
 // largest number of vulnerabilities we've seen one dependency have is 20.
-// eslint-disable-next-line import/prefer-default-export
 export const MAX_DISPLAYED_VULNERABILITIES_PER_DEPENDENCY = 50;

ee/app/assets/javascripts/dependencies/store/constants.js

 import { s__ } from '~/locale';
 import { FILTER } from './modules/list/constants';
 
-// eslint-disable-next-line import/prefer-default-export
 export const DEPENDENCY_LIST_TYPES = {
   all: {
     namespace: 'allDependencies',

ee/app/assets/javascripts/dependencies/store/utils.js

 import listModule from './modules/list';
 
-// eslint-disable-next-line import/prefer-default-export
 export const addListType = (store, listType) => {
   const { initialState, namespace } = listType;
   store.registerModule(namespace, listModule());

ee/app/assets/javascripts/environments/stores/helpers.js

@@ -4,7 +4,6 @@
  * @param {Object} environment
  * @returns {Object}
  */
-// eslint-disable-next-line import/prefer-default-export
 export const setDeployBoard = (oldEnvironmentState, environment) => {
   let parsedEnvironment = environment;
   if (environment.size === 1 && environment.rollout_status) {

ee/app/assets/javascripts/filtered_search/constants.js

-/* eslint-disable import/prefer-default-export */
 import { USER_TOKEN_TYPES as CE_USER_TOKEN_TYPES } from '~/filtered_search/constants';
 
 export const USER_TOKEN_TYPES = [...CE_USER_TOKEN_TYPES, 'approver', 'approved-by'];

ee/app/assets/javascripts/geo_node_form/store/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const formHasError = state => Object.values(state.formErrors).some(val => Boolean(val));

ee/app/assets/javascripts/geo_replicable/store/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const replicableTypeName = state => state.replicableType.split('_').join(' ');

ee/app/assets/javascripts/geo_replicable/utils.js

@@ -7,7 +7,6 @@ import createGqClient, { fetchPolicies } from '~/lib/graphql';
   think the sync process is broken.
 */
 
-// eslint-disable-next-line import/prefer-default-export
 export const gqClient = createGqClient(
   {},
   {

ee/app/assets/javascripts/geo_settings/store/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const formHasError = state =>
   Object.keys(state.formErrors)
     .map(key => state.formErrors[key])

ee/app/assets/javascripts/issues_analytics/utils.js

@@ -7,7 +7,6 @@
  *
  * @returns {Object} the transformed filters for the public api
  */
-// eslint-disable-next-line import/prefer-default-export
 export const transformFilters = ({
   label_name: labels = null,
   milestone_title: milestone = null,

ee/app/assets/javascripts/license_compliance/store/constants.js

-/* eslint-disable import/prefer-default-export */
 export const LICENSE_LIST = 'licenseList';

ee/app/assets/javascripts/licenses/store/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const hasLicenses = state => state.licenses.length > 0;

ee/app/assets/javascripts/on_demand_scans/constants.js

-/* eslint-disable import/prefer-default-export */
 export const SCAN_TYPES = {
   PASSIVE: 'PASSIVE',
 };

ee/app/assets/javascripts/pages/groups/saml_providers/saml_members/store/actions.js

@@ -4,7 +4,6 @@ import { deprecatedCreateFlash as createFlash } from '~/flash';
 import { normalizeHeaders, parseIntPagination } from '~/lib/utils/common_utils';
 import * as types from './mutation_types';
 
-// eslint-disable-next-line import/prefer-default-export
 export function fetchPage({ commit, state }, newPage) {
   return Api.groupMembers(state.groupId, {
     with_saml_identity: 'true',

ee/app/assets/javascripts/pages/groups/saml_providers/saml_members/store/mutation_types.js

-// eslint-disable-next-line import/prefer-default-export
 export const RECEIVE_SAML_MEMBERS_SUCCESS = 'RECEIVE_SAML_MEMBERS_SUCCESS';

ee/app/assets/javascripts/pages/projects/pipelines/show/utils.js

-/* eslint-disable import/prefer-default-export */
 /**
  *
  * Sets the text content of a DOM element to a given value.

ee/app/assets/javascripts/repository/utils/commit.js

 import { normalizeData as normalizeDataFOSS } from '~/repository/utils/commit';
 
-// eslint-disable-next-line import/prefer-default-export
 export function normalizeData(data, path) {
   return normalizeDataFOSS(data, path, d => ({
     lockLabel: d.lock_label || false,

ee/app/assets/javascripts/security_configuration/modules/configuration/actions.js

@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/browser';
 import axios from '~/lib/utils/axios_utils';
 import * as types from './mutation_types';
 
-// eslint-disable-next-line import/prefer-default-export
 export const fetchSecurityConfiguration = ({ commit, state }) => {
   if (!state.securityConfigurationPath) {
     return commit(types.RECEIVE_SECURITY_CONFIGURATION_ERROR);

ee/app/assets/javascripts/security_dashboard/constants.js

-/* eslint-disable import/prefer-default-export */
 export const COLLAPSE_SECURITY_REPORTS_SUMMARY_LOCAL_STORAGE_KEY =
   'hide_pipelines_security_reports_summary_details';

ee/app/assets/javascripts/security_dashboard/store/modules/pipeline_jobs/constants.js

-/* eslint-disable import/prefer-default-export */
 export const FUZZING_STAGE = 'fuzz';

ee/app/assets/javascripts/security_dashboard/store/modules/unscanned_projects/utils.js

-/* eslint-disable import/prefer-default-export */
 import { getDayDifference, isValidDate } from '~/lib/utils/datetime_utility';
 
 /**

ee/app/assets/javascripts/security_dashboard/store/modules/vulnerabilities/utils.js

-/* eslint-disable import/prefer-default-export */
 import { isEqual } from 'lodash';
 
 const isVulnerabilityLike = object =>

ee/app/assets/javascripts/security_dashboard/store/modules/vulnerable_projects/getters.js

 import { SEVERITY_GROUPS, SEVERITY_LEVELS_ORDERED_BY_SEVERITY } from './constants';
 import { projectsForSeverityGroup, addMostSevereVulnerabilityInformation } from './utils';
 
-// eslint-disable-next-line import/prefer-default-export
 export const severityGroups = ({ projects }) => {
   // add data about it's most severe vulnerability to each project
   const projectsWithSeverityInformation = projects.map(

ee/app/assets/javascripts/threat_monitoring/store/modules/network_policies/getters.js

-/* eslint-disable import/prefer-default-export */
 import { PREDEFINED_NETWORK_POLICIES } from 'ee/threat_monitoring/constants';
 
 export const policiesWithDefaults = ({ policies }) => {

ee/app/assets/javascripts/threat_monitoring/store/modules/threat_monitoring_statistics/getters.js

-// eslint-disable-next-line import/prefer-default-export
 export const hasHistory = ({ statistics: { history } }) =>
   Boolean(history.nominal.length || history.anomalous.length);

ee/app/assets/javascripts/vue_shared/components/sidebar/epics_select/constants.js

-// eslint-disable-next-line import/prefer-default-export
 export const DropdownVariant = {
   Sidebar: 'sidebar',
   Standalone: 'standalone',

ee/app/assets/javascripts/vue_shared/license_compliance/store/constants.js

-/* eslint-disable import/prefer-default-export */
 export const LICENSE_MANAGEMENT = 'licenseManagement';

ee/spec/frontend/billings/helpers.js

 import subscriptionState from 'ee/billings/stores/modules/subscription/state';
 
-// eslint-disable-next-line import/prefer-default-export
 export const resetStore = store => {
   const newState = {
     subscription: subscriptionState(),

ee/spec/frontend/dependencies/components/utils.js

-// eslint-disable-next-line import/prefer-default-export
 export const makeDependency = (changes = {}) => ({
   name: 'left-pad',
   version: '0.0.3',

ee/spec/frontend/license_compliance/components/utils.js

-// eslint-disable-next-line import/prefer-default-export
 export const makeLicense = (changes = {}) => ({
   name: 'Apache 2.0',
   url: 'http://www.apache.org/licenses/LICENSE-2.0.txt',

ee/spec/frontend/security_configuration/components/helpers.js

-// eslint-disable-next-line import/prefer-default-export
 export const generateFeatures = (n, overrides = {}) => {
   return [...Array(n).keys()].map(i => ({
     type: `scan-type-${i}`,

ee/spec/frontend/security_configuration/sast/components/helpers.js

@@ -7,7 +7,6 @@
  *     generated entities.
  * @returns {Object[]}
  */
-// eslint-disable-next-line import/prefer-default-export
 export const makeEntities = (count, changes) =>
   [...Array(count).keys()].map(i => ({
     defaultValue: `defaultValue${i}`,

ee/spec/frontend/security_dashboard/helpers.js

 import vulnerabilitiesState from 'ee/security_dashboard/store/modules/vulnerabilities/state';
 import filterState from 'ee/security_dashboard/store/modules/filters/state';
 
-// eslint-disable-next-line import/prefer-default-export
 export const resetStore = store => {
   const newState = {
     vulnerabilities: vulnerabilitiesState(),

package.json

@@ -160,7 +160,7 @@
   },
   "devDependencies": {
     "@babel/plugin-transform-modules-commonjs": "^7.10.1",
-    "@gitlab/eslint-plugin": "3.2.0",
+    "@gitlab/eslint-plugin": "4.0.0",
     "@testing-library/dom": "^7.16.2",
     "@vue/test-utils": "1.0.0-beta.30",
     "acorn": "^6.3.0",

spec/frontend/batch_comments/mock_data.js

 import { TEST_HOST } from 'spec/test_constants';
 
-// eslint-disable-next-line import/prefer-default-export
 export const createDraft = () => ({
   author: {
     id: 1,

spec/frontend/diffs/mock_data/diff_metadata.js

-/* eslint-disable import/prefer-default-export */
-/* https://gitlab.com/gitlab-org/frontend/rfcs/-/issues/20 */
-
 export const diffMetadata = {
   real_size: '1',
   size: 1,

spec/frontend/helpers/dom_events_helper.js

-// eslint-disable-next-line import/prefer-default-export
 export const triggerDOMEvent = type => {
   window.document.dispatchEvent(
     new Event(type, {

spec/frontend/helpers/fake_request_animation_frame.js

-// eslint-disable-next-line import/prefer-default-export
 export const useFakeRequestAnimationFrame = () => {
   let orig;
 

spec/frontend/helpers/jest_helpers.js

-/* eslint-disable import/prefer-default-export */
-
 /*
 @module
 

spec/frontend/helpers/locale_helper.js

-/* eslint-disable import/prefer-default-export */
-
 export const setLanguage = languageCode => {
   const htmlElement = document.querySelector('html');
 

spec/frontend/integrations/edit/mock_data.js

-// eslint-disable-next-line import/prefer-default-export
 export const mockIntegrationProps = {
   id: 25,
   activeToggleProps: {

spec/frontend/issue_show/helpers.js

-// eslint-disable-next-line import/prefer-default-export
 export const keyboardDownEvent = (code, metaKey = false, ctrlKey = false) => {
   const e = new CustomEvent('keydown');
 

spec/frontend/jobs/store/helpers.js

 import state from '~/jobs/store/state';
 
-// eslint-disable-next-line import/prefer-default-export
 export const resetStore = store => {
   store.replaceState(state());
 };

spec/frontend/mocks/mocks_helper.js

@@ -29,7 +29,6 @@ const getMockFiles = root => readdir.sync(root, { deep: MAX_DEPTH, filter: mockF
 const defaultSetMock = (srcPath, mockPath) =>
   jest.mock(srcPath, () => jest.requireActual(mockPath));
 
-// eslint-disable-next-line import/prefer-default-export
 export const setupManualMocks = function setupManualMocks(setMock = defaultSetMock) {
   prefixMap.forEach(({ mocksRoot, requirePrefix }) => {
     const mocksRootAbsolute = path.join(__dirname, mocksRoot);

spec/frontend/notes/helpers.js

-// eslint-disable-next-line import/prefer-default-export
 export const resetStore = store => {
   store.replaceState({
     notes: [],

spec/frontend/registry/shared/mocks.js

-// eslint-disable-next-line import/prefer-default-export
 export const $toast = {
   show: jest.fn(),
 };

spec/frontend/releases/stores/modules/list/helpers.js

 import state from '~/releases/stores/modules/list/state';
 
-// eslint-disable-next-line import/prefer-default-export
 export const resetStore = store => {
   store.replaceState(state());
 };

spec/frontend/reports/accessibility_report/mock_data.js

-// eslint-disable-next-line import/prefer-default-export
 export const mockReport = {
   status: 'failed',
   summary: {

spec/frontend/serverless/utils.js

-// eslint-disable-next-line import/prefer-default-export
 export const adjustMetricQuery = data => {
   const updatedMetric = data.metrics;
 

spec/frontend/vue_mr_widget/components/mock_data.js

-// eslint-disable-next-line import/prefer-default-export
 export const artifactsList = [
   {
     text: 'result.txt',

spec/frontend_integration/test_helpers/factories/commit.js

@@ -2,7 +2,6 @@ import { withValues } from '../utils/obj';
 import { getCommit } from '../fixtures';
 import { createCommitId } from './commit_id';
 
-// eslint-disable-next-line import/prefer-default-export
 export const createNewCommit = ({ id = createCommitId(), message }, orig = getCommit()) => {
   return withValues(orig, {
     id,

spec/frontend_integration/test_helpers/mock_server/graphql.js

@@ -16,6 +16,5 @@ const graphqlResolvers = {
   },
 };
 
-// eslint-disable-next-line import/prefer-default-export
 export const graphqlQuery = (query, variables, schema) =>
   graphql(graphqlSchema, query, graphqlResolvers, schema, variables);

spec/frontend_integration/test_helpers/utils/overclock_timers.js

@@ -31,7 +31,6 @@
  *
  * @param {Number} boost
  */
-// eslint-disable-next-line import/prefer-default-export
 export const useOverclockTimers = (boost = 50) => {
   if (boost <= 0) {
     throw new Error(`[overclock_timers] boost (${boost}) cannot be <= 0`);

yarn.lock

@@ -827,10 +827,10 @@
   resolved "https://registry.yarnpkg.com/@gitlab/at.js/-/at.js-1.5.5.tgz#5f6bfe6baaef360daa9b038fa78798d7a6a916b4"
   integrity sha512-282Dn3SPVsUHVDhMsXgfnv+Rzog0uxecjttxGRQvxh25es1+xvkGQFsvJfkSKJ3X1kHVkSjKf+Tt5Rra+Jhp9g==
 
-"@gitlab/eslint-plugin@3.2.0":
-  version "3.2.0"
-  resolved "https://registry.yarnpkg.com/@gitlab/eslint-plugin/-/eslint-plugin-3.2.0.tgz#e1780c2cab4c206e4900f2a1a4cf636f788182ea"
-  integrity sha512-3s28sQoGMgmwKtmVij7TjBDdW6fHiP4k6k6FWZdU6XZBJFwwA0JlU8PzYZRRTyY+pYed2u1jF06LHzv5YWNS2g==
+"@gitlab/eslint-plugin@4.0.0":
+  version "4.0.0"
+  resolved "https://registry.yarnpkg.com/@gitlab/eslint-plugin/-/eslint-plugin-4.0.0.tgz#7beba53dea74f458d92040a8b2652e4fd60a6cc7"
+  integrity sha512-Gba9HXwWOLAN+O2H8WmGNPZFQ410wiGFmhgDQ5Sx4ic/N1ymtwNen2pnsaWcw8KK/1vAB/rHNUhH4Xu/l/mfMg==
   dependencies:
     babel-eslint "^10.0.3"
     eslint-config-airbnb-base "^14.0.0"