Improve tests

ee/spec/controllers/projects/prometheus/metrics_controller_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe Projects::Prometheus::MetricsController do
   let(:user) { create(:user) }
-  let!(:project) { create(:prometheus_project) }
+  let(:project) { create(:prometheus_project) }
 
   let(:prometheus_service) { project.prometheus_service }
 

ee/spec/factories/prometheus_metrics.rb

@@ -5,7 +5,7 @@ FactoryBot.define do
     y_label 'y_label'
     unit 'm/s'
     group :business
-    legend 'legend'
     project
+    legend 'legend'
   end
 end

ee/spec/models/prometheus_metric_spec.rb

@@ -9,11 +9,11 @@ describe PrometheusMetric do
   it { is_expected.to validate_presence_of(:group) }
 
   describe '#group_title' do
-    shared_examples 'group_title' do |group, text|
+    shared_examples 'group_title' do |group, title|
       subject { build(:prometheus_metric, group: group).group_title }
 
-      it "returns text #{text} for group #{group}" do
-        expect(subject).to eq(text)
+      it "returns text #{title} for group #{group}" do
+        expect(subject).to eq(title)
       end
     end