Merge branch 'prevent_blocked_user_notification' into 'master'

Prevent blocked user from triggering notifications

See merge request gitlab-org/gitlab!53788

app/models/note.rb

@@ -542,7 +542,7 @@ class Note < ApplicationRecord
   end
 
   def skip_notification?
-    review.present? || author.ghost?
+    review.present? || author.blocked? || author.ghost?
   end
 
   private

changelogs/unreleased/prevent_blocked_user_notification.yml

+---
+title: Prevent blocked user from triggering notifications
+merge_request: 53788
+author:
+type: other

spec/workers/new_note_worker_spec.rb

@@ -66,6 +66,16 @@ RSpec.describe NewNoteWorker do
     end
   end
 
+  context 'when Note author has been blocked' do
+    let_it_be(:note) { create(:note, author: create(:user, :blocked)) }
+
+    it "does not call NotificationService" do
+      expect(NotificationService).not_to receive(:new)
+
+      described_class.new.perform(note.id)
+    end
+  end
+
   context 'when Note author has been deleted' do
     let_it_be(:note) { create(:note, author: User.ghost) }