Commit bf768e86 authored by Arturo Herrero's avatar Arturo Herrero

Remove parameter in PropagateIntegrationWorker

We have deprecated and removed overwrite parameter in
PropagateIntegrationWorker:
- Provide a default value 13.4
  https://gitlab.com/gitlab-org/gitlab/-/merge_requests/40381
- Stop using the argument in perform_async 13.5
  https://gitlab.com/gitlab-org/gitlab/-/merge_requests/43303
- Remove overwrite parameter in PropagateIntegrationWorker 14.0 => We
  are here
parent 36281d70
...@@ -9,9 +9,7 @@ class PropagateIntegrationWorker ...@@ -9,9 +9,7 @@ class PropagateIntegrationWorker
idempotent! idempotent!
loggable_arguments 1 loggable_arguments 1
# TODO: Keep overwrite parameter for backwards compatibility. Remove after >= 14.0 def perform(integration_id)
# https://gitlab.com/gitlab-org/gitlab/-/issues/255382
def perform(integration_id, overwrite = nil)
Admin::PropagateIntegrationService.propagate(Integration.find(integration_id)) Admin::PropagateIntegrationService.propagate(Integration.find(integration_id))
end end
end end
...@@ -21,11 +21,5 @@ RSpec.describe PropagateIntegrationWorker do ...@@ -21,11 +21,5 @@ RSpec.describe PropagateIntegrationWorker do
subject.perform(integration.id) subject.perform(integration.id)
end end
it 'ignores overwrite parameter from previous version' do
expect(Admin::PropagateIntegrationService).to receive(:propagate).with(integration)
subject.perform(integration.id, true)
end
end end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment