Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c01227e4
Commit
c01227e4
authored
Sep 28, 2020
by
Michael Le
Committed by
Enrique Alcántara
Sep 28, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replace popover with GlPopover component
parent
12147d80
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
18 additions
and
5 deletions
+18
-5
app/assets/javascripts/ide/components/commit_sidebar/message_field.vue
...vascripts/ide/components/commit_sidebar/message_field.vue
+13
-5
changelogs/unreleased/43499-update-commit-message-popover.yml
...gelogs/unreleased/43499-update-commit-message-popover.yml
+5
-0
No files found.
app/assets/javascripts/ide/components/commit_sidebar/message_field.vue
View file @
c01227e4
<
script
>
import
{
GlIcon
}
from
'
@gitlab/ui
'
;
import
{
GlIcon
,
GlPopover
}
from
'
@gitlab/ui
'
;
import
{
__
,
sprintf
}
from
'
../../../locale
'
;
import
popover
from
'
../../../vue_shared/directives/popover
'
;
import
{
MAX_TITLE_LENGTH
,
MAX_BODY_LENGTH
}
from
'
../../constants
'
;
...
...
@@ -10,6 +10,7 @@ export default {
},
components
:
{
GlIcon
,
GlPopover
,
},
props
:
{
text
:
{
...
...
@@ -58,7 +59,7 @@ export default {
},
},
popoverOptions
:
{
trigger
:
'
hover
'
,
trigger
s
:
'
hover
'
,
placement
:
'
top
'
,
content
:
sprintf
(
__
(
`
...
...
@@ -83,9 +84,16 @@ export default {
<ul
class=
"nav-links"
>
<li>
{{
__
(
'
Commit Message
'
)
}}
<span
v-popover=
"$options.popoverOptions"
class=
"form-text text-muted gl-ml-3"
>
<div
id=
"ide-commit-message-popover-container"
>
<span
id=
"ide-commit-message-question"
class=
"form-text text-muted gl-ml-3"
>
<gl-icon
name=
"question"
/>
</span>
<gl-popover
target=
"ide-commit-message-question"
container=
"ide-commit-message-popover-container"
v-bind=
"$options.popoverOptions"
/>
</div>
</li>
</ul>
</div>
...
...
changelogs/unreleased/43499-update-commit-message-popover.yml
0 → 100644
View file @
c01227e4
---
title
:
Update popover to gl-popover on WebIDE commit message
merge_request
:
43499
author
:
type
:
other
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment