Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c10f1a87
Commit
c10f1a87
authored
Jan 12, 2021
by
Grzegorz Bizon
Committed by
Grzegorz Bizon
Jan 12, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Merge branch 'fix/gb/ci-build-stuck-badge-performance-experiment' into 'master'"
This reverts merge request !50521
parent
3e96111d
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
4 additions
and
41 deletions
+4
-41
app/models/ci/build.rb
app/models/ci/build.rb
+1
-7
changelogs/unreleased/fix-gb-ci-build-stuck-badge-performance-experiment.yml
...ed/fix-gb-ci-build-stuck-badge-performance-experiment.yml
+0
-5
config/feature_flags/development/ci_build_stuck_badge_performance_experiment.yml
...velopment/ci_build_stuck_badge_performance_experiment.yml
+0
-8
spec/models/ci/build_spec.rb
spec/models/ci/build_spec.rb
+3
-21
No files found.
app/models/ci/build.rb
View file @
c10f1a87
...
...
@@ -726,13 +726,7 @@ module Ci
end
def
any_runners_online?
project
.
any_runners?
do
|
runner
|
if
Feature
.
enabled?
(
:ci_build_stuck_badge_performance_experiment
,
project
,
type: :development
,
default_enabled:
false
)
runner
.
active?
&&
runner
.
online?
else
runner
.
active?
&&
runner
.
online?
&&
runner
.
can_pick?
(
self
)
end
end
project
.
any_runners?
{
|
runner
|
runner
.
active?
&&
runner
.
online?
&&
runner
.
can_pick?
(
self
)
}
end
def
stuck?
...
...
changelogs/unreleased/fix-gb-ci-build-stuck-badge-performance-experiment.yml
deleted
100644 → 0
View file @
3e96111d
---
title
:
Add build stuck badge performance experiment
merge_request
:
50521
author
:
type
:
performance
config/feature_flags/development/ci_build_stuck_badge_performance_experiment.yml
deleted
100644 → 0
View file @
3e96111d
---
name
:
ci_build_stuck_badge_performance_experiment
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/50521
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/295490
milestone
:
'
13.7'
type
:
development
group
:
group::continuous integration
default_enabled
:
false
spec/models/ci/build_spec.rb
View file @
c10f1a87
...
...
@@ -580,27 +580,9 @@ RSpec.describe Ci::Build do
is_expected
.
to
be_falsey
end
context
'when runners are on-line but none can pick a build'
do
before
do
allow_any_instance_of
(
Ci
::
Runner
)
.
to
receive
(
:can_pick?
).
and_return
(
false
)
end
context
'when a performance experiement feature flag is enabled'
do
before
do
stub_feature_flags
(
ci_build_stuck_badge_performance_experiment:
true
)
end
it
{
is_expected
.
to
be_truthy
}
end
context
'when a performance experiment is not running'
do
before
do
stub_feature_flags
(
ci_build_stuck_badge_performance_experiment:
false
)
end
it
{
is_expected
.
to
be_falsey
}
end
it
'that cannot handle build'
do
expect_any_instance_of
(
Ci
::
Runner
).
to
receive
(
:can_pick?
).
and_return
(
false
)
is_expected
.
to
be_falsey
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment