Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c153ff67
Commit
c153ff67
authored
Aug 24, 2020
by
Sean McGivern
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Merge branch 'sh-include-redis-in-workhorse-test' into 'master'"
This reverts merge request !40026
parent
8760601b
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
37 deletions
+6
-37
changelogs/unreleased/sh-include-redis-in-workhorse-test.yml
changelogs/unreleased/sh-include-redis-in-workhorse-test.yml
+0
-5
lib/gitlab/setup_helper.rb
lib/gitlab/setup_helper.rb
+0
-20
spec/support/helpers/test_env.rb
spec/support/helpers/test_env.rb
+6
-12
No files found.
changelogs/unreleased/sh-include-redis-in-workhorse-test.yml
deleted
100644 → 0
View file @
8760601b
---
title
:
Include Redis in Workhorse-in-test-suite integration
merge_request
:
40026
author
:
type
:
other
lib/gitlab/setup_helper.rb
View file @
c153ff67
...
@@ -28,26 +28,6 @@ module Gitlab
...
@@ -28,26 +28,6 @@ module Gitlab
end
end
# rubocop:enable Rails/Output
# rubocop:enable Rails/Output
module
Workhorse
extend
Gitlab
::
SetupHelper
class
<<
self
def
configuration_toml
(
dir
,
_
)
config
=
{
redis:
{
URL
:
redis_url
}
}
TomlRB
.
dump
(
config
)
end
def
redis_url
data
=
YAML
.
load_file
(
Rails
.
root
.
join
(
'config/resque.yml'
))
data
.
dig
(
Rails
.
env
,
'url'
)
end
def
get_config_path
(
dir
)
File
.
join
(
dir
,
'config.toml'
)
end
end
end
module
Gitaly
module
Gitaly
extend
Gitlab
::
SetupHelper
extend
Gitlab
::
SetupHelper
class
<<
self
class
<<
self
...
...
spec/support/helpers/test_env.rb
View file @
c153ff67
...
@@ -247,9 +247,8 @@ module TestEnv
...
@@ -247,9 +247,8 @@ module TestEnv
'GitLab Workhorse'
,
'GitLab Workhorse'
,
install_dir:
workhorse_dir
,
install_dir:
workhorse_dir
,
version:
Gitlab
::
Workhorse
.
version
,
version:
Gitlab
::
Workhorse
.
version
,
task:
"gitlab:workhorse:install[
#{
install_workhorse_args
}
]"
)
do
task:
"gitlab:workhorse:install[
#{
install_workhorse_args
}
]"
Gitlab
::
SetupHelper
::
Workhorse
.
create_configuration
(
workhorse_dir
,
nil
)
)
end
end
end
def
workhorse_dir
def
workhorse_dir
...
@@ -260,14 +259,6 @@ module TestEnv
...
@@ -260,14 +259,6 @@ module TestEnv
host
=
"[
#{
host
}
]"
if
host
.
include?
(
':'
)
host
=
"[
#{
host
}
]"
if
host
.
include?
(
':'
)
listen_addr
=
[
host
,
port
].
join
(
':'
)
listen_addr
=
[
host
,
port
].
join
(
':'
)
config_path
=
Gitlab
::
SetupHelper
::
Workhorse
.
get_config_path
(
workhorse_dir
)
# This should be set up in setup_workhorse, but since
# component_needs_update? only checks that versions are consistent,
# we need to ensure the config file exists. This line can be removed
# later after a new Workhorse version is updated.
Gitlab
::
SetupHelper
::
Workhorse
.
create_configuration
(
workhorse_dir
,
nil
)
unless
File
.
exist?
(
config_path
)
workhorse_pid
=
spawn
(
workhorse_pid
=
spawn
(
{
'PATH'
=>
"
#{
ENV
[
'PATH'
]
}
:
#{
workhorse_dir
}
"
},
{
'PATH'
=>
"
#{
ENV
[
'PATH'
]
}
:
#{
workhorse_dir
}
"
},
File
.
join
(
workhorse_dir
,
'gitlab-workhorse'
),
File
.
join
(
workhorse_dir
,
'gitlab-workhorse'
),
...
@@ -275,7 +266,10 @@ module TestEnv
...
@@ -275,7 +266,10 @@ module TestEnv
'-documentRoot'
,
Rails
.
root
.
join
(
'public'
).
to_s
,
'-documentRoot'
,
Rails
.
root
.
join
(
'public'
).
to_s
,
'-listenAddr'
,
listen_addr
,
'-listenAddr'
,
listen_addr
,
'-secretPath'
,
Gitlab
::
Workhorse
.
secret_path
.
to_s
,
'-secretPath'
,
Gitlab
::
Workhorse
.
secret_path
.
to_s
,
'-config'
,
config_path
,
# TODO: Needed for workhorse + redis features.
# https://gitlab.com/gitlab-org/gitlab/-/issues/209245
#
# '-config', '',
'-logFile'
,
'log/workhorse-test.log'
,
'-logFile'
,
'log/workhorse-test.log'
,
'-logFormat'
,
'structured'
,
'-logFormat'
,
'structured'
,
'-developmentMode'
# to serve assets and rich error messages
'-developmentMode'
# to serve assets and rich error messages
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment