Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c1a2a7c6
Commit
c1a2a7c6
authored
Oct 06, 2020
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix Ruby 2.7 warnings in app/services
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
0b7b8ea4
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
6 deletions
+6
-6
app/services/ci/create_downstream_pipeline_service.rb
app/services/ci/create_downstream_pipeline_service.rb
+1
-1
app/services/ci/create_pipeline_service.rb
app/services/ci/create_pipeline_service.rb
+1
-1
app/services/notification_recipients/build_service.rb
app/services/notification_recipients/build_service.rb
+4
-4
No files found.
app/services/ci/create_downstream_pipeline_service.rb
View file @
c1a2a7c6
...
@@ -33,7 +33,7 @@ module Ci
...
@@ -33,7 +33,7 @@ module Ci
pipeline_params
.
fetch
(
:target_revision
))
pipeline_params
.
fetch
(
:target_revision
))
downstream_pipeline
=
service
.
execute
(
downstream_pipeline
=
service
.
execute
(
pipeline_params
.
fetch
(
:source
),
pipeline_params
[
:execute_params
])
do
|
pipeline
|
pipeline_params
.
fetch
(
:source
),
**
pipeline_params
[
:execute_params
])
do
|
pipeline
|
pipeline
.
variables
.
build
(
@bridge
.
downstream_variables
)
pipeline
.
variables
.
build
(
@bridge
.
downstream_variables
)
end
end
...
...
app/services/ci/create_pipeline_service.rb
View file @
c1a2a7c6
...
@@ -70,7 +70,7 @@ module Ci
...
@@ -70,7 +70,7 @@ module Ci
push_options:
params
[
:push_options
]
||
{},
push_options:
params
[
:push_options
]
||
{},
chat_data:
params
[
:chat_data
],
chat_data:
params
[
:chat_data
],
bridge:
bridge
,
bridge:
bridge
,
**
extra_options
(
options
))
**
extra_options
(
**
options
))
# Ensure we never persist the pipeline when dry_run: true
# Ensure we never persist the pipeline when dry_run: true
@pipeline
.
readonly!
if
command
.
dry_run?
@pipeline
.
readonly!
if
command
.
dry_run?
...
...
app/services/notification_recipients/build_service.rb
View file @
c1a2a7c6
...
@@ -13,8 +13,8 @@ module NotificationRecipients
...
@@ -13,8 +13,8 @@ module NotificationRecipients
NotificationRecipient
.
new
(
user
,
*
args
).
notifiable?
NotificationRecipient
.
new
(
user
,
*
args
).
notifiable?
end
end
def
self
.
build_recipients
(
*
args
)
def
self
.
build_recipients
(
target
,
current_user
,
*
*
args
)
::
NotificationRecipients
::
Builder
::
Default
.
new
(
*
args
).
notification_recipients
::
NotificationRecipients
::
Builder
::
Default
.
new
(
target
,
current_user
,
*
*
args
).
notification_recipients
end
end
def
self
.
build_new_note_recipients
(
*
args
)
def
self
.
build_new_note_recipients
(
*
args
)
...
@@ -25,8 +25,8 @@ module NotificationRecipients
...
@@ -25,8 +25,8 @@ module NotificationRecipients
::
NotificationRecipients
::
Builder
::
MergeRequestUnmergeable
.
new
(
*
args
).
notification_recipients
::
NotificationRecipients
::
Builder
::
MergeRequestUnmergeable
.
new
(
*
args
).
notification_recipients
end
end
def
self
.
build_project_maintainers_recipients
(
*
args
)
def
self
.
build_project_maintainers_recipients
(
target
,
*
*
args
)
::
NotificationRecipients
::
Builder
::
ProjectMaintainers
.
new
(
*
args
).
notification_recipients
::
NotificationRecipients
::
Builder
::
ProjectMaintainers
.
new
(
target
,
*
*
args
).
notification_recipients
end
end
def
self
.
build_new_release_recipients
(
*
args
)
def
self
.
build_new_release_recipients
(
*
args
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment