Merge branch 'prevent-api-delete-groups-with-subscription' into 'master'

Prevent API Deletion of Group with a Paid gitlab.com Subscription

See merge request gitlab-org/gitlab!57533

doc/api/groups.md

@@ -975,6 +975,9 @@ Parameters:
 
 The response is `202 Accepted` if the user has authorization.
 
+NOTE:
+A GitLab.com group can't be removed if it is linked to a subscription. To remove such a group, first [link the subscription](../subscriptions/index.md#change-the-linked-namespace) with a different group.
+
 ## Restore group marked for deletion **(PREMIUM)**
 
 > [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/33257) in GitLab 12.8.

ee/changelogs/unreleased/prevent-api-delete-groups-with-subscription.yml

+---
+title: Prevent deletion of groups with a subscription via the API
+merge_request: 57533
+author:
+type: fixed

ee/spec/requests/api/groups_spec.rb

@@ -892,6 +892,28 @@ RSpec.describe API::Groups do
             expect(json_response['message']).to eq('error')
           end
         end
+
+        it 'does not mark the group for deletion when the group has a paid gitlab.com subscription' do
+          create(:gitlab_subscription, :ultimate, namespace: group)
+
+          subject
+
+          expect(response).to have_gitlab_http_status(:bad_request)
+          expect(json_response['message']).to eq("This group can't be removed because it is linked to a subscription.")
+          expect(group.marked_for_deletion_on).to be_nil
+          expect(group.deleting_user).to be_nil
+        end
+
+        it 'marks for deletion a subgroup of a group with a paid gitlab.com subscription' do
+          create(:gitlab_subscription, :ultimate, namespace: group)
+          subgroup = create(:group, parent: group)
+
+          delete api("/groups/#{subgroup.id}", user)
+
+          expect(response).to have_gitlab_http_status(:accepted)
+          expect(subgroup.marked_for_deletion_on).to eq(Date.today)
+          expect(subgroup.deleting_user).to eq(user)
+        end
       end
 
       context 'period of delayed deletion is set to 0' do
@@ -909,6 +931,22 @@ RSpec.describe API::Groups do
       end
 
       it_behaves_like 'immediately enqueues the job to delete the group'
+
+      it 'does not delete the group when the group has a paid gitlab.com subscription' do
+        create(:gitlab_subscription, :ultimate, namespace: group)
+
+        expect { subject }.not_to change(GroupDestroyWorker.jobs, :size)
+        expect(response).to have_gitlab_http_status(:bad_request)
+        expect(json_response['message']).to eq("This group can't be removed because it is linked to a subscription.")
+      end
+
+      it 'deletes a subgroup of a group with a paid gitlab.com subscription' do
+        create(:gitlab_subscription, :ultimate, namespace: group)
+        subgroup = create(:group, parent: group)
+
+        expect { delete api("/groups/#{subgroup.id}", user) }.to change(GroupDestroyWorker.jobs, :size).by(1)
+        expect(response).to have_gitlab_http_status(:accepted)
+      end
     end
   end
 

lib/api/groups.rb

@@ -141,6 +141,10 @@ module API
       def authorize_group_creation!
         authorize! :create_group
       end
+
+      def check_subscription!(group)
+        render_api_error!("This group can't be removed because it is linked to a subscription.", :bad_request) if group.paid?
+      end
     end
 
     resource :groups do
@@ -239,6 +243,7 @@ module API
       delete ":id" do
         group = find_group!(params[:id])
         authorize! :admin_group, group
+        check_subscription! group
 
         delete_group(group)
       end