Commit c57c5314 authored by Ramya Authappan's avatar Ramya Authappan

Merge branch 'qa-shl-fix-add_project_member_spec' into 'master'

Create and use a new user to avoid role based conflict

Closes #232886, #232722, and #232599

See merge request gitlab-org/gitlab!38038
parents dab994e3 107715f2
...@@ -3,8 +3,13 @@ ...@@ -3,8 +3,13 @@
module QA module QA
context 'Create' do context 'Create' do
describe 'Codeowners' do describe 'Codeowners' do
context 'when the project is in the root group' do context 'when the project is in the root group', :requires_admin do
let(:approver) { Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1) } let(:approver) do
Resource::User.fabricate_via_api! do |resource|
resource.api_client = Runtime::API::Client.as_admin
end
end
let(:root_group) { Resource::Sandbox.fabricate_via_api! } let(:root_group) { Resource::Sandbox.fabricate_via_api! }
let(:project) do let(:project) do
Resource::Project.fabricate_via_api! do |project| Resource::Project.fabricate_via_api! do |project|
...@@ -24,6 +29,7 @@ module QA ...@@ -24,6 +29,7 @@ module QA
after do after do
group_or_project.remove_member(approver) group_or_project.remove_member(approver)
approver.remove_via_api!
end end
context 'and the code owner is the root group' do context 'and the code owner is the root group' do
......
...@@ -3,8 +3,13 @@ ...@@ -3,8 +3,13 @@
module QA module QA
context 'Create' do context 'Create' do
describe 'Codeowners' do describe 'Codeowners' do
context 'when the project is in a subgroup' do context 'when the project is in a subgroup', :requires_admin do
let(:approver) { Resource::User.fabricate_or_use(Runtime::Env.gitlab_qa_username_1, Runtime::Env.gitlab_qa_password_1) } let(:approver) do
Resource::User.fabricate_via_api! do |resource|
resource.api_client = Runtime::API::Client.as_admin
end
end
let(:project) do let(:project) do
Resource::Project.fabricate_via_api! do |project| Resource::Project.fabricate_via_api! do |project|
project.name = "approve-and-merge" project.name = "approve-and-merge"
...@@ -22,6 +27,7 @@ module QA ...@@ -22,6 +27,7 @@ module QA
after do after do
group_or_project.remove_member(approver) group_or_project.remove_member(approver)
approver.remove_via_api!
end end
context 'and the code owner is the root group' do context 'and the code owner is the root group' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment