Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c922fb4b
Commit
c922fb4b
authored
Sep 06, 2017
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Respond with a bad request if artifact path is invalid
parent
80b3dcc7
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
2 deletions
+2
-2
lib/api/helpers.rb
lib/api/helpers.rb
+1
-1
lib/api/job_artifacts.rb
lib/api/job_artifacts.rb
+1
-1
No files found.
lib/api/helpers.rb
View file @
c922fb4b
...
@@ -222,7 +222,7 @@ module API
...
@@ -222,7 +222,7 @@ module API
def
bad_request!
(
attribute
)
def
bad_request!
(
attribute
)
message
=
[
"400 (Bad request)"
]
message
=
[
"400 (Bad request)"
]
message
<<
"
\"
"
+
attribute
.
to_s
+
"
\"
not given"
message
<<
"
\"
"
+
attribute
.
to_s
+
"
\"
not given"
if
attribute
render_api_error!
(
message
.
join
(
' '
),
400
)
render_api_error!
(
message
.
join
(
' '
),
400
)
end
end
...
...
lib/api/job_artifacts.rb
View file @
c922fb4b
...
@@ -52,7 +52,7 @@ module API
...
@@ -52,7 +52,7 @@ module API
path
=
Gitlab
::
Ci
::
Build
::
Artifacts
::
Path
path
=
Gitlab
::
Ci
::
Build
::
Artifacts
::
Path
.
new
(
params
[
:artifact_path
])
.
new
(
params
[
:artifact_path
])
not_found
!
unless
path
.
valid?
bad_request
!
unless
path
.
valid?
send_artifacts_entry
(
build
,
path
)
send_artifacts_entry
(
build
,
path
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment