Add backwards compatibility for creating groups with a LDAP connection

lib/api/groups.rb

@@ -44,12 +44,19 @@ module API
         authenticated_as_admin!
         required_attributes! [:name, :path]
 
-        # TODO: Refactor to support multi-ldap
-        attrs = attributes_for_keys [:name, :path, :ldap_cn, :ldap_access]
-        @group = Group.new(attrs)
+        group_attrs = attributes_for_keys [:name, :path]
+        @group = Group.new(group_attrs)
         @group.owner = current_user
 
         if @group.save
+          # NOTE: add backwards compatibility for single ldap link
+          ldap_attrs  = attributes_for_keys [:ldap_cn, :ldap_access]
+          if ldap_attrs.present?
+            @group.ldap_group_links.create({
+              cn: ldap_attrs[:ldap_cn],
+              group_access: ldap_attrs[:ldap_access]
+            })
+          end
           present @group, with: Entities::Group
         else
           not_found!

spec/requests/api/groups_spec.rb

@@ -110,6 +110,13 @@ describe API::API, api: true  do
         post api("/groups", admin), { name: 'test' }
         response.status.should == 400
       end
+
+      it "creates an ldap_group_link if ldap_cn and ldap_access are supplied" do
+        group_attributes = attributes_for(:group, ldap_cn: 'ldap-group', ldap_access: Gitlab::Access::DEVELOPER)
+        expect {
+          post api("/groups", admin), group_attributes
+        }.to change{ LdapGroupLink.count }.by(1)
+      end
     end
   end