Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
cbbb6739
Commit
cbbb6739
authored
May 03, 2021
by
Marcia Ramos
Committed by
Douglas Barbosa Alexandre
May 03, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Review UI text for pipeline error messages
parent
dc123787
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
16 additions
and
11 deletions
+16
-11
app/presenters/ci/pipeline_presenter.rb
app/presenters/ci/pipeline_presenter.rb
+9
-9
changelogs/unreleased/tw-ui-text-active-voice-pipeline-presenter.yml
...unreleased/tw-ui-text-active-voice-pipeline-presenter.yml
+5
-0
ee/spec/presenters/ci/pipeline_presenter_spec.rb
ee/spec/presenters/ci/pipeline_presenter_spec.rb
+1
-1
spec/serializers/ci/pipeline_entity_spec.rb
spec/serializers/ci/pipeline_entity_spec.rb
+1
-1
No files found.
app/presenters/ci/pipeline_presenter.rb
View file @
cbbb6739
...
...
@@ -8,15 +8,15 @@ module Ci
# We use a class method here instead of a constant, allowing EE to redefine
# the returned `Hash` more easily.
def
self
.
failure_reasons
{
unknown_failure:
'
Unknown pipeline failure!
'
,
config_error:
'
CI/CD YAML configuration error!
'
,
external_validation_failure:
'
External pipeline validation failed!
'
,
activity_limit_exceeded:
'
Pipeline activity limit exceeded!
'
,
size_limit_exceeded:
'
Pipeline size limit exceeded!
'
,
job_activity_limit_exceeded:
'
Pipeline job activity limit exceeded!
'
,
deployments_limit_exceeded:
'
Pipeline deployments limit exceeded!
'
,
project_deleted:
'The
associated project was deleted
'
,
user_blocked:
'The user who created this pipeline is blocked'
}
{
unknown_failure:
'
The reason for the pipeline failure is unknown.
'
,
config_error:
'
The pipeline failed due to an error on the CI/CD configuration file.
'
,
external_validation_failure:
'
The external pipeline validation failed.
'
,
activity_limit_exceeded:
'
The pipeline activity limit was exceeded.
'
,
size_limit_exceeded:
'
The pipeline size limit was exceeded.
'
,
job_activity_limit_exceeded:
'
The pipeline job activity limit was exceeded.
'
,
deployments_limit_exceeded:
'
The pipeline deployments limit was exceeded.
'
,
project_deleted:
'The
project associated with this pipeline was deleted.
'
,
user_blocked:
'The user who created this pipeline is blocked
.
'
}
end
presents
:pipeline
...
...
changelogs/unreleased/tw-ui-text-active-voice-pipeline-presenter.yml
0 → 100644
View file @
cbbb6739
---
title
:
Review UI text for pipeline error messages
merge_request
:
60018
author
:
type
:
other
ee/spec/presenters/ci/pipeline_presenter_spec.rb
View file @
cbbb6739
...
...
@@ -14,7 +14,7 @@ RSpec.describe Ci::PipelinePresenter do
pipeline
.
failure_reason
=
:activity_limit_exceeded
expect
(
presenter
.
failure_reason
)
.
to
eq
'
Pipeline activity limit exceeded!
'
.
to
eq
'
The pipeline activity limit was exceeded.
'
end
end
...
...
spec/serializers/ci/pipeline_entity_spec.rb
View file @
cbbb6739
...
...
@@ -155,7 +155,7 @@ RSpec.describe Ci::PipelineEntity do
it
'has a correct failure reason'
do
expect
(
subject
[
:failure_reason
])
.
to
eq
'
CI/CD YAML configuration error!
'
.
to
eq
'
The pipeline failed due to an error on the CI/CD configuration file.
'
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment