Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
cdc1a5bb
Commit
cdc1a5bb
authored
Nov 27, 2019
by
Marcel Amirault
Committed by
Rémy Coutable
Nov 27, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add docs exception to Danger, and fix links to foss
parent
89c3a1c3
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
8 additions
and
5 deletions
+8
-5
danger/changes_size/Dangerfile
danger/changes_size/Dangerfile
+1
-1
danger/database/Dangerfile
danger/database/Dangerfile
+1
-1
danger/roulette/Dangerfile
danger/roulette/Dangerfile
+2
-2
lib/gitlab/danger/helper.rb
lib/gitlab/danger/helper.rb
+4
-1
No files found.
danger/changes_size/Dangerfile
View file @
cdc1a5bb
# FIXME: git.info_for_file raises the following error
# FIXME: git.info_for_file raises the following error
# /usr/local/bundle/gems/git-1.4.0/lib/git/lib.rb:956:in `command': (Danger::DSLError)
# /usr/local/bundle/gems/git-1.4.0/lib/git/lib.rb:956:in `command': (Danger::DSLError)
# [!] Invalid `Dangerfile` file:
# [!] Invalid `Dangerfile` file:
# [!] Invalid `Dangerfile` file: git '--git-dir=/builds/gitlab-org/gitlab
-foss/.git' '--work-tree=/builds/gitlab-org/gitlab-foss
' cat-file '-t' '' 2>&1:fatal: Not a valid object name
# [!] Invalid `Dangerfile` file: git '--git-dir=/builds/gitlab-org/gitlab
/.git' '--work-tree=/builds/gitlab-org/gitlab
' cat-file '-t' '' 2>&1:fatal: Not a valid object name
# This seems to be the same as https://github.com/danger/danger/issues/535.
# This seems to be the same as https://github.com/danger/danger/issues/535.
# locale_files_updated = git.modified_files.select { |path| path.start_with?('locale') }
# locale_files_updated = git.modified_files.select { |path| path.start_with?('locale') }
...
...
danger/database/Dangerfile
View file @
cdc1a5bb
...
@@ -20,7 +20,7 @@ changes are reviewed, take the following steps:
...
@@ -20,7 +20,7 @@ changes are reviewed, take the following steps:
1. Ensure the merge request has ~database and ~"database::review pending" labels.
1. Ensure the merge request has ~database and ~"database::review pending" labels.
If the merge request modifies database files, Danger will do this for you.
If the merge request modifies database files, Danger will do this for you.
1. Use the [Database changes checklist](https://gitlab.com/gitlab-org/gitlab
-foss
/blob/master/.gitlab/merge_request_templates/Database%20changes.md)
1. Use the [Database changes checklist](https://gitlab.com/gitlab-org/gitlab/blob/master/.gitlab/merge_request_templates/Database%20changes.md)
template or add the appropriate items to the MR description.
template or add the appropriate items to the MR description.
1. Assign and mention the database reviewer suggested by Reviewer Roulette.
1. Assign and mention the database reviewer suggested by Reviewer Roulette.
MSG
MSG
...
...
danger/roulette/Dangerfile
View file @
cdc1a5bb
...
@@ -27,7 +27,7 @@ UNKNOWN_FILES_MESSAGE = <<MARKDOWN
...
@@ -27,7 +27,7 @@ UNKNOWN_FILES_MESSAGE = <<MARKDOWN
These files couldn't be categorised, so Danger was unable to suggest a reviewer.
These files couldn't be categorised, so Danger was unable to suggest a reviewer.
Please consider creating a merge request to
Please consider creating a merge request to
[add support](https://gitlab.com/gitlab-org/gitlab
-foss
/blob/master/lib/gitlab/danger/helper.rb)
[add support](https://gitlab.com/gitlab-org/gitlab/blob/master/lib/gitlab/danger/helper.rb)
for them.
for them.
MARKDOWN
MARKDOWN
...
@@ -46,7 +46,7 @@ def spin_for_category(team, project, category, branch_name)
...
@@ -46,7 +46,7 @@ def spin_for_category(team, project, category, branch_name)
end
end
# TODO: take CODEOWNERS into account?
# TODO: take CODEOWNERS into account?
# https://gitlab.com/gitlab-org/gitlab
-foss/issues/5765
3
# https://gitlab.com/gitlab-org/gitlab
/issues/2672
3
# Make traintainers have triple the chance to be picked as a reviewer
# Make traintainers have triple the chance to be picked as a reviewer
reviewer
=
roulette
.
spin_for_person
(
reviewers
+
traintainers
+
traintainers
,
random:
random
)
reviewer
=
roulette
.
spin_for_person
(
reviewers
+
traintainers
+
traintainers
,
random:
random
)
...
...
lib/gitlab/danger/helper.rb
View file @
cdc1a5bb
...
@@ -153,7 +153,10 @@ module Gitlab
...
@@ -153,7 +153,10 @@ module Gitlab
# Fallbacks in case the above patterns miss anything
# Fallbacks in case the above patterns miss anything
%r{
\.
rb
\z
}
=>
:backend
,
%r{
\.
rb
\z
}
=>
:backend
,
%r{
\.
(md|txt)
\z
}
=>
:none
,
# To reinstate roulette for documentation, set to `:docs`.
%r{(
\.
(md|txt)
\z
|
\.
markdownlint
\.
json
)}x
=>
:none
,
# To reinstate roulette for documentation, set to `:docs`.
%r{
\.
js
\z
}
=>
:frontend
%r{
\.
js
\z
}
=>
:frontend
}.
freeze
}.
freeze
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment