Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ce38cb7d
Commit
ce38cb7d
authored
Aug 20, 2020
by
Nicolò Maria Mezzopera
Committed by
Olena Horal-Koretska
Aug 20, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update tag order in package title
- update order - smaller badges - update tests
parent
b51b1083
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
32 additions
and
24 deletions
+32
-24
app/assets/javascripts/packages/details/components/package_title.vue
...javascripts/packages/details/components/package_title.vue
+5
-5
app/assets/javascripts/packages/shared/components/package_tags.vue
...s/javascripts/packages/shared/components/package_tags.vue
+2
-0
changelogs/unreleased/225656-package-detail-view-update-the-order-of-the-header-metadata-to-imp.yml
...l-view-update-the-order-of-the-header-metadata-to-imp.yml
+5
-0
spec/frontend/packages/details/components/__snapshots__/package_title_spec.js.snap
...tails/components/__snapshots__/package_title_spec.js.snap
+20
-19
No files found.
app/assets/javascripts/packages/details/components/package_title.vue
View file @
ce38cb7d
...
...
@@ -74,8 +74,9 @@ export default {
<span
data-testid=
"package-type"
class=
"gl-font-weight-bold"
>
{{ packageTypeDisplay }}
</span>
</div>
<div
v-if=
"hasTagsToDisplay"
class=
"gl-display-flex gl-align-items-center gl-mr-5"
>
<package-tags
:tag-display-limit=
"1"
:tags=
"packageEntity.tags"
/>
<div
class=
"gl-display-flex gl-align-items-center gl-mr-5"
>
<gl-icon
name=
"disk"
class=
"gl-text-gray-500 gl-mr-3"
/>
<span
data-testid=
"package-size"
class=
"gl-font-weight-bold"
>
{{ totalSize }}
</span>
</div>
<div
v-if=
"packagePipeline"
class=
"gl-display-flex gl-align-items-center gl-mr-5"
>
...
...
@@ -103,9 +104,8 @@ export default {
>
</div>
<div
class=
"gl-display-flex gl-align-items-center gl-mr-5"
>
<gl-icon
name=
"disk"
class=
"gl-text-gray-500 gl-mr-3"
/>
<span
data-testid=
"package-size"
class=
"gl-font-weight-bold"
>
{{ totalSize }}
</span>
<div
v-if=
"hasTagsToDisplay"
class=
"gl-display-flex gl-align-items-center gl-mr-5"
>
<package-tags
:tag-display-limit=
"2"
:tags=
"packageEntity.tags"
hide-label
/>
</div>
</div>
</div>
...
...
app/assets/javascripts/packages/shared/components/package_tags.vue
View file @
ce38cb7d
...
...
@@ -80,6 +80,7 @@ export default {
data-testid=
"tagBadge"
:class=
"tagBadgeClass(index)"
variant=
"info"
size=
"sm"
>
{{
tag
.
name
}}
</gl-badge
>
...
...
@@ -89,6 +90,7 @@ export default {
data-testid=
"moreBadge"
variant=
"muted"
:title=
"moreTagsTooltip"
size=
"sm"
class=
"gl-display-none d-md-flex gl-ml-2"
><gl-sprintf
:message=
"__('+%
{tags} more')">
<template
#tags
>
...
...
changelogs/unreleased/225656-package-detail-view-update-the-order-of-the-header-metadata-to-imp.yml
0 → 100644
View file @
ce38cb7d
---
title
:
Update order of the Header Metadata in Package details
merge_request
:
39585
author
:
type
:
changed
spec/frontend/packages/details/components/__snapshots__/package_title_spec.js.snap
View file @
ce38cb7d
...
...
@@ -56,19 +56,6 @@ exports[`PackageTitle renders with tags 1`] = `
</span>
</div>
<div
class="gl-display-flex gl-align-items-center gl-mr-5"
>
<package-tags-stub
tagdisplaylimit="1"
tags="[object Object],[object Object],[object Object],[object Object]"
/>
</div>
<!---->
<!---->
<div
class="gl-display-flex gl-align-items-center gl-mr-5"
>
...
...
@@ -85,6 +72,20 @@ exports[`PackageTitle renders with tags 1`] = `
300 bytes
</span>
</div>
<!---->
<!---->
<div
class="gl-display-flex gl-align-items-center gl-mr-5"
>
<package-tags-stub
hidelabel="true"
tagdisplaylimit="2"
tags="[object Object],[object Object],[object Object],[object Object]"
/>
</div>
</div>
</div>
`;
...
...
@@ -145,12 +146,6 @@ exports[`PackageTitle renders without tags 1`] = `
</span>
</div>
<!---->
<!---->
<!---->
<div
class="gl-display-flex gl-align-items-center gl-mr-5"
>
...
...
@@ -167,6 +162,12 @@ exports[`PackageTitle renders without tags 1`] = `
300 bytes
</span>
</div>
<!---->
<!---->
<!---->
</div>
</div>
`;
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment