Commit cef08034 authored by Sanad Liaquat's avatar Sanad Liaquat

Merge branch 'qa-shl-fix-jenkins-spec' into 'master'

Fix flaky Jenkins e2e spec javascript error

See merge request gitlab-org/gitlab!29494
parents da18bd2f f7161ddb
......@@ -26,11 +26,7 @@ module QA
setup_jenkins
end
quarantine = {
type: :flaky,
issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/213953'
}
it 'integrates and displays build status for MR pipeline in GitLab', quarantine: quarantine do
it 'integrates and displays build status for MR pipeline in GitLab' do
login_to_gitlab
setup_project_integration_with_jenkins
......
......@@ -14,8 +14,13 @@ module QA
end
def has_successful_build?
# Retry on errors such as:
# Selenium::WebDriver::Error::JavascriptError:
# javascript error: this.each is not a function
Support::Retrier.retry_on_exception(reload_page: page) do
page.has_text?('Finished: SUCCESS')
end
end
def no_failed_status_update?
page.has_no_text?('Failed to update Gitlab commit status')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment