Merge branch '225189-replace-fa-times-circle-icon-with-gitlab-svg-clear-icon' into 'master'

Replace fa-times-circle icon with GitLab SVG clear icon

Closes #225189

See merge request gitlab-org/gitlab!38409

app/assets/stylesheets/fontawesome_custom.scss

@@ -311,10 +311,6 @@
   content: '\f1b3';
 }
 
-.fa-times-circle::before {
-  content: '\f057';
-}
-
 .fa-skype::before {
   content: '\f17e';
 }

app/assets/stylesheets/pages/search.scss

@@ -249,7 +249,7 @@ input[type='checkbox']:hover {
 .search-clear {
   position: absolute;
   right: 10px;
-  top: 10px;
+  top: 9px;
   padding: 0;
   color: $gray-darkest;
   line-height: 0;

app/views/search/_form.html.haml

@@ -11,7 +11,7 @@
         = search_field_tag :search, params[:search], placeholder: _("Search for projects, issues, etc."), class: "form-control search-text-input js-search-input", id: "dashboard_search", autofocus: true, spellcheck: false
         = icon("search", class: "search-icon")
         %button.search-clear.js-search-clear{ class: ("hidden" if !params[:search].present?), type: "button", tabindex: "-1" }
-          = icon("times-circle")
+          = sprite_icon('clear', size: 16)
           %span.sr-only
             = _("Clear search")
     - unless params[:snippets].eql? 'true'

changelogs/unreleased/nicolasdular-replace-fa-times.yml

+---
+title: Replace times-circle with GitLab SVG clear icon
+merge_request: 38409
+author:
+type: other