Merge branch 'mrchrisw-remove-ldap-sync-msg' into 'master'

Only show LDAP sync in progress flash banner on first login

See merge request !2322

app/controllers/omniauth_callbacks_controller.rb

@@ -35,8 +35,8 @@ class OmniauthCallbacksController < Devise::OmniauthCallbacksController
         prompt_for_two_factor(@user)
       else
         log_audit_event(@user, with: :ldap)
-        flash[:notice] = 'LDAP sync in progress. This could take a few minutes. '\
-                         'Refresh the page to see the changes.'
+        # The counter only gets incremented in `sign_in_and_redirect`
+        show_ldap_sync_flash if @user.sign_in_count == 0
         sign_in_and_redirect(@user)
       end
     else
@@ -168,4 +168,9 @@ class OmniauthCallbacksController < Devise::OmniauthCallbacksController
     request_params = request.env['omniauth.params']
     (request_params['remember_me'] == '1') if request_params.present?
   end
+
+  def show_ldap_sync_flash
+    flash[:notice] = 'LDAP sync in progress. This could take a few minutes. '\
+                     'Refresh the page to see the changes.'
+  end
 end

changelogs/unreleased-ee/mrchrisw-remove-ldap-sync-msg.yml

+---
+title: Only show the LDAP sync banner on first login
+merge_request:
+author: