Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d19b8937
Commit
d19b8937
authored
Sep 29, 2021
by
ddavison
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add aggregate_failures metadata to best practices
Replace back-to-back header with multiple header and redirect
parent
42d44783
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
31 additions
and
1 deletion
+31
-1
doc/development/testing_guide/end_to_end/best_practices.md
doc/development/testing_guide/end_to_end/best_practices.md
+31
-1
No files found.
doc/development/testing_guide/end_to_end/best_practices.md
View file @
d19b8937
...
...
@@ -245,7 +245,11 @@ end
## Prefer `aggregate_failures` when there are back-to-back expectations
In cases where there must be multiple (back-to-back) expectations within a test case, it is preferable to use
`aggregate_failures`
.
See
[
Prefer aggregate failures when there are multiple expectations
](
#prefer-aggregate_failures-when-there-are-multiple-expectations
)
## Prefer `aggregate_failures` when there are multiple expectations
In cases where there must be multiple expectations within a test case, it is preferable to use
`aggregate_failures`
.
This allows you to group a set of expectations and see all the failures altogether, rather than having the test being aborted on the first failure.
...
...
@@ -270,6 +274,32 @@ Page::Search::Results.perform do |search|
end
```
Attach the
`:aggregate_failures`
metadata to the example if multiple expectations are separated by statements.
```
ruby
#=> Good
it
'searches'
,
:aggregate_failures
do
Page
::
Search
::
Results
.
perform
do
|
search
|
expect
(
search
).
to
have_file_in_project
(
template
[
:file_name
],
project
.
name
)
search
.
switch_to_code
expect
(
search
).
to
have_file_with_content
(
template
[
:file_name
],
content
[
0
..
33
])
end
end
#=> Bad
it
'searches'
do
Page
::
Search
::
Results
.
perform
do
|
search
|
expect
(
search
).
to
have_file_in_project
(
template
[
:file_name
],
project
.
name
)
search
.
switch_to_code
expect
(
search
).
to
have_file_with_content
(
template
[
:file_name
],
content
[
0
..
33
])
end
end
```
## Prefer to split tests across multiple files
Our framework includes a couple of parallelization mechanisms that work by executing spec files in parallel.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment