Merge branch 'weimeng-prevent-approval-group-name-collision' into 'master'

Prevent project's approval rules having same name

See merge request gitlab-org/gitlab-ee!16216

ee/app/models/approval_project_rule.rb

@@ -13,6 +13,8 @@ class ApprovalProjectRule < ApplicationRecord
 
   alias_method :code_owner, :code_owner?
 
+  validates :name, uniqueness: { scope: :project_id }
+
   def source_rule
     nil
   end

ee/changelogs/unreleased/weimeng-prevent-approval-group-name-collision.yml

+---
+title: Prevent project's approval rules having same name
+merge_request: 16216
+author:
+type: fixed

ee/spec/factories/approval_rules.rb

@@ -31,7 +31,7 @@ FactoryBot.define do
 
   factory :approval_project_rule do
     project
-    name ApprovalRuleLike::DEFAULT_NAME
+    sequence(:name) { |n| "#{ApprovalRuleLike::DEFAULT_NAME}-#{n}" }
     rule_type :regular
 
     trait :requires_approval do

ee/spec/models/approval_project_rule_spec.rb

@@ -5,6 +5,10 @@ require 'spec_helper'
 describe ApprovalProjectRule do
   subject { create(:approval_project_rule) }
 
+  describe 'validations' do
+    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:project_id) }
+  end
+
   describe '.regular' do
     it 'returns non-report_approver records' do
       rules = create_list(:approval_project_rule, 2)