Merge branch '326719-switch-bulk-cron-workers-to-replicas' into 'master'

Adds data consistency for Elastic::BulkCronWorker(s) [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!58345

config/feature_flags/development/load_balancing_for_bulk_cron_workers.yml

+---
+name: load_balancing_for_bulk_cron_workers
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/58345
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/326721
+milestone: '13.11'
+type: development
+group: group::global search
+default_enabled: false

ee/app/workers/all_queues.yml

@@ -65,7 +65,7 @@
   :urgency: :throttled
   :resource_boundary: :unknown
   :weight: 1
-  :idempotent: true
+  :idempotent:
   :tags: []
 - :name: cronjob:elastic_index_initial_bulk_cron
   :feature_category: :global_search
@@ -73,7 +73,7 @@
   :urgency: :throttled
   :resource_boundary: :unknown
   :weight: 1
-  :idempotent: true
+  :idempotent:
   :tags: []
 - :name: cronjob:elastic_migration
   :feature_category: :global_search

ee/app/workers/elastic_index_bulk_cron_worker.rb

 # frozen_string_literal: true
 
-class ElasticIndexBulkCronWorker
+class ElasticIndexBulkCronWorker # rubocop:disable Scalability/IdempotentWorker
   include Elastic::BulkCronWorker
 
   feature_category :global_search
-  idempotent!
   urgency :throttled
+  # Even though this worker is idempotent, until https://gitlab.com/gitlab-org/gitlab/-/issues/325291 is done
+  # we can't use it with read-only database replicas
+  data_consistency :delayed, feature_flag: :load_balancing_for_bulk_cron_workers
 
   private
 

ee/app/workers/elastic_index_initial_bulk_cron_worker.rb

 # frozen_string_literal: true
 
-class ElasticIndexInitialBulkCronWorker
+class ElasticIndexInitialBulkCronWorker # rubocop:disable Scalability/IdempotentWorker
   include Elastic::BulkCronWorker
 
   feature_category :global_search
-  idempotent!
   urgency :throttled
+  # Even though this worker is idempotent, until https://gitlab.com/gitlab-org/gitlab/-/issues/325291 is done
+  # we can't use it with read-only database replicas
+  data_consistency :delayed, feature_flag: :load_balancing_for_bulk_cron_workers
 
   private
 

ee/spec/workers/elastic_index_bulk_cron_worker_spec.rb

@@ -47,4 +47,9 @@ RSpec.describe ElasticIndexBulkCronWorker do
       )
     end
   end
+
+  it_behaves_like 'worker with data consistency',
+                  described_class,
+                  feature_flag: :load_balancing_for_bulk_cron_workers,
+                  data_consistency: :delayed
 end