Optimize pipeline entity spec

Make database creation more efficent and
only add setup code where it is needed

spec/serializers/pipeline_entity_spec.rb

@@ -7,18 +7,8 @@ RSpec.describe PipelineEntity do
 
   let_it_be(:project) { create(:project) }
   let_it_be(:user) { create(:user) }
-  let(:request) { double('request') }
-
-  before do
-    stub_not_protect_default_branch
-
-    allow(request).to receive(:current_user).and_return(user)
-    allow(request).to receive(:project).and_return(project)
-  end
-
-  let(:entity) do
-    described_class.represent(pipeline, request: request)
-  end
+  let(:request) { double('request', current_user: user) }
+  let(:entity) { described_class.represent(pipeline, request: request) }
 
   describe '#as_json' do
     subject { entity.as_json }
@@ -54,70 +44,72 @@ RSpec.describe PipelineEntity do
       end
     end
 
-    context 'when pipeline is retryable' do
-      let(:project) { create(:project) }
-
-      let(:pipeline) do
-        create(:ci_pipeline, status: :success, project: project)
-      end
-
+    context 'when default branch not protected' do
       before do
-        create(:ci_build, :failed, pipeline: pipeline)
+        stub_not_protect_default_branch
       end
 
-      it 'does not serialize stage builds' do
-        subject.with_indifferent_access.dig(:details, :stages, 0).tap do |stage|
-          expect(stage).not_to include(:groups, :latest_statuses, :retries)
+      context 'when pipeline is retryable' do
+        let_it_be(:pipeline) do
+          create(:ci_pipeline, status: :success, project: project)
         end
-      end
 
-      context 'user has ability to retry pipeline' do
         before do
-          project.add_developer(user)
-        end
-
-        it 'contains retry path' do
-          expect(subject[:retry_path]).to be_present
+          create(:ci_build, :failed, pipeline: pipeline)
         end
-      end
 
-      context 'user does not have ability to retry pipeline' do
-        it 'does not contain retry path' do
-          expect(subject).not_to have_key(:retry_path)
+        it 'does not serialize stage builds' do
+          subject.with_indifferent_access.dig(:details, :stages, 0).tap do |stage|
+            expect(stage).not_to include(:groups, :latest_statuses, :retries)
+          end
         end
-      end
-    end
 
-    context 'when pipeline is cancelable' do
-      let(:project) { create(:project) }
+        context 'user has ability to retry pipeline' do
+          before do
+            project.add_developer(user)
+          end
 
-      let(:pipeline) do
-        create(:ci_pipeline, status: :running, project: project)
-      end
+          it 'contains retry path' do
+            expect(subject[:retry_path]).to be_present
+          end
+        end
 
-      before do
-        create(:ci_build, :pending, pipeline: pipeline)
+        context 'user does not have ability to retry pipeline' do
+          it 'does not contain retry path' do
+            expect(subject).not_to have_key(:retry_path)
+          end
+        end
       end
 
-      it 'does not serialize stage builds' do
-        subject.with_indifferent_access.dig(:details, :stages, 0).tap do |stage|
-          expect(stage).not_to include(:groups, :latest_statuses, :retries)
+      context 'when pipeline is cancelable' do
+        let_it_be(:pipeline) do
+          create(:ci_pipeline, status: :running, project: project)
         end
-      end
 
-      context 'user has ability to cancel pipeline' do
         before do
-          project.add_developer(user)
+          create(:ci_build, :pending, pipeline: pipeline)
         end
 
-        it 'contains cancel path' do
-          expect(subject[:cancel_path]).to be_present
+        it 'does not serialize stage builds' do
+          subject.with_indifferent_access.dig(:details, :stages, 0).tap do |stage|
+            expect(stage).not_to include(:groups, :latest_statuses, :retries)
+          end
         end
-      end
 
-      context 'user does not have ability to cancel pipeline' do
-        it 'does not contain cancel path' do
-          expect(subject).not_to have_key(:cancel_path)
+        context 'user has ability to cancel pipeline' do
+          before do
+            project.add_developer(user)
+          end
+
+          it 'contains cancel path' do
+            expect(subject[:cancel_path]).to be_present
+          end
+        end
+
+        context 'user does not have ability to cancel pipeline' do
+          it 'does not contain cancel path' do
+            expect(subject).not_to have_key(:cancel_path)
+          end
         end
       end
     end
@@ -133,7 +125,6 @@ RSpec.describe PipelineEntity do
       end
 
       context 'user does not have ability to delete pipeline' do
-        let(:project) { create(:project) }
         let(:pipeline) { create(:ci_pipeline, project: project) }
 
         it 'does not contain delete path' do
@@ -167,79 +158,85 @@ RSpec.describe PipelineEntity do
       end
     end
 
-    context 'when pipeline is detached merge request pipeline' do
-      let(:merge_request) { create(:merge_request, :with_detached_merge_request_pipeline) }
-      let(:project) { merge_request.target_project }
-      let(:pipeline) { merge_request.pipelines_for_merge_request.first }
-
-      it 'makes detached flag true' do
-        expect(subject[:flags][:detached_merge_request_pipeline]).to be_truthy
+    context 'when request has a project' do
+      before do
+        allow(request).to receive(:project).and_return(project)
       end
 
-      it 'does not expose source sha and target sha' do
-        expect(subject[:source_sha]).to be_nil
-        expect(subject[:target_sha]).to be_nil
-      end
+      context 'when pipeline is detached merge request pipeline' do
+        let_it_be(:merge_request) { create(:merge_request, :with_detached_merge_request_pipeline) }
+        let(:project) { merge_request.target_project }
+        let(:pipeline) { merge_request.pipelines_for_merge_request.first }
 
-      context 'when user is a developer' do
-        before do
-          project.add_developer(user)
+        it 'makes detached flag true' do
+          expect(subject[:flags][:detached_merge_request_pipeline]).to be_truthy
         end
 
-        it 'has merge request information' do
-          expect(subject[:merge_request][:iid]).to eq(merge_request.iid)
+        it 'does not expose source sha and target sha' do
+          expect(subject[:source_sha]).to be_nil
+          expect(subject[:target_sha]).to be_nil
+        end
+
+        context 'when user is a developer' do
+          before do
+            project.add_developer(user)
+          end
+
+          it 'has merge request information' do
+            expect(subject[:merge_request][:iid]).to eq(merge_request.iid)
 
-          expect(project_merge_request_path(project, merge_request))
-            .to include(subject[:merge_request][:path])
+            expect(project_merge_request_path(project, merge_request))
+              .to include(subject[:merge_request][:path])
 
-          expect(subject[:merge_request][:title]).to eq(merge_request.title)
+            expect(subject[:merge_request][:title]).to eq(merge_request.title)
 
-          expect(subject[:merge_request][:source_branch])
-            .to eq(merge_request.source_branch)
+            expect(subject[:merge_request][:source_branch])
+              .to eq(merge_request.source_branch)
 
-          expect(project_commits_path(project, merge_request.source_branch))
-            .to include(subject[:merge_request][:source_branch_path])
+            expect(project_commits_path(project, merge_request.source_branch))
+              .to include(subject[:merge_request][:source_branch_path])
 
-          expect(subject[:merge_request][:target_branch])
-            .to eq(merge_request.target_branch)
+            expect(subject[:merge_request][:target_branch])
+              .to eq(merge_request.target_branch)
 
-          expect(project_commits_path(project, merge_request.target_branch))
-            .to include(subject[:merge_request][:target_branch_path])
+            expect(project_commits_path(project, merge_request.target_branch))
+              .to include(subject[:merge_request][:target_branch_path])
+          end
         end
-      end
 
-      context 'when user is an external user' do
-        it 'has no merge request information' do
-          expect(subject[:merge_request]).to be_nil
+        context 'when user is an external user' do
+          it 'has no merge request information' do
+            expect(subject[:merge_request]).to be_nil
+          end
         end
       end
-    end
 
-    context 'when pipeline is merge request pipeline' do
-      let(:merge_request) { create(:merge_request, :with_merge_request_pipeline, merge_sha: 'abc') }
-      let(:project) { merge_request.target_project }
-      let(:pipeline) { merge_request.pipelines_for_merge_request.first }
+      context 'when pipeline is merge request pipeline' do
+        let_it_be(:merge_request) { create(:merge_request, :with_merge_request_pipeline, merge_sha: 'abc') }
+        let(:project) { merge_request.target_project }
+        let(:pipeline) { merge_request.pipelines_for_merge_request.first }
 
-      it 'makes detached flag false' do
-        expect(subject[:flags][:detached_merge_request_pipeline]).to be_falsy
-      end
+        it 'makes detached flag false' do
+          expect(subject[:flags][:detached_merge_request_pipeline]).to be_falsy
+        end
 
-      it 'makes atached flag true' do
-        expect(subject[:flags][:merge_request_pipeline]).to be_truthy
-      end
+        it 'makes atached flag true' do
+          expect(subject[:flags][:merge_request_pipeline]).to be_truthy
+        end
 
-      it 'exposes source sha and target sha' do
-        expect(subject[:source_sha]).to be_present
-        expect(subject[:target_sha]).to be_present
-      end
+        it 'exposes source sha and target sha' do
+          expect(subject[:source_sha]).to be_present
+          expect(subject[:target_sha]).to be_present
+        end
 
-      it 'exposes merge request event type' do
-        expect(subject[:merge_request_event_type]).to be_present
+        it 'exposes merge request event type' do
+          expect(subject[:merge_request_event_type]).to be_present
+        end
       end
     end
 
     context 'when pipeline has failed builds' do
-      let_it_be(:pipeline) { create(:ci_pipeline, project: project, user: user) }
+      let_it_be(:pipeline) { create(:ci_pipeline, user: user) }
       let_it_be(:build) { create(:ci_build, :success, pipeline: pipeline) }
       let_it_be(:failed_1) { create(:ci_build, :failed, pipeline: pipeline) }
       let_it_be(:failed_2) { create(:ci_build, :failed, pipeline: pipeline) }