Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d66b1249
Commit
d66b1249
authored
May 12, 2020
by
Arturo Herrero
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove unnecessary limit using exists?
limit is not necessary because exists? always adds limit(1).
parent
ddd41c03
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
1 deletion
+1
-1
app/models/plan_limits.rb
app/models/plan_limits.rb
+1
-1
No files found.
app/models/plan_limits.rb
View file @
d66b1249
...
@@ -11,7 +11,7 @@ class PlanLimits < ApplicationRecord
...
@@ -11,7 +11,7 @@ class PlanLimits < ApplicationRecord
else
else
# object.count >= limit value is slower than checking
# object.count >= limit value is slower than checking
# if a record exists at the limit value - 1 position.
# if a record exists at the limit value - 1 position.
object
.
limit
(
1
).
offset
(
read_attribute
(
limit_name
)
-
1
).
exists?
object
.
offset
(
read_attribute
(
limit_name
)
-
1
).
exists?
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment