Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
dab1afd0
Commit
dab1afd0
authored
Sep 16, 2020
by
Nicolas Dular
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove successful signup flash message
parent
37c013d3
Changes
6
Show whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
7 additions
and
11 deletions
+7
-11
app/controllers/registrations/experience_levels_controller.rb
...controllers/registrations/experience_levels_controller.rb
+0
-1
app/controllers/registrations_controller.rb
app/controllers/registrations_controller.rb
+1
-2
changelogs/unreleased/nicolasdular-remove-successful-signup-notice.yml
...released/nicolasdular-remove-successful-signup-notice.yml
+5
-0
spec/controllers/registrations/experience_levels_controller_spec.rb
...ollers/registrations/experience_levels_controller_spec.rb
+0
-2
spec/controllers/registrations_controller_spec.rb
spec/controllers/registrations_controller_spec.rb
+1
-5
spec/features/users/signup_spec.rb
spec/features/users/signup_spec.rb
+0
-1
No files found.
app/controllers/registrations/experience_levels_controller.rb
View file @
dab1afd0
...
...
@@ -12,7 +12,6 @@ module Registrations
if
current_user
.
save
hide_advanced_issues
flash
[
:message
]
=
I18n
.
t
(
'devise.registrations.signed_up'
)
redirect_to
group_path
(
params
[
:namespace_path
])
else
render
:show
...
...
app/controllers/registrations_controller.rb
View file @
dab1afd0
...
...
@@ -36,7 +36,7 @@ class RegistrationsController < Devise::RegistrationsController
end
# Devise sets a flash message on `create` for a successful signup,
# w
e want to show this message after the welcome page
.
# w
hich we don't want to show
.
flash
[
:notice
]
=
nil
rescue
Gitlab
::
Access
::
AccessDeniedError
redirect_to
(
new_user_session_path
)
...
...
@@ -69,7 +69,6 @@ class RegistrationsController < Devise::RegistrationsController
return
redirect_to
new_users_sign_up_group_path
if
experiment_enabled?
(
:onboarding_issues
)
&&
show_onboarding_issues_experiment?
set_flash_message!
:notice
,
:signed_up
redirect_to
path_for_signed_in_user
(
current_user
)
else
render
:welcome
...
...
changelogs/unreleased/nicolasdular-remove-successful-signup-notice.yml
0 → 100644
View file @
dab1afd0
---
title
:
Remove successful signup flash message
merge_request
:
42512
author
:
type
:
changed
spec/controllers/registrations/experience_levels_controller_spec.rb
View file @
dab1afd0
...
...
@@ -59,8 +59,6 @@ RSpec.describe Registrations::ExperienceLevelsController do
end
context
'when user is successfully updated'
do
it
{
is_expected
.
to
set_flash
[
:message
].
to
(
'Welcome! You have signed up successfully.'
)
}
context
'when no experience_level is sent'
do
before
do
user
.
user_preference
.
update_attribute
(
:experience_level
,
:novice
)
...
...
spec/controllers/registrations_controller_spec.rb
View file @
dab1afd0
...
...
@@ -493,10 +493,6 @@ RSpec.describe RegistrationsController do
sign_in
(
create
(
:user
))
end
it
'sets flash message'
do
subject
expect
(
flash
[
:notice
]).
to
eq
(
I18n
.
t
(
'devise.registrations.signed_up'
))
end
it
{
is_expected
.
to
redirect_to
(
dashboard_projects_path
)}
end
end
spec/features/users/signup_spec.rb
View file @
dab1afd0
...
...
@@ -419,7 +419,6 @@ RSpec.shared_examples 'Signup' do
expect
(
new_user
.
software_developer_role?
).
to
be_truthy
expect
(
new_user
.
setup_for_company
).
to
be_nil
expect
(
page
).
to
have_current_path
(
new_project_path
)
expect
(
page
).
to
have_content
(
"Welcome! You have signed up successfully."
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment