Move the check if group is synced with ldap to a method.

app/models/group.rb

@@ -90,6 +90,10 @@ class Group < Namespace
     ldap_group_links.first.try(:group_access)
   end
 
+  def ldap_synced?
+    ldap_cn.present?
+  end
+
   class << self
     def search(query)
       where("LOWER(namespaces.name) LIKE :query", query: "%#{query.downcase}%")

app/views/admin/groups/show.html.haml

@@ -87,7 +87,7 @@
 
         = form_tag project_teams_update_admin_group_path(@group), id: "new_team_member", class: "bulk_import", method: :put  do
           %div
-            = users_select_tag(:user_ids, { multiple: true, skip_ldap: @group.ldap_cn.present? })
+            = users_select_tag(:user_ids, { multiple: true, skip_ldap: @group.ldap_synced? })
           %div.prepend-top-10
             = select_tag :group_access, options_for_select(UsersGroup.group_access_roles), class: "project-access-select select2"
           %hr

app/views/groups/_new_group_member.html.haml

 = form_for @users_group, url: group_users_groups_path(@group), html: { class: 'form-horizontal users-group-form' } do |f|
   .form-group
     = f.label :user_ids, "People", class: 'control-label'
-    .col-sm-10= users_select_tag(:user_ids, { multiple: true, skip_ldap: @group.ldap_cn.present? , class: 'input-large' })
+    .col-sm-10= users_select_tag(:user_ids, { multiple: true, skip_ldap: @group.ldap_synced? , class: 'input-large' })
 
   .form-group
     = f.label :group_access, "Group Access", class: 'control-label'

app/views/projects/team_members/_form.html.haml

@@ -12,7 +12,7 @@
   .form-group
     = f.label :user_ids, "People", class: 'control-label'
     .col-sm-10
-      = users_select_tag(:user_ids, { multiple: true, skip_ldap: @project.group.ldap_cn.present? })
+      = users_select_tag(:user_ids, { multiple: true, skip_ldap: @project.group.ldap_synced? })
 
   %p 2. Set access level for them
   .form-group