Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
db9f61c7
Commit
db9f61c7
authored
Nov 13, 2020
by
Vladimir Shushlin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove zip_pages_deployment feature flag
parent
2cfc665e
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
0 additions
and
20 deletions
+0
-20
app/services/projects/update_pages_service.rb
app/services/projects/update_pages_service.rb
+0
-2
config/feature_flags/development/zip_pages_deployments.yml
config/feature_flags/development/zip_pages_deployments.yml
+0
-8
spec/services/projects/update_pages_service_spec.rb
spec/services/projects/update_pages_service_spec.rb
+0
-10
No files found.
app/services/projects/update_pages_service.rb
View file @
db9f61c7
...
...
@@ -125,8 +125,6 @@ module Projects
end
def
create_pages_deployment
(
artifacts_path
,
build
)
return
unless
Feature
.
enabled?
(
:zip_pages_deployments
,
project
,
default_enabled:
true
)
# we're using the full archive and pages daemon needs to read it
# so we want the total count from entries, not only "public/" directory
# because it better approximates work we need to do before we can serve the site
...
...
config/feature_flags/development/zip_pages_deployments.yml
deleted
100644 → 0
View file @
2cfc665e
---
name
:
zip_pages_deployments
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/42834
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/245308
milestone
:
'
13.5'
type
:
development
group
:
group::release management
default_enabled
:
true
spec/services/projects/update_pages_service_spec.rb
View file @
db9f61c7
...
...
@@ -105,16 +105,6 @@ RSpec.describe Projects::UpdatePagesService do
end
end
it
'does not create deployment when zip_pages_deployments feature flag is disabled'
do
stub_feature_flags
(
zip_pages_deployments:
false
)
expect
do
expect
(
execute
).
to
eq
(
:success
)
end
.
not_to
change
{
project
.
pages_deployments
.
count
}
expect
(
project
.
pages_metadatum
.
reload
.
pages_deployment_id
).
to
be_nil
end
it
'limits pages size'
do
stub_application_setting
(
max_pages_size:
1
)
expect
(
execute
).
not_to
eq
(
:success
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment