Extract hash to map to legacy values

ee/app/models/software_license_policy.rb

@@ -5,6 +5,9 @@
 # For use in the License Management feature.
 class SoftwareLicensePolicy < ApplicationRecord
   include Presentable
+  APPROVAL_STATUS = {
+    'blacklisted' => 'denied'
+  }.freeze
 
   # Only allows modification of the approval status
   FORM_EDITABLE = %i[approval_status].freeze

ee/app/services/software_license_policies/create_service.rb

@@ -21,22 +21,15 @@ module SoftwareLicensePolicies
     private
 
     def create_software_license_policy
+      approval_status = params[:approval_status]
+      classification = SoftwareLicensePolicy::APPROVAL_STATUS.fetch(approval_status, approval_status)
       policy = SoftwareLicense.create_policy_for!(
         project: project,
         name: params[:name],
-        classification: map_from(params[:approval_status])
+        classification: classification
       )
       RefreshLicenseComplianceChecksWorker.perform_async(project.id)
       policy
     end
-
-    def map_from(approval_status)
-      case approval_status
-      when 'blacklisted'
-        'denied'
-      else
-        approval_status
-      end
-    end
   end
 end

ee/app/services/software_license_policies/update_service.rb

@@ -12,7 +12,9 @@ module SoftwareLicensePolicies
       return success(software_license_policy: software_license_policy) unless params[:approval_status].present?
 
       begin
-        software_license_policy.update(classification: map_from(params[:approval_status]))
+        approval_status = params[:approval_status]
+        classification = SoftwareLicensePolicy::APPROVAL_STATUS.fetch(approval_status, approval_status)
+        software_license_policy.update(classification: classification)
         RefreshLicenseComplianceChecksWorker.perform_async(project.id)
       rescue ArgumentError => ex
         return error(ex.message, 400)
@@ -20,16 +22,5 @@ module SoftwareLicensePolicies
 
       success(software_license_policy: software_license_policy)
     end
-
-    private
-
-    def map_from(approval_status)
-      case approval_status
-      when 'blacklisted'
-        'denied'
-      else
-        approval_status
-      end
-    end
   end
 end