Commit e070e216 authored by Bob Van Landuyt's avatar Bob Van Landuyt

Update failure message when finding new routes in `PathRegex`

parent 58d1d6a5
...@@ -45,21 +45,16 @@ describe Gitlab::PathRegex do ...@@ -45,21 +45,16 @@ describe Gitlab::PathRegex do
Found new routes that could cause conflicts with existing namespaced routes Found new routes that could cause conflicts with existing namespaced routes
for groups or projects. for groups or projects.
Add <#{missing_words.join(', ')}> to `Gitlab::PathRegex::#{constant_name} Nest <#{missing_words.join(', ')}> in a route containing `-`, that way
to make sure no projects or namespaces can be created with those paths. we know there will be no conflicts with groups or projects created with those
paths.
To rename any existing records with those paths you can use the
`Gitlab::Database::RenameReservedpathsMigration::<VERSION>.#{migration_helper}`
migration helper.
Make sure to make a note of the renamed records in the release blog post.
MISSING MISSING
end end
if additional_words.any? if additional_words.any?
message += <<-ADDITIONAL message += <<-ADDITIONAL
Why are <#{additional_words.join(', ')}> in `#{constant_name}`? Is <#{additional_words.join(', ')}> in `#{constant_name}` required?
If they are really required, update these specs to reflect that. If they are really required, update these specs to reflect that.
ADDITIONAL ADDITIONAL
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment