Merge branch 'master' into i-#25814-500-error

.rubocop.yml

@@ -343,10 +343,6 @@ Style/ParenthesesAroundCondition:
 Style/RedundantParentheses:
   Enabled: true
 
-# Don't use return where it's not required.
-Style/RedundantReturn:
-  Enabled: true
-
 # Don't use semicolons to terminate expressions.
 Style/Semicolon:
   Enabled: true

.rubocop_todo.yml

 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2017-01-05 14:31:09 -0800 using RuboCop version 0.46.0.
+# `rubocop --auto-gen-config --exclude-limit 0`
+# on 2017-01-11 09:38:25 +0000 using RuboCop version 0.46.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 28
+# Offense count: 27
 # Configuration parameters: Include.
 # Include: **/Gemfile, **/gems.rb
 Bundler/OrderedGems:
-  Exclude:
-    - 'Gemfile'
+  Enabled: false
 
-# Offense count: 174
+# Offense count: 175
 Lint/AmbiguousRegexpLiteral:
   Enabled: false
 
@@ -24,8 +23,7 @@ Lint/AssignmentInCondition:
 
 # Offense count: 1
 Lint/EmptyWhen:
-  Exclude:
-    - 'lib/gitlab/diff/parser.rb'
+  Enabled: false
 
 # Offense count: 20
 Lint/HandleExceptions:
@@ -33,37 +31,21 @@ Lint/HandleExceptions:
 
 # Offense count: 1
 Lint/Loop:
-  Exclude:
-    - 'app/mailers/notify.rb'
+  Enabled: false
 
-# Offense count: 28
+# Offense count: 27
 Lint/ShadowingOuterLocalVariable:
   Enabled: false
 
 # Offense count: 10
 # Cop supports --auto-correct.
 Lint/UnifiedInteger:
-  Exclude:
-    - 'spec/lib/gitlab/metrics/method_call_spec.rb'
-    - 'spec/lib/gitlab/metrics/metric_spec.rb'
-    - 'spec/lib/gitlab/metrics/system_spec.rb'
-    - 'spec/lib/gitlab/metrics/transaction_spec.rb'
-    - 'spec/models/repository_spec.rb'
+  Enabled: false
 
 # Offense count: 21
 # Cop supports --auto-correct.
 Lint/UnneededSplatExpansion:
-  Exclude:
-    - 'config/application.rb'
-    - 'lib/banzai/filter/gollum_tags_filter.rb'
-    - 'lib/bitbucket/page.rb'
-    - 'lib/gitlab/markup_helper.rb'
-    - 'spec/helpers/auth_helper_spec.rb'
-    - 'spec/models/project_wiki_spec.rb'
-    - 'spec/requests/api/projects_spec.rb'
-    - 'spec/requests/api/tags_spec.rb'
-    - 'spec/support/seed_helper.rb'
-    - 'spec/support/test_env.rb'
+  Enabled: false
 
 # Offense count: 82
 # Cop supports --auto-correct.
@@ -77,28 +59,20 @@ Lint/UnusedBlockArgument:
 Lint/UnusedMethodArgument:
   Enabled: false
 
-# Offense count: 94
+# Offense count: 93
 # Configuration parameters: CountComments.
 Metrics/BlockLength:
-  Max: 289
+  Max: 288
 
 # Offense count: 3
 # Cop supports --auto-correct.
 Performance/RedundantBlockCall:
-  Exclude:
-    - 'app/controllers/application_controller.rb'
-    - 'lib/gitlab/backend/shell.rb'
-    - 'lib/gitlab/optimistic_locking.rb'
+  Enabled: false
 
 # Offense count: 5
 # Cop supports --auto-correct.
 Performance/RedundantMatch:
-  Exclude:
-    - 'app/models/external_issue.rb'
-    - 'lib/ci/api/helpers.rb'
-    - 'lib/extracts_path.rb'
-    - 'lib/gitlab/diff/highlight.rb'
-    - 'lib/gitlab/diff/parser.rb'
+  Enabled: false
 
 # Offense count: 32
 # Cop supports --auto-correct.
@@ -108,26 +82,16 @@ Performance/RedundantMerge:
 
 # Offense count: 7
 RSpec/BeEql:
-  Exclude:
-    - 'spec/lib/gitlab/ldap/user_spec.rb'
-    - 'spec/lib/gitlab/o_auth/user_spec.rb'
-    - 'spec/lib/gitlab/saml/user_spec.rb'
+  Enabled: false
 
 # Offense count: 15
 # Configuration parameters: CustomIncludeMethods.
 RSpec/EmptyExampleGroup:
-  Exclude:
-    - 'spec/features/issues_spec.rb'
-    - 'spec/features/notes_on_merge_requests_spec.rb'
-    - 'spec/lib/gitlab/git_access_spec.rb'
-    - 'spec/models/project_snippet_spec.rb'
-    - 'spec/models/protected_branch_spec.rb'
-    - 'spec/routing/routing_spec.rb'
+  Enabled: false
 
 # Offense count: 24
 RSpec/ExpectActual:
-  Exclude:
-    - 'spec/lib/gitlab/regex_spec.rb'
+  Enabled: false
 
 # Offense count: 58
 # Configuration parameters: EnforcedStyle, SupportedStyles.
@@ -139,74 +103,48 @@ RSpec/HookArgument:
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: is_expected, should
 RSpec/ImplicitExpect:
-  Exclude:
-    - 'spec/lib/banzai/renderer_spec.rb'
-    - 'spec/models/project_group_link_spec.rb'
-    - 'spec/models/project_services/external_wiki_service_spec.rb'
-    - 'spec/models/project_spec.rb'
+  Enabled: false
 
-# Offense count: 235
+# Offense count: 237
 RSpec/LeadingSubject:
   Enabled: false
 
-# Offense count: 246
+# Offense count: 253
 RSpec/LetSetup:
   Enabled: false
 
 # Offense count: 13
 RSpec/MessageChain:
-  Exclude:
-    - 'spec/finders/move_to_project_finder_spec.rb'
-    - 'spec/helpers/issues_helper_spec.rb'
-    - 'spec/initializers/secret_token_spec.rb'
-    - 'spec/models/build_spec.rb'
-    - 'spec/requests/api/internal_spec.rb'
-    - 'spec/services/merge_requests/build_service_spec.rb'
-    - 'spec/services/notes/create_service_spec.rb'
-    - 'spec/workers/emails_on_push_worker_spec.rb'
-
-# Offense count: 468
+  Enabled: false
+
+# Offense count: 479
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
   Enabled: false
 
-# Offense count: 3013
+# Offense count: 3036
 RSpec/MultipleExpectations:
   Max: 37
 
-# Offense count: 2072
+# Offense count: 2133
 RSpec/NamedSubject:
   Enabled: false
 
-# Offense count: 1949
+# Offense count: 1974
 # Configuration parameters: MaxNesting.
 RSpec/NestedGroups:
   Enabled: false
 
 # Offense count: 32
 RSpec/RepeatedDescription:
-  Exclude:
-    - 'spec/controllers/projects/todo_controller_spec.rb'
-    - 'spec/features/boards/boards_spec.rb'
-    - 'spec/helpers/issuables_helper_spec.rb'
-    - 'spec/lib/banzai/filter/emoji_filter_spec.rb'
-    - 'spec/models/commit_range_spec.rb'
-    - 'spec/models/global_milestone_spec.rb'
-    - 'spec/models/hooks/system_hook_spec.rb'
-    - 'spec/requests/api/commits_spec.rb'
-    - 'spec/requests/api/merge_requests_spec.rb'
-    - 'spec/requests/api/users_spec.rb'
-    - 'spec/requests/lfs_http_spec.rb'
-    - 'spec/routing/admin_routing_spec.rb'
-    - 'spec/services/notification_service_spec.rb'
+  Enabled: false
 
 # Offense count: 1
 RSpec/SingleArgumentMessageChain:
-  Exclude:
-    - 'spec/requests/api/internal_spec.rb'
+  Enabled: false
 
-# Offense count: 125
+# Offense count: 133
 RSpec/SubjectStub:
   Enabled: false
 
@@ -217,7 +155,7 @@ RSpec/SubjectStub:
 Rails/DynamicFindBy:
   Enabled: false
 
-# Offense count: 929
+# Offense count: 932
 # Cop supports --auto-correct.
 # Configuration parameters: Include.
 # Include: spec/**/*, test/**/*
@@ -228,7 +166,7 @@ Rails/HttpPositionalArguments:
 Rails/OutputSafety:
   Enabled: false
 
-# Offense count: 181
+# Offense count: 182
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: strict, flexible
 Rails/TimeZone:
@@ -239,31 +177,15 @@ Rails/TimeZone:
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/Validation:
-  Exclude:
-    - 'app/models/ci/build.rb'
-    - 'app/models/ci/pipeline.rb'
-    - 'app/models/ci/runner_project.rb'
-    - 'app/models/ci/trigger.rb'
-    - 'app/models/commit_status.rb'
-    - 'app/models/members/group_member.rb'
-    - 'app/models/members/project_member.rb'
-    - 'app/models/project.rb'
-    - 'app/models/protected_branch.rb'
-    - 'app/models/user.rb'
+  Enabled: false
 
 # Offense count: 8
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect.
 Security/JSONLoad:
-  Exclude:
-    - 'db/migrate/20161019190736_migrate_sidekiq_queues_from_default.rb'
-    - 'db/migrate/20161024042317_migrate_mailroom_queue_from_default.rb'
-    - 'db/migrate/20161124141322_migrate_process_commit_worker_jobs.rb'
-    - 'spec/migrations/migrate_process_commit_worker_jobs_spec.rb'
-    - 'spec/models/project_services/irker_service_spec.rb'
-    - 'spec/support/stub_gitlab_calls.rb'
+  Enabled: false
 
-# Offense count: 339
+# Offense count: 346
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
 # SupportedStyles: with_first_parameter, with_fixed_indentation
@@ -277,14 +199,14 @@ Style/AlignParameters:
 Style/AndOr:
   Enabled: false
 
-# Offense count: 53
+# Offense count: 54
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: percent_q, bare_percent
 Style/BarePercentLiterals:
   Enabled: false
 
-# Offense count: 354
+# Offense count: 358
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: braces, no_braces, context_dependent
@@ -293,13 +215,7 @@ Style/BracesAroundHashParameters:
 
 # Offense count: 6
 Style/CaseEquality:
-  Exclude:
-    - 'app/helpers/auth_helper.rb'
-    - 'app/models/commit.rb'
-    - 'app/models/protected_branch.rb'
-    - 'app/services/projects/download_service.rb'
-    - 'config/initializers/trusted_proxies.rb'
-    - 'spec/features/calendar_spec.rb'
+  Enabled: false
 
 # Offense count: 37
 # Cop supports --auto-correct.
@@ -311,11 +227,7 @@ Style/ColonMethodCall:
 # Configuration parameters: Keywords.
 # Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
 Style/CommentAnnotation:
-  Exclude:
-    - 'config/routes/user.rb'
-    - 'lib/api/commits.rb'
-    - 'lib/api/entities.rb'
-    - 'spec/requests/api/project_snippets_spec.rb'
+  Enabled: false
 
 # Offense count: 29
 # Cop supports --auto-correct.
@@ -333,33 +245,12 @@ Style/DotPosition:
 
 # Offense count: 18
 Style/DoubleNegation:
-  Exclude:
-    - 'app/controllers/users_controller.rb'
-    - 'app/models/commit.rb'
-    - 'app/models/merge_request.rb'
-    - 'app/models/project.rb'
-    - 'app/models/project_services/buildkite_service.rb'
-    - 'app/models/project_services/drone_ci_service.rb'
-    - 'app/models/project_wiki.rb'
-    - 'app/models/user.rb'
-    - 'config/initializers/6_validations.rb'
-    - 'lib/banzai/filter/relative_link_filter.rb'
-    - 'lib/gitlab/git/diff_collection.rb'
-    - 'lib/gitlab/git/repository.rb'
-    - 'lib/gitlab/sherlock.rb'
-    - 'lib/gitlab/sherlock/middleware.rb'
+  Enabled: false
 
 # Offense count: 7
 # Cop supports --auto-correct.
 Style/EachWithObject:
-  Exclude:
-    - 'app/controllers/projects/cycle_analytics_controller.rb'
-    - 'app/services/merge_requests/get_urls_service.rb'
-    - 'lib/ci/ansi2html.rb'
-    - 'lib/expand_variables.rb'
-    - 'lib/gitlab/ee_compat_check.rb'
-    - 'lib/gitlab/import_export/members_mapper.rb'
-    - 'lib/gitlab/import_export/relation_factory.rb'
+  Enabled: false
 
 # Offense count: 24
 # Cop supports --auto-correct.
@@ -371,11 +262,7 @@ Style/EmptyElse:
 # Offense count: 4
 # Cop supports --auto-correct.
 Style/EmptyLiteral:
-  Exclude:
-    - 'features/steps/project/commits/commits.rb'
-    - 'lib/gitlab/fogbugz_import/importer.rb'
-    - 'lib/gitlab/git/diff_collection.rb'
-    - 'spec/lib/gitlab/workhorse_spec.rb'
+  Enabled: false
 
 # Offense count: 57
 # Cop supports --auto-correct.
@@ -384,7 +271,7 @@ Style/EmptyLiteral:
 Style/EmptyMethod:
   Enabled: false
 
-# Offense count: 145
+# Offense count: 147
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
 Style/ExtraSpacing:
@@ -394,33 +281,16 @@ Style/ExtraSpacing:
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: format, sprintf, percent
 Style/FormatString:
-  Exclude:
-    - 'app/models/ci/pipeline.rb'
-    - 'app/services/gravatar_service.rb'
-    - 'config/initializers/rack_lineprof.rb'
-    - 'lib/gitlab/version_info.rb'
-    - 'spec/factories/lfs_objects.rb'
-    - 'spec/services/issues/move_service_spec.rb'
-
-# Offense count: 236
+  Enabled: false
+
+# Offense count: 238
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false
 
 # Offense count: 11
 Style/IfInsideElse:
-  Exclude:
-    - 'app/controllers/projects/forks_controller.rb'
-    - 'app/controllers/projects/imports_controller.rb'
-    - 'app/helpers/milestones_helper.rb'
-    - 'app/helpers/projects_helper.rb'
-    - 'app/services/system_note_service.rb'
-    - 'config/initializers/1_settings.rb'
-    - 'lib/gitlab/auth.rb'
-    - 'lib/gitlab/checks/change_access.rb'
-    - 'lib/gitlab/database.rb'
-    - 'spec/controllers/projects/merge_requests_controller_spec.rb'
-    - 'spec/support/import_export/export_file_helper.rb'
+  Enabled: false
 
 # Offense count: 173
 # Cop supports --auto-correct.
@@ -435,7 +305,7 @@ Style/IfUnlessModifier:
 Style/IndentArray:
   Enabled: false
 
-# Offense count: 99
+# Offense count: 101
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
 # SupportedStyles: special_inside_parentheses, consistent, align_braces
@@ -452,49 +322,23 @@ Style/Lambda:
 # Offense count: 5
 # Cop supports --auto-correct.
 Style/LineEndConcatenation:
-  Exclude:
-    - 'app/helpers/preferences_helper.rb'
-    - 'app/helpers/tree_helper.rb'
-    - 'app/models/merge_request.rb'
-    - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
+  Enabled: false
 
 # Offense count: 19
 # Cop supports --auto-correct.
 Style/MethodCallParentheses:
-  Exclude:
-    - 'lib/ci/ansi2html.rb'
-    - 'spec/controllers/dashboard/todos_controller_spec.rb'
-    - 'spec/controllers/projects/issues_controller_spec.rb'
-    - 'spec/controllers/projects/merge_requests_controller_spec.rb'
-    - 'spec/controllers/projects/snippets_controller_spec.rb'
-    - 'spec/features/calendar_spec.rb'
-    - 'spec/features/dashboard/datetime_on_tooltips_spec.rb'
-    - 'spec/helpers/submodule_helper_spec.rb'
-    - 'spec/lib/gitlab/git/repository_spec.rb'
-    - 'spec/requests/api/internal_spec.rb'
+  Enabled: false
 
 # Offense count: 9
 Style/MethodMissing:
-  Exclude:
-    - 'app/controllers/projects/application_controller.rb'
-    - 'app/models/commit.rb'
-    - 'app/models/network/commit.rb'
-    - 'app/models/repository.rb'
-    - 'config/initializers/gollum.rb'
-    - 'lib/bitbucket/collection.rb'
-    - 'lib/gitlab/github_import/client.rb'
-    - 'lib/gitlab/lazy.rb'
-    - 'lib/uploaded_file.rb'
+  Enabled: false
 
 # Offense count: 3
 # Cop supports --auto-correct.
 Style/MultilineIfModifier:
-  Exclude:
-    - 'app/helpers/snippets_helper.rb'
-    - 'app/models/merge_request.rb'
-    - 'app/models/project_wiki.rb'
+  Enabled: false
 
-# Offense count: 178
+# Offense count: 179
 # Cop supports --auto-correct.
 Style/MutableConstant:
   Enabled: false
@@ -502,49 +346,21 @@ Style/MutableConstant:
 # Offense count: 8
 # Cop supports --auto-correct.
 Style/NestedParenthesizedCalls:
-  Exclude:
-    - 'app/helpers/commits_helper.rb'
-    - 'app/workers/irker_worker.rb'
-    - 'spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb'
-    - 'spec/lib/gitlab/email/message/repository_push_spec.rb'
+  Enabled: false
 
 # Offense count: 13
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
 # SupportedStyles: skip_modifier_ifs, always
 Style/Next:
-  Exclude:
-    - 'app/models/namespace.rb'
-    - 'app/models/user.rb'
-    - 'config/initializers/secret_token.rb'
-    - 'db/migrate/20161220141214_remove_dot_git_from_group_names.rb'
-    - 'db/migrate/20161226122833_remove_dot_git_from_usernames.rb'
-    - 'lib/banzai/filter/math_filter.rb'
-    - 'lib/banzai/filter/table_of_contents_filter.rb'
-    - 'lib/gitlab/fogbugz_import/importer.rb'
-    - 'lib/gitlab/metrics/instrumentation.rb'
-    - 'lib/gitlab/metrics/sampler.rb'
-    - 'lib/gitlab/project_search_results.rb'
+  Enabled: false
 
 # Offense count: 19
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
 # SupportedOctalStyles: zero_with_o, zero_only
 Style/NumericLiteralPrefix:
-  Exclude:
-    - 'config/initializers/1_settings.rb'
-    - 'config/initializers/secret_token.rb'
-    - 'lib/gitlab/backend/shell.rb'
-    - 'lib/gitlab/import_export/command_line_util.rb'
-    - 'lib/gitlab/workhorse.rb'
-    - 'spec/features/projects/import_export/export_file_spec.rb'
-    - 'spec/lib/gitlab/git/blob_spec.rb'
-    - 'spec/lib/gitlab/git/hook_spec.rb'
-    - 'spec/lib/gitlab/git/repository_spec.rb'
-    - 'spec/lib/gitlab/workhorse_spec.rb'
-    - 'spec/support/import_export/export_file_helper.rb'
-    - 'spec/support/test_env.rb'
-    - 'spec/tasks/gitlab/backup_rake_spec.rb'
+  Enabled: false
 
 # Offense count: 19
 # Cop supports --auto-correct.
@@ -558,7 +374,7 @@ Style/NumericPredicate:
 Style/ParallelAssignment:
   Enabled: false
 
-# Offense count: 416
+# Offense count: 417
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
@@ -569,28 +385,14 @@ Style/PercentLiteralDelimiters:
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: lower_case_q, upper_case_q
 Style/PercentQLiterals:
-  Exclude:
-    - 'spec/lib/gitlab/diff/highlight_spec.rb'
-    - 'spec/models/project_services/bamboo_service_spec.rb'
-    - 'spec/models/project_services/teamcity_service_spec.rb'
-    - 'spec/workers/repository_import_worker_spec.rb'
+  Enabled: false
 
 # Offense count: 13
 # Cop supports --auto-correct.
 Style/PerlBackrefs:
-  Exclude:
-    - 'app/controllers/projects/application_controller.rb'
-    - 'app/helpers/submodule_helper.rb'
-    - 'lib/banzai/filter/abstract_reference_filter.rb'
-    - 'lib/banzai/filter/autolink_filter.rb'
-    - 'lib/banzai/filter/emoji_filter.rb'
-    - 'lib/banzai/filter/gollum_tags_filter.rb'
-    - 'lib/expand_variables.rb'
-    - 'lib/gitlab/diff/highlight.rb'
-    - 'lib/gitlab/search_results.rb'
-    - 'lib/gitlab/sherlock/query.rb'
-
-# Offense count: 63
+  Enabled: false
+
+# Offense count: 64
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
 # NamePrefix: is_, has_, have_
 # NamePrefixBlacklist: is_, has_, have_
@@ -608,13 +410,7 @@ Style/PreferredHashMethods:
 # Offense count: 8
 # Cop supports --auto-correct.
 Style/Proc:
-  Exclude:
-    - 'app/mailers/base_mailer.rb'
-    - 'app/models/milestone.rb'
-    - 'app/models/service.rb'
-    - 'lib/api/api_guard.rb'
-    - 'lib/gitlab/ldap/config.rb'
-    - 'spec/initializers/trusted_proxies_spec.rb'
+  Enabled: false
 
 # Offense count: 50
 # Cop supports --auto-correct.
@@ -626,47 +422,23 @@ Style/RaiseArgs:
 # Offense count: 4
 # Cop supports --auto-correct.
 Style/RedundantBegin:
-  Exclude:
-    - 'app/models/ci/build.rb'
-    - 'app/models/merge_request.rb'
-    - 'app/services/projects/import_service.rb'
-    - 'lib/gitlab/git/commit.rb'
+  Enabled: false
 
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/RedundantException:
-  Exclude:
-    - 'app/helpers/preferences_helper.rb'
+  Enabled: false
 
 # Offense count: 29
 # Cop supports --auto-correct.
 Style/RedundantFreeze:
-  Exclude:
-    - 'app/models/merge_request.rb'
-    - 'app/validators/color_validator.rb'
-    - 'app/validators/line_code_validator.rb'
-    - 'lib/api/templates.rb'
-    - 'lib/banzai/filter/blockquote_fence_filter.rb'
-    - 'lib/banzai/filter/gollum_tags_filter.rb'
-    - 'lib/banzai/filter/yaml_front_matter_filter.rb'
-    - 'lib/gitlab/diff/inline_diff.rb'
-    - 'lib/gitlab/ee_compat_check.rb'
-    - 'lib/gitlab/import_export/relation_factory.rb'
-    - 'lib/gitlab/incoming_email.rb'
-    - 'lib/gitlab/middleware/static.rb'
-    - 'lib/gitlab/regex.rb'
+  Enabled: false
 
 # Offense count: 11
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleReturnValues.
 Style/RedundantReturn:
-  Exclude:
-    - 'app/controllers/concerns/issuable_actions.rb'
-    - 'app/controllers/groups/application_controller.rb'
-    - 'app/controllers/groups_controller.rb'
-    - 'app/controllers/projects/labels_controller.rb'
-    - 'app/controllers/projects/milestones_controller.rb'
-    - 'app/services/access_token_validation_service.rb'
+  Enabled: false
 
 # Offense count: 359
 # Cop supports --auto-correct.
@@ -683,49 +455,26 @@ Style/RegexpLiteral:
 # Offense count: 19
 # Cop supports --auto-correct.
 Style/RescueModifier:
-  Exclude:
-    - 'app/controllers/admin/system_info_controller.rb'
-    - 'app/controllers/users_controller.rb'
-    - 'app/helpers/blob_helper.rb'
-    - 'app/helpers/issues_helper.rb'
-    - 'app/models/diff_note.rb'
-    - 'app/models/project_services/external_wiki_service.rb'
-    - 'app/models/sent_notification.rb'
-    - 'app/models/todo.rb'
-    - 'config/initializers/1_settings.rb'
-    - 'config/initializers/attr_encrypted_no_db_connection.rb'
-    - 'lib/gitlab/current_settings.rb'
-    - 'lib/gitlab/diff/parser.rb'
-    - 'lib/gitlab/kubernetes.rb'
-    - 'lib/gitlab/slash_commands/command_definition.rb'
-    - 'spec/support/matchers/be_url.rb'
+  Enabled: false
 
 # Offense count: 7
 # Cop supports --auto-correct.
 Style/SelfAssignment:
-  Exclude:
-    - 'app/models/project_team.rb'
-    - 'app/services/notification_service.rb'
-    - 'lib/api/runners.rb'
-    - 'spec/features/merge_requests/diff_notes_resolve_spec.rb'
-    - 'spec/support/import_export/configuration_helper.rb'
+  Enabled: false
 
 # Offense count: 2
 # Configuration parameters: Methods.
 # Methods: {"reduce"=>["acc", "elem"]}, {"inject"=>["acc", "elem"]}
 Style/SingleLineBlockParams:
-  Exclude:
-    - 'app/models/commit.rb'
-    - 'spec/support/services_shared_context.rb'
+  Enabled: false
 
 # Offense count: 50
 # Cop supports --auto-correct.
 # Configuration parameters: AllowIfMethodIsEmpty.
 Style/SingleLineMethods:
-  Exclude:
-    - 'lib/ci/ansi2html.rb'
+  Enabled: false
 
-# Offense count: 140
+# Offense count: 138
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: space, no_space
@@ -736,33 +485,14 @@ Style/SpaceBeforeBlockBraces:
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment.
 Style/SpaceBeforeFirstArg:
-  Exclude:
-    - 'config/routes/project.rb'
-    - 'features/steps/project/source/browse_files.rb'
-    - 'features/steps/project/source/markdown_render.rb'
-    - 'spec/routing/project_routing_spec.rb'
-    - 'spec/services/system_note_service_spec.rb'
+  Enabled: false
 
 # Offense count: 37
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: require_no_space, require_space
 Style/SpaceInLambdaLiteral:
-  Exclude:
-    - 'app/models/concerns/mentionable.rb'
-    - 'app/models/issue.rb'
-    - 'app/models/member.rb'
-    - 'lib/api/entities.rb'
-    - 'lib/file_size_validator.rb'
-    - 'lib/gitlab/visibility_level.rb'
-    - 'spec/models/concerns/participable_spec.rb'
-    - 'spec/models/cycle_analytics/code_spec.rb'
-    - 'spec/models/cycle_analytics/issue_spec.rb'
-    - 'spec/models/cycle_analytics/plan_spec.rb'
-    - 'spec/models/cycle_analytics/production_spec.rb'
-    - 'spec/models/cycle_analytics/review_spec.rb'
-    - 'spec/models/cycle_analytics/staging_spec.rb'
-    - 'spec/models/cycle_analytics/test_spec.rb'
+  Enabled: false
 
 # Offense count: 174
 # Cop supports --auto-correct.
@@ -784,8 +514,7 @@ Style/SpaceInsideParens:
 # Offense count: 4
 # Cop supports --auto-correct.
 Style/SpaceInsidePercentLiteralDelimiters:
-  Exclude:
-    - 'lib/gitlab/git_access.rb'
+  Enabled: false
 
 # Offense count: 53
 # Cop supports --auto-correct.
@@ -799,23 +528,9 @@ Style/SpecialGlobalVars:
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiteralsInInterpolation:
-  Exclude:
-    - 'app/helpers/labels_helper.rb'
-    - 'app/helpers/time_helper.rb'
-    - 'app/helpers/todos_helper.rb'
-    - 'app/models/application_setting.rb'
-    - 'app/models/project_services/campfire_service.rb'
-    - 'app/models/project_services/jira_service.rb'
-    - 'db/migrate/20161017125927_add_unique_index_to_labels.rb'
-    - 'features/steps/groups.rb'
-    - 'features/steps/project/merge_requests.rb'
-    - 'lib/banzai/filter/abstract_reference_filter.rb'
-    - 'lib/ci/gitlab_ci_yaml_processor.rb'
-    - 'lib/gitlab/google_code_import/importer.rb'
-    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
-    - 'spec/models/project_services/hipchat_service_spec.rb'
-
-# Offense count: 52
+  Enabled: false
+
+# Offense count: 54
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoredMethods.
 # IgnoredMethods: respond_to, define_method
@@ -827,21 +542,16 @@ Style/SymbolProc:
 # Configuration parameters: EnforcedStyle, SupportedStyles, AllowSafeAssignment.
 # SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
 Style/TernaryParentheses:
-  Exclude:
-    - 'features/support/capybara.rb'
-    - 'lib/api/projects.rb'
-    - 'lib/banzai/filter/table_of_contents_filter.rb'
-    - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
-    - 'spec/support/capybara.rb'
+  Enabled: false
 
-# Offense count: 35
+# Offense count: 36
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
 # SupportedStyles: comma, consistent_comma, no_comma
 Style/TrailingCommaInArguments:
   Enabled: false
 
-# Offense count: 149
+# Offense count: 150
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
 # SupportedStyles: comma, consistent_comma, no_comma
@@ -852,15 +562,9 @@ Style/TrailingCommaInLiteral:
 # Cop supports --auto-correct.
 # Configuration parameters: AllowNamedUnderscoreVariables.
 Style/TrailingUnderscoreVariable:
-  Exclude:
-    - 'app/controllers/admin/background_jobs_controller.rb'
-    - 'app/controllers/invites_controller.rb'
-    - 'app/controllers/projects/git_http_client_controller.rb'
-    - 'app/helpers/tab_helper.rb'
-    - 'lib/gitlab/git/repository.rb'
-    - 'lib/gitlab/logger.rb'
+  Enabled: false
 
-# Offense count: 66
+# Offense count: 67
 # Cop supports --auto-correct.
 Style/TrailingWhitespace:
   Enabled: false
@@ -870,44 +574,19 @@ Style/TrailingWhitespace:
 # Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
 # Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
 Style/TrivialAccessors:
-  Exclude:
-    - 'app/models/external_issue.rb'
-    - 'app/serializers/base_serializer.rb'
-    - 'lib/gitlab/ldap/person.rb'
+  Enabled: false
 
 # Offense count: 2
 # Cop supports --auto-correct.
 Style/UnlessElse:
-  Exclude:
-    - 'lib/gitlab/project_search_results.rb'
-    - 'spec/features/issues/award_emoji_spec.rb'
+  Enabled: false
 
 # Offense count: 17
 # Cop supports --auto-correct.
 Style/UnneededInterpolation:
-  Exclude:
-    - 'app/helpers/boards_helper.rb'
-    - 'app/helpers/projects_helper.rb'
-    - 'app/helpers/search_helper.rb'
-    - 'app/helpers/time_helper.rb'
-    - 'app/models/merge_request.rb'
-    - 'app/models/project_services/pushover_service.rb'
-    - 'features/steps/project/forked_merge_requests.rb'
-    - 'spec/features/admin/admin_projects_spec.rb'
-    - 'spec/features/issues_spec.rb'
-    - 'spec/features/projects/branches_spec.rb'
-    - 'spec/features/projects/issuable_templates_spec.rb'
-    - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb'
-    - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb'
+  Enabled: false
 
 # Offense count: 8
 # Cop supports --auto-correct.
 Style/ZeroLengthPredicate:
-  Exclude:
-    - 'app/models/deploy_key.rb'
-    - 'app/models/merge_request.rb'
-    - 'app/models/network/commit.rb'
-    - 'app/models/network/graph.rb'
-    - 'app/models/project_services/asana_service.rb'
-    - 'app/models/repository.rb'
-    - 'lib/extracts_path.rb'
+  Enabled: false

CHANGELOG.md

@@ -2,6 +2,16 @@
 documentation](doc/development/changelog.md) for instructions on adding your own
 entry.
 
+## 8.15.4 (2017-01-09)
+
+- Make successful pipeline emails off for watchers. !8176
+- Speed up group milestone index by passing group_id to IssuesFinder. !8363
+- Don't instrument 405 Grape calls. !8445
+- Update the gitlab-markup gem to the version 1.5.1. !8509
+- Updated Turbolinks to mitigate potential XSS attacks.
+- Re-order update steps in the 8.14 -> 8.15 upgrade guide.
+- Re-add Google Cloud Storage as a backup strategy.
+
 ## 8.15.3 (2017-01-06)
 
 - Rename wiki_events to wiki_page_events in project hooks API to avoid errors. !8425
@@ -255,6 +265,11 @@ entry.
 - Whitelist next project names: help, ci, admin, search. !8227
 - Adds back CSS for progress-bars. !8237
 
+## 8.14.6 (2017-01-10)
+
+- Update the gitlab-markup gem to the version 1.5.1. !8509
+- Updated Turbolinks to mitigate potential XSS attacks.
+
 ## 8.14.5 (2016-12-14)
 
 - Moved Leave Project and Leave Group buttons to access_request_buttons from the settings dropdown. !7600
@@ -532,6 +547,11 @@ entry.
 - Fix "Without projects" filter. !6611 (Ben Bodenmiller)
 - Fix 404 when visit /projects page
 
+## 8.13.11 (2017-01-10)
+
+- Update the gitlab-markup gem to the version 1.5.1. !8509
+- Updated Turbolinks to mitigate potential XSS attacks.
+
 ## 8.13.10 (2016-12-14)
 
 - API: Memoize the current_user so that sudo can work properly. !8017

Gemfile

@@ -221,8 +221,7 @@ gem 'chronic_duration', '~> 0.10.6'
 gem 'sass-rails', '~> 5.0.6'
 gem 'coffee-rails', '~> 4.1.0'
 gem 'uglifier', '~> 2.7.2'
-gem 'turbolinks', '~> 2.5.0'
-gem 'jquery-turbolinks', '~> 2.1.0'
+gem 'gitlab-turbolinks-classic', '~> 2.5', '>= 2.5.6'
 
 gem 'addressable',        '~> 2.3.8'
 gem 'bootstrap-sass',     '~> 3.3.0'

Gemfile.lock

@@ -264,6 +264,8 @@ GEM
       mime-types (>= 1.16, < 3)
       posix-spawn (~> 0.3)
     gitlab-markup (1.5.1)
+    gitlab-turbolinks-classic (2.5.6)
+      coffee-rails
     gitlab_omniauth-ldap (1.2.1)
       net-ldap (~> 0.9)
       omniauth (~> 1.0)
@@ -370,9 +372,6 @@ GEM
       rails-dom-testing (>= 1, < 3)
       railties (>= 4.2.0)
       thor (>= 0.14, < 2.0)
-    jquery-turbolinks (2.1.0)
-      railties (>= 3.1.0)
-      turbolinks
     jquery-ui-rails (5.0.5)
       railties (>= 3.2.16)
     json (1.8.3)
@@ -782,8 +781,6 @@ GEM
     truncato (0.7.8)
       htmlentities (~> 4.3.1)
       nokogiri (~> 1.6.1)
-    turbolinks (2.5.3)
-      coffee-rails
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
     u2f (0.2.1)
@@ -893,6 +890,7 @@ DEPENDENCIES
   github-linguist (~> 4.7.0)
   gitlab-flowdock-git-hook (~> 1.0.1)
   gitlab-markup (~> 1.5.1)
+  gitlab-turbolinks-classic (~> 2.5, >= 2.5.6)
   gitlab_omniauth-ldap (~> 1.2.1)
   gollum-lib (~> 4.2)
   gollum-rugged_adapter (~> 0.4.2)
@@ -911,7 +909,6 @@ DEPENDENCIES
   jira-ruby (~> 1.1.2)
   jquery-atwho-rails (~> 1.3.2)
   jquery-rails (~> 4.1.0)
-  jquery-turbolinks (~> 2.1.0)
   jquery-ui-rails (~> 5.0.0)
   json-schema (~> 2.6.2)
   jwt
@@ -1010,7 +1007,6 @@ DEPENDENCIES
   thin (~> 1.7.0)
   timecop (~> 0.8.0)
   truncato (~> 0.7.8)
-  turbolinks (~> 2.5.0)
   u2f (~> 0.2.1)
   uglifier (~> 2.7.2)
   underscore-rails (~> 1.8.0)

app/assets/stylesheets/framework/layout.scss

@@ -41,6 +41,21 @@ body {
     }
   }
 
+  .alert-link-group {
+    float: right;
+  }
+
+  /* Center alert text and alert action links on smaller screens */
+  @media (max-width: $screen-sm-max) {
+    .alert {
+      text-align: center;
+    }
+
+    .alert-link-group {
+      float: none;
+    }
+  }
+
   /* Stripe the background colors so that adjacent alert-warnings are distinct from one another */
   .alert-warning {
     transition: background-color 0.15s, border-color 0.15s;

app/assets/stylesheets/framework/mobile.scss

@@ -37,10 +37,6 @@
     display: none;
   }
 
-  .project-avatar {
-    display: none;
-  }
-
   .project-home-panel {
     padding-left: 0 !important;
 

app/assets/stylesheets/framework/sidebar.scss

@@ -183,7 +183,9 @@
 
   &.right-sidebar-expanded {
     .line-resolve-all-container {
-      display: none;
+      @media (min-width: $sidebar-breakpoint) {
+        display: none;
+      }
     }
   }
 }

app/assets/stylesheets/pages/issuable.scss

+// Limit MR description for side-by-side diff view
+.fixed-width-container {
+  max-width: $limited-layout-width - ($gl-padding * 2);
+  margin-left: auto;
+  margin-right: auto;
+}
+
+.limit-container-width {
+  .detail-page-header {
+    @extend .fixed-width-container;
+  }
+
+  .issuable-details {
+    .detail-page-description,
+    .mr-source-target,
+    .mr-state-widget,
+    .merge-manually {
+      @extend .fixed-width-container;
+    }
+
+    .merge-request-tabs-holder {
+      &.affix {
+        border-bottom: 1px solid $border-color;
+
+        .nav-links {
+          border: 0;
+        }
+      }
+
+      .container-fluid {
+        @extend .fixed-width-container;
+      }
+    }
+  }
+
+  .merge-request-details {
+    .emoji-list-container {
+      @extend .fixed-width-container;
+    }
+  }
+
+  .diffs {
+    .mr-version-controls,
+    .files-changed {
+      @extend .fixed-width-container;
+    }
+  }
+}
+
 .issuable-details {
   section {
     .issuable-discussion {

app/assets/stylesheets/pages/notes.scss

@@ -526,8 +526,9 @@ ul.notes {
 }
 
 .line-resolve-all {
+  vertical-align: middle;
   display: inline-block;
-  padding: 5px 10px;
+  padding: 6px 10px;
   background-color: $gray-light;
   border: 1px solid $border-color;
   border-radius: $border-radius-default;
@@ -535,18 +536,14 @@ ul.notes {
   &.has-next-btn {
     border-top-right-radius: 0;
     border-bottom-right-radius: 0;
+    border-right: 0;
   }
 
   .line-resolve-btn {
-    vertical-align: middle;
     margin-right: 5px;
   }
 }
 
-.line-resolve-text {
-  vertical-align: middle;
-}
-
 .line-resolve-btn {
   display: inline-block;
   position: relative;

app/assets/stylesheets/pages/projects.scss

@@ -587,11 +587,21 @@ pre.light-well {
 
     .project-full-name {
       @include str-truncated;
+
+      @media (max-width: $screen-xs-max) {
+        max-width: 50%;
+      }
     }
 
     .controls {
       line-height: $list-text-height;
 
+      .badge {
+        @media (max-width: $screen-xs-max) {
+          display: none;
+        }
+      }
+
       a:hover {
         text-decoration: none;
       }
@@ -605,6 +615,12 @@ pre.light-well {
         top: 2px;
       }
     }
+
+    .description p {
+      @media (max-width: $screen-xs-max) {
+        max-width: 50%;
+      }
+    }
   }
 
   .bottom {

app/views/projects/issues/show.html.haml

-- @content_class = "limit-container-width"
+- @content_class = "limit-container-width" unless fluid_layout
 - page_title           "#{@issue.title} (#{@issue.to_reference})", "Issues"
 - page_description     @issue.description
 - page_card_attributes @issue.card_attributes

app/views/projects/merge_requests/_show.html.haml

-- @content_class = "limit-container-width"
+- @content_class = "limit-container-width" unless fluid_layout
 - page_title           "#{@merge_request.title} (#{@merge_request.to_reference})", "Merge Requests"
 - page_description     @merge_request.description
 - page_card_attributes @merge_request.card_attributes
@@ -47,7 +47,7 @@
         = succeed '.' do
           = link_to "command line", "#modal_merge_info", class: "how_to_merge_link vlink", title: "How To Merge", "data-toggle" => "modal"
 
-    .content-block.content-block-small
+    .content-block.content-block-small.emoji-list-container
       = render 'award_emoji/awards_block', awardable: @merge_request, inline: true
 
     .merge-request-tabs-holder{ class: ("js-tabs-affix" unless ENV['RAILS_ENV'] == 'test') }

app/views/shared/_no_password.html.haml

 - if cookies[:hide_no_password_message].blank? && !current_user.hide_no_password && current_user.require_password?
-  .no-password-message.alert.alert-warning.hidden-xs
+  .no-password-message.alert.alert-warning
     You won't be able to pull or push project code via #{gitlab_config.protocol.upcase} until you #{link_to 'set a password', edit_profile_password_path} on your account
 
-    .pull-right
+    .alert-link-group
       = link_to "Don't show again", profile_path(user: {hide_no_password: true}), method: :put
       |
       = link_to 'Remind later', '#', class: 'hide-no-password-message'

app/views/shared/_no_ssh.html.haml

 - if cookies[:hide_no_ssh_message].blank? && !current_user.hide_no_ssh_key && current_user.require_ssh_key?
-  .no-ssh-key-message.alert.alert-warning.hidden-xs
+  .no-ssh-key-message.alert.alert-warning
     You won't be able to pull or push project code via SSH until you #{link_to 'add an SSH key', profile_keys_path, class: 'alert-link'} to your profile
 
-    .pull-right
+    .alert-link-group
       = link_to "Don't show again", profile_path(user: {hide_no_ssh_key: true}), method: :put, class: 'alert-link'
       |
       = link_to 'Remind later', '#', class: 'hide-no-ssh-message alert-link'

changelogs/unreleased/25776-alerts-should-be-responsive.yml

+---
+title: Changed alerts to be responsive, centered text on smaller viewports
+merge_request: 8424
+author: Connor Smallman

changelogs/unreleased/26435-show-project-avatars-on-mobile.yml

+---
+title: Display project avatars on Admin Area and Projects pages for mobile views
+merge_request:
+author: Ryan Harris

changelogs/unreleased/26504-mr-discussion-btn.yml

+---
+title: 26504 Fix styling of MR jump to discussion button
+merge_request:
+author:

changelogs/unreleased/fix-user-api-confirm-param.yml

+---
+title: Fix 500 error when POSTing to Users API with optional confirm param
+merge_request:
+author:

changelogs/unreleased/speed-up-group-milestone-index.yml

----
-title: Speed up group milestone index by passing group_id to IssuesFinder
-merge_request: 8363
-author:

doc/raketasks/backup_restore.md

@@ -94,7 +94,7 @@ In the example below we use Amazon S3 for storage, but Fog also lets you use
 for AWS, Google, OpenStack Swift and Rackspace as well. A local driver is
 [also available](#uploading-to-locally-mounted-shares).
 
-For omnibus packages:
+For omnibus packages, add the following to `/etc/gitlab/gitlab.rb`:
 
 ```ruby
 gitlab_rails['backup_upload_connection'] = {
@@ -109,6 +109,8 @@ gitlab_rails['backup_upload_connection'] = {
 gitlab_rails['backup_upload_remote_directory'] = 'my.s3.bucket'
 ```
 
+Make sure to run `sudo gitlab-ctl reconfigure` after editing `/etc/gitlab/gitlab.rb` to reflect the changes.
+
 For installations from source:
 
 ```yaml

doc/workflow/importing/import_projects_from_gitlab_com.md

@@ -5,6 +5,9 @@ GitLab support is enabled on your GitLab instance.
 You can read more about GitLab support [here](http://docs.gitlab.com/ce/integration/gitlab.html)
 To get to the importer page you need to go to "New project" page.
 
+>**Note:**
+If you are interested in importing Wiki and Merge Request data to your new instance, you'll need to follow the instructions for [project export](../../user/project/settings/import_export.md)
+
 ![New project page](gitlab_importer/new_project_page.png)
 
 Click on the "Import projects from GitLab.com" link and you will be redirected to GitLab.com

lib/api/users.rb

@@ -93,7 +93,7 @@ module API
         # Filter out params which are used later
         user_params = declared_params(include_missing: false)
         identity_attrs = user_params.slice(:provider, :extern_uid)
-        confirm = params.delete(:confirm)
+        confirm = user_params.delete(:confirm)
 
         user = User.new(user_params.except(:extern_uid, :provider))
         user.skip_confirmation! unless confirm

spec/requests/api/users_spec.rb

@@ -137,6 +137,15 @@ describe API::Users, api: true  do
       expect(new_user.can_create_group).to eq(true)
     end
 
+    it "creates user with optional attributes" do
+      optional_attributes = { confirm: true }
+      attributes = attributes_for(:user).merge(optional_attributes)
+
+      post api('/users', admin), attributes
+
+      expect(response).to have_http_status(201)
+    end
+
     it "creates non-admin user" do
       post api('/users', admin), attributes_for(:user, admin: false, can_create_group: false)
       expect(response).to have_http_status(201)

vendor/assets/javascripts/jquery.turbolinks.js

+// Generated by CoffeeScript 1.7.1
+
+/*
+jQuery.Turbolinks ~ https://github.com/kossnocorp/jquery.turbolinks
+jQuery plugin for drop-in fix binded events problem caused by Turbolinks
+
+The MIT License
+Copyright (c) 2012-2013 Sasha Koss & Rico Sta. Cruz
+ */
+
+(function() {
+  var $, $document;
+
+  $ = window.jQuery || (typeof require === "function" ? require('jquery') : void 0);
+
+  $document = $(document);
+
+  $.turbo = {
+    version: '2.1.0',
+    isReady: false,
+    use: function(load, fetch) {
+      return $document.off('.turbo').on("" + load + ".turbo", this.onLoad).on("" + fetch + ".turbo", this.onFetch);
+    },
+    addCallback: function(callback) {
+      if ($.turbo.isReady) {
+        callback($);
+      }
+      return $document.on('turbo:ready', function() {
+        return callback($);
+      });
+    },
+    onLoad: function() {
+      $.turbo.isReady = true;
+      return $document.trigger('turbo:ready');
+    },
+    onFetch: function() {
+      return $.turbo.isReady = false;
+    },
+    register: function() {
+      $(this.onLoad);
+      return $.fn.ready = this.addCallback;
+    }
+  };
+
+  $.turbo.register();
+
+  $.turbo.use('page:load', 'page:fetch');
+
+}).call(this);

vendor/gitignore/Android.gitignore

@@ -35,6 +35,8 @@ captures/
 # Intellij
 *.iml
 .idea/workspace.xml
+.idea/tasks.xml
+.idea/gradle.xml
 .idea/libraries
 
 # Keystore files

vendor/gitignore/Autotools.gitignore

 # http://www.gnu.org/software/automake
 
 Makefile.in
+/ar-lib
+/mdate-sh
+/py-compile
+/test-driver
+/ylwrap
 
 # http://www.gnu.org/software/autoconf
 
@@ -9,10 +14,20 @@ Makefile.in
 /autoscan-*.log
 /aclocal.m4
 /compile
+/config.guess
 /config.h.in
+/config.sub
 /configure
 /configure.scan
 /depcomp
 /install-sh
 /missing
 /stamp-h1
+
+# https://www.gnu.org/software/libtool/
+
+/ltmain.sh
+
+# http://www.gnu.org/software/texinfo
+
+/texinfo.tex

vendor/gitignore/CMake.gitignore

@@ -4,4 +4,5 @@ CMakeScripts
 Makefile
 cmake_install.cmake
 install_manifest.txt
+compile_commands.json
 CTestTestfile.cmake

vendor/gitignore/Clojure.gitignore

-pom.xml
-pom.xml.asc
-*.jar
-*.class
-/lib/
-/classes/
-/target/
-/checkouts/
-.lein-deps-sum
-.lein-repl-history
-.lein-plugins/
-.lein-failures
-.nrepl-port

vendor/gitignore/Clojure.gitignore

+Leiningen.gitignore
\ No newline at end of file

vendor/gitignore/CodeIgniter.gitignore

@@ -4,3 +4,8 @@
 */cache/*
 !*/cache/index.html
 !*/cache/.htaccess
+
+user_guide_src/build/*
+user_guide_src/cilexer/build/*
+user_guide_src/cilexer/dist/*
+user_guide_src/cilexer/pycilexer.egg-info/*

vendor/gitignore/CommonLisp.gitignore

 *.FASL
 *.fasl
 *.lisp-temp
+*.dfsl
+*.pfsl
+*.d64fsl
+*.p64fsl
+*.lx64fsl
+*.lx32fsl
+*.dx64fsl
+*.dx32fsl
+*.fx64fsl
+*.fx32fsl
+*.sx64fsl
+*.sx32fsl
+*.wx64fsl
+*.wx32fsl

vendor/gitignore/Coq.gitignore

-*.vo
+.*.aux
+*.a
+*.cma
+*.cmi
+*.cmo
+*.cmx
+*.cmxa
+*.cmxs
 *.glob
+*.ml.d
+*.ml4.d
+*.mli.d
+*.mllib.d
+*.mlpack.d
+*.native
+*.o
 *.v.d
+*.vio
+*.vo
+.coq-native/
+.csdp.cache
+.lia.cache
+.nia.cache
+.nlia.cache
+.nra.cache
+csdp.cache
+lia.cache
+nia.cache
+nlia.cache
+nra.cache

vendor/gitignore/Dart.gitignore

 # See https://www.dartlang.org/tools/private-files.html
 
 # Files and directories created by pub
-.buildlog
+
+# SDK 1.20 and later (no longer creates packages directories)
 .packages
-.project
 .pub/
 build/
+
+# Older SDK versions
+# (Include if the minimum SDK version specified in pubsepc.yaml is earlier than 1.20)
+.project
+.buildlog
 **/packages/
 
+
 # Files created by dart2js
 # (Most Dart developers will use pub build to compile Dart, use/modify these 
 #  rules if you intend to use dart2js directly

vendor/gitignore/Elisp.gitignore

@@ -3,3 +3,9 @@
 
 # Packaging
 .cask
+
+# Backup files
+*~
+
+# Undo-tree save-files
+*.~undo-tree

vendor/gitignore/Elixir.gitignore

@@ -3,3 +3,4 @@
 /deps
 erl_crash.dump
 *.ez
+*.beam

vendor/gitignore/Global/Emacs.gitignore

@@ -39,4 +39,7 @@ flycheck_*.el
 /server/
 
 # projectiles files
-.projectile
\ No newline at end of file
+.projectile
+
+# directory configuration
+.dir-locals.el

vendor/gitignore/Global/IPythonNotebook.gitignore

-# Temporary data
-.ipynb_checkpoints/

vendor/gitignore/Global/JetBrains.gitignore

@@ -6,6 +6,7 @@
 .idea/tasks.xml
 
 # Sensitive or high-churn files:
+.idea/dataSources/
 .idea/dataSources.ids
 .idea/dataSources.xml
 .idea/dataSources.local.xml

vendor/gitignore/Global/SublimeText.gitignore

@@ -20,6 +20,9 @@ Package Control.ca-bundle
 Package Control.system-ca-bundle
 Package Control.cache/
 Package Control.ca-certs/
+Package Control.merged-ca-bundle
+Package Control.user-ca-bundle
+oscrypto-ca-bundle.crt
 bh_unicode_properties.cache
 
 # Sublime-github package stores a github token in this file

vendor/gitignore/Global/Vim.gitignore

 # swap
-[._]*.s[a-w][a-z]
-[._]s[a-w][a-z]
+[._]*.s[a-v][a-z]
+[._]*.sw[a-p]
+[._]s[a-v][a-z]
+[._]sw[a-p]
 # session
 Session.vim
 # temporary

vendor/gitignore/Global/VisualStudioCode.gitignore

@@ -2,3 +2,4 @@
 !.vscode/settings.json
 !.vscode/tasks.json
 !.vscode/launch.json
+!.vscode/extensions.json

vendor/gitignore/Global/Windows.gitignore

-# Windows image file caches
+# Windows thumbnail cache files
 Thumbs.db
 ehthumbs.db
+ehthumbs_vista.db
 
 # Folder config file
 Desktop.ini

vendor/gitignore/Go.gitignore

@@ -26,5 +26,5 @@ _testmain.go
 # Output of the go coverage tool, specifically when used with LiteIDE
 *.out
 
-# external packages folder
+# External packages folder
 vendor/

vendor/gitignore/Java.gitignore

 *.class
 
+# BlueJ files
+*.ctxt
+
 # Mobile Tools for Java (J2ME)
 .mtj.tmp/
 

vendor/gitignore/Laravel.gitignore

@@ -6,8 +6,8 @@ bootstrap/compiled.php
 app/storage/
 
 # Laravel 5 & Lumen specific
-bootstrap/cache/
 public/storage
+storage/*.key
 .env.*.php
 .env.php
 .env

vendor/gitignore/Maven.gitignore

@@ -7,3 +7,6 @@ release.properties
 dependency-reduced-pom.xml
 buildNumber.properties
 .mvn/timing.properties
+
+# Exclude maven wrapper
+!/.mvn/wrapper/maven-wrapper.jar

vendor/gitignore/Node.gitignore

@@ -42,3 +42,7 @@ jspm_packages
 
 # Output of 'npm pack'
 *.tgz
+
+# Yarn Integrity file
+.yarn-integrity
+

vendor/gitignore/Perl.gitignore

-/blib/
-/.build/
-_build/
-cover_db/
-inc/
-Build
 !Build/
-Build.bat
 .last_cover_stats
-/Makefile
-/Makefile.old
-/MANIFEST.bak
 /META.yml
 /META.json
 /MYMETA.*
-nytprof.out
-/pm_to_blib
 *.o
 *.bs
+
+# Devel::Cover
+cover_db/
+
+# Devel::NYTProf
+nytprof.out
+
+# Dizt::Zilla
+/.build/
+
+# Module::Build
+_build/
+Build
+Build.bat
+
+# Module::Install
+inc/
+
+# ExtUitls::MakeMaker
+/blib/
 /_eumm/
+/*.gz
+/Makefile
+/Makefile.old
+/MANIFEST.bak
+/pm_to_blib
+/*.zip

vendor/gitignore/Python.gitignore

@@ -20,6 +20,7 @@ lib64/
 parts/
 sdist/
 var/
+wheels/
 *.egg-info/
 .installed.cfg
 *.egg

vendor/gitignore/Symfony.gitignore

@@ -31,9 +31,6 @@
 /web/bundles/
 /web/uploads/
 
-# Assets managed by Bower
-/web/assets/vendor/
-
 # PHPUnit
 /app/phpunit.xml
 /phpunit.xml
@@ -45,4 +42,4 @@
 /composer.phar
 
 # Backup entities generated with doctrine:generate:entities command
-*/Entity/*~
+**/Entity/*~

vendor/gitignore/TeX.gitignore

@@ -52,12 +52,22 @@ acs-*.bib
 
 # beamer
 *.nav
+*.pre
 *.snm
 *.vrb
 
+# changes
+*.soc
+
 # cprotect
 *.cpt
 
+# elsarticle (documentclass of Elsevier journals)
+*.spl
+
+# endnotes
+*.ent
+
 # fixme
 *.lox
 
@@ -123,9 +133,7 @@ acs-*.bib
 *.maf
 *.mlf
 *.mlt
-*.mtc
-*.mtc[0-9]
-*.mtc[1-9][0-9]
+*.mtc[0-9]*
 
 # minted
 _minted*
@@ -140,6 +148,9 @@ _minted*
 # nomencl
 *.nlo
 
+# pax
+*.pax
+
 # sagetex
 *.sagetex.sage
 *.sagetex.py
@@ -202,5 +213,8 @@ TSWLatexianTemp*
 # KBibTeX
 *~[0-9]*
 
-# auto folder when using emacs and auctex 
+# auto folder when using emacs and auctex
 /auto/*
+
+# expex forward references with \gathertags
+*-tags.tex

vendor/gitignore/VisualStudio.gitignore

@@ -8,7 +8,6 @@
 *.user
 *.userosscache
 *.sln.docstates
-*.vcxproj.filters
 
 # User-specific files (MonoDevelop/Xamarin Studio)
 *.userprefs
@@ -43,11 +42,11 @@ TestResult.xml
 [Rr]eleasePS/
 dlldata.c
 
-# DNX
+# .NET Core
 project.lock.json
 project.fragment.lock.json
 artifacts/
-Properties/launchSettings.json
+**/Properties/launchSettings.json
 
 *_i.c
 *_p.c

vendor/gitlab-ci-yml/Docker.gitlab-ci.yml

@@ -7,6 +7,7 @@ services:
 build:
   stage: build
   script:
+    - export IMAGE_TAG=$(echo -en $CI_BUILD_REF_NAME | tr -c '[:alnum:]_.-' '-')
     - docker login -u "gitlab-ci-token" -p "$CI_BUILD_TOKEN" $CI_REGISTRY
-    - docker build --pull -t "$CI_REGISTRY_IMAGE:$CI_BUILD_REF_NAME" .
-    - docker push "$CI_REGISTRY_IMAGE:$CI_BUILD_REF_NAME"
+    - docker build --pull -t "$CI_REGISTRY_IMAGE:$IMAGE_TAG" .
+    - docker push "$CI_REGISTRY_IMAGE:$IMAGE_TAG"

vendor/gitlab-ci-yml/Elixir.gitlab-ci.yml

-# This template uses the non default language docker image
-# The image already has Hex installed. You might want to consider to use `elixir:latest`
-image: trenpixster/elixir:latest
+image: elixir:latest
 
 # Pick zero or more services to be used on all builds.
 # Only needed when using a docker container to run your tests in.
@@ -11,6 +9,8 @@ services:
   - postgres:latest
 
 before_script:
+  - mix local.rebar --force
+  - mix local.hex --force
   - mix deps.get
 
 mix:

vendor/gitlab-ci-yml/Go.gitlab-ci.yml

+image: golang:latest
+
+# The problem is that to be able to use go get, one needs to put
+# the repository in the $GOPATH. So for example if your gitlab domain
+# is mydomainperso.com, and that your repository is repos/projectname, and
+# the default GOPATH being /go, then you'd need to have your
+# repository in /go/src/mydomainperso.com/repos/projectname 
+# Thus, making a symbolic link corrects this.
+before_script:
+    - ln -s /builds /go/src/mydomainperso.com
+    - cd /go/src/mydomainperso.com/repos/projectname
+
+stages:
+    - test
+    - build
+
+format:
+    stage: test
+    script:
+        # Add here all the dependencies, or use glide/govendor to get
+        # them automatically.
+        # - curl https://glide.sh/get | sh
+        - go get github.com/alecthomas/kingpin
+        - go tool vet -composites=false -shadow=true *.go
+        - go test -race $(go list ./... | grep -v /vendor/)
+
+compile:
+    stage: build
+    script:
+        # Add here all the dependencies, or use glide/govendor/...
+        # to get them automatically.
+        - go get github.com/alecthomas/kingpin
+        # Better put this in a Makefile
+        - go build -race -ldflags "-extldflags '-static'" -o mybinary
+    artifacts:
+        paths:
+            - mybinary

vendor/gitlab-ci-yml/Gradle.gitlab-ci.yml

@@ -31,4 +31,4 @@ build:
 test:
   stage: test
   script:
-    - ./gradlew -g /cache./gradle check
+    - ./gradlew -g /cache/.gradle check

vendor/gitlab-ci-yml/Openshift.gitlab-ci.yml

+# This file is a template, and might need editing before it works on your project.
+image: ayufan/openshift-cli
+
+stages:
+  - test
+  - review
+  - staging
+  - production
+
+variables:
+  OPENSHIFT_SERVER: openshift.default.svc.cluster.local
+  # OPENSHIFT_DOMAIN: apps.example.com
+  # Configure this variable in Secure Variables:
+  # OPENSHIFT_TOKEN: my.openshift.token
+
+test1:
+  stage: test
+  before_script: []
+  script:
+    - echo run tests
+
+test2:
+  stage: test
+  before_script: []
+  script:
+    - echo run tests
+
+.deploy: &deploy
+  before_script:
+    - oc login "$OPENSHIFT_SERVER" --token="$OPENSHIFT_TOKEN" --insecure-skip-tls-verify
+    - oc project "$CI_PROJECT_NAME" 2> /dev/null || oc new-project "$CI_PROJECT_NAME"
+  script:
+    - "oc get services $APP 2> /dev/null || oc new-app . --name=$APP --strategy=docker"
+    - "oc start-build $APP --from-dir=. --follow || sleep 3s || oc start-build $APP --from-dir=. --follow"
+    - "oc get routes $APP 2> /dev/null || oc expose service $APP --hostname=$APP_HOST"
+
+review:
+  <<: *deploy
+  stage: review
+  variables:
+    APP: $CI_BUILD_REF_NAME
+    APP_HOST: $CI_PROJECT_NAME-$CI_BUILD_REF_NAME.$OPENSHIFT_DOMAIN
+  environment:
+    name: review/$CI_BUILD_REF_NAME
+    url: http://$CI_PROJECT_NAME-$CI_BUILD_REF_NAME.$OPENSHIFT_DOMAIN
+    on_stop: stop-review
+  only:
+    - branches
+  except:
+    - master
+
+stop-review:
+  <<: *deploy
+  stage: review
+  script:
+    - oc delete all -l "app=$APP"
+  when: manual
+  variables:
+    APP: $CI_BUILD_REF_NAME
+    GIT_STRATEGY: none
+  environment:
+    name: review/$CI_BUILD_REF_NAME
+    action: stop
+  only:
+    - branches
+  except:
+    - master
+
+staging:
+  <<: *deploy
+  stage: staging
+  variables:
+    APP: staging
+    APP_HOST: $CI_PROJECT_NAME-staging.$OPENSHIFT_DOMAIN
+  environment:
+    name: staging
+    url: http://$CI_PROJECT_NAME-staging.$OPENSHIFT_DOMAIN
+  only:
+    - master
+
+production:
+  <<: *deploy
+  stage: production
+  variables:
+    APP: production
+    APP_HOST: $CI_PROJECT_NAME.$OPENSHIFT_DOMAIN
+  when: manual
+  environment:
+    name: production
+    url: http://$CI_PROJECT_NAME.$OPENSHIFT_DOMAIN
+  only:
+    - master

vendor/gitlab-ci-yml/autodeploy/OpenShift.gitlab-ci.yml

+# Explaination on the scripts: 
+# https://gitlab.com/gitlab-examples/openshift-deploy/blob/master/README.md
 image: registry.gitlab.com/gitlab-examples/openshift-deploy
 
 variables: