Commit e3705213 authored by Filipa Lacerda's avatar Filipa Lacerda

Removed typo check for `unaproved` in sast:container report

parent 476c193c
---
title: Remove unaproved typo check in sast:container report
merge_request:
author:
type: other
...@@ -90,10 +90,7 @@ export default class MergeRequestStore extends CEMergeRequestStore { ...@@ -90,10 +90,7 @@ export default class MergeRequestStore extends CEMergeRequestStore {
this.dockerReport.vulnerabilities = parsedVulnerabilities || []; this.dockerReport.vulnerabilities = parsedVulnerabilities || [];
// There is a typo in the original repo: const unapproved = data.unapproved || [];
// https://github.com/arminc/clair-scanner/pull/39/files
// Fix this when the above PR is accepted
const unapproved = data.unapproved || data.unaproved || [];
// Approved can be calculated by subtracting unapproved from vulnerabilities. // Approved can be calculated by subtracting unapproved from vulnerabilities.
this.dockerReport.approved = parsedVulnerabilities this.dockerReport.approved = parsedVulnerabilities
......
...@@ -145,21 +145,6 @@ describe('MergeRequestStore', () => { ...@@ -145,21 +145,6 @@ describe('MergeRequestStore', () => {
expect(store.dockerReport.approved).toEqual(dockerReportParsed.approved); expect(store.dockerReport.approved).toEqual(dockerReportParsed.approved);
expect(store.dockerReport.unapproved).toEqual(dockerReportParsed.unapproved); expect(store.dockerReport.unapproved).toEqual(dockerReportParsed.unapproved);
}); });
it('handles unaproved typo', () => {
store.setDockerReport({
vulnerabilities: [
{
vulnerability: 'CVE-2017-12944',
namespace: 'debian:8',
severity: 'Medium',
},
],
unaproved: ['CVE-2017-12944'],
});
expect(store.dockerReport.unapproved[0].vulnerability).toEqual('CVE-2017-12944');
});
}); });
describe('parseDockerVulnerabilities', () => { describe('parseDockerVulnerabilities', () => {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment