Commit e3b17387 authored by Mark Chao's avatar Mark Chao

Merge branch 'ali/update-usage-ping-snowplow-ff' into 'master'

Update feature flag to be consistent with ProductAnalytics tracking class

See merge request gitlab-org/gitlab!48844
parents 042dbc4e 6d20e886
...@@ -769,7 +769,7 @@ module Gitlab ...@@ -769,7 +769,7 @@ module Gitlab
end end
def report_snowplow_events? def report_snowplow_events?
self_monitoring_project && Feature.enabled?(:product_analytics, self_monitoring_project) self_monitoring_project && Feature.enabled?(:product_analytics_tracking, type: :ops)
end end
def distinct_count_service_desk_enabled_projects(time_period) def distinct_count_service_desk_enabled_projects(time_period)
......
...@@ -1313,7 +1313,7 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do ...@@ -1313,7 +1313,7 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
context 'and product_analytics FF is enabled for it' do context 'and product_analytics FF is enabled for it' do
before do before do
stub_feature_flags(product_analytics: project) stub_feature_flags(product_analytics_tracking: true)
create(:product_analytics_event, project: project, se_category: 'epics', se_action: 'promote') create(:product_analytics_event, project: project, se_category: 'epics', se_action: 'promote')
create(:product_analytics_event, project: project, se_category: 'epics', se_action: 'promote', collector_tstamp: 2.days.ago) create(:product_analytics_event, project: project, se_category: 'epics', se_action: 'promote', collector_tstamp: 2.days.ago)
...@@ -1329,7 +1329,7 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do ...@@ -1329,7 +1329,7 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
context 'and product_analytics FF is disabled' do context 'and product_analytics FF is disabled' do
before do before do
stub_feature_flags(product_analytics: false) stub_feature_flags(product_analytics_tracking: false)
end end
it 'returns an empty hash' do it 'returns an empty hash' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment