Merge branch 'leaky-constant-fix-34' into 'master'

Fix leaky constant in test coverage spec

See merge request gitlab-org/gitlab!32134

.rubocop.yml

@@ -351,7 +351,6 @@ RSpec/LeakyConstantDeclaration:
     - 'spec/db/schema_spec.rb'
     - 'spec/lib/feature_spec.rb'
     - 'spec/lib/gitlab/config/entry/simplifiable_spec.rb'
-    - 'spec/lib/gitlab/import_export/import_test_coverage_spec.rb'
     - 'spec/lib/gitlab/quick_actions/dsl_spec.rb'
     - 'spec/lib/marginalia_spec.rb'
     - 'spec/mailers/notify_spec.rb'

changelogs/unreleased/leaky-constant-fix-34.yml

+---
+title: Fix leaky constant issue in test coverage spec
+merge_request: 32134
+author: Rajendra Kadam
+type: fixed

spec/lib/gitlab/import_export/import_test_coverage_spec.rb

@@ -10,12 +10,13 @@ require 'spec_helper'
 describe 'Test coverage of the Project Import' do
   include ConfigurationHelper
 
-  # `MUTED_RELATIONS` is a technical debt.
+  # `muted_relations` is a technical debt.
   # This list expected to be empty or used as a workround
   # in case this spec blocks an important urgent MR.
   # It is also expected that adding a relation in the list should lead to
   # opening a follow-up issue to fix this.
-  MUTED_RELATIONS = %w[
+  let(:muted_relations) do
+    %w[
       project.milestones.events.push_event_payload
       project.issues.events
       project.issues.events.push_event_payload
@@ -51,20 +52,23 @@ describe 'Test coverage of the Project Import' do
       project.boards.lists.label.priorities
       project.service_desk_setting
     ].freeze
+  end
 
   # A list of JSON fixture files we use to test Import.
   # Most of the relations are present in `complex/project.json`
   # which is our main fixture.
-  PROJECT_JSON_FIXTURES = [
+  let(:project_json_fixtures) do
+    [
       'spec/fixtures/lib/gitlab/import_export/complex/project.json',
       'spec/fixtures/lib/gitlab/import_export/group/project.json',
       'spec/fixtures/lib/gitlab/import_export/light/project.json',
       'spec/fixtures/lib/gitlab/import_export/milestone-iid/project.json',
       'spec/fixtures/lib/gitlab/import_export/designs/project.json'
     ].freeze
+  end
 
   it 'ensures that all imported/exported relations are present in test JSONs' do
-    not_tested_relations = (relations_from_config - tested_relations) - MUTED_RELATIONS
+    not_tested_relations = (relations_from_config - tested_relations) - muted_relations
 
     expect(not_tested_relations).to be_empty, failure_message(not_tested_relations)
   end
@@ -76,7 +80,7 @@ describe 'Test coverage of the Project Import' do
   end
 
   def tested_relations
-    PROJECT_JSON_FIXTURES.flat_map(&method(:relations_from_json)).to_set
+    project_json_fixtures.flat_map(&method(:relations_from_json)).to_set
   end
 
   def relations_from_json(json_file)
@@ -106,7 +110,7 @@ describe 'Test coverage of the Project Import' do
       These relations seem to be added recenty and
       they expected to be covered in our Import specs: #{not_tested_relations}.
 
-      To do that, expand one of the files listed in `PROJECT_JSON_FIXTURES`
+      To do that, expand one of the files listed in `project_json_fixtures`
       (or expand the list if you consider adding a new fixture file).
 
       After that, add a new spec into
@@ -114,7 +118,7 @@ describe 'Test coverage of the Project Import' do
       to check that the relation is being imported correctly.
 
       In case the spec breaks the master or there is a sense of urgency,
-      you could include the relations into the `MUTED_RELATIONS` list.
+      you could include the relations into the `muted_relations` list.
 
       Muting relations is considered to be a temporary solution, so please
       open a follow-up issue and try to fix that when it is possible.