Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e5162c4a
Commit
e5162c4a
authored
Nov 24, 2020
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
test: Remove flaky test and group multiple separate tests
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
603f057a
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
12 deletions
+3
-12
ee/spec/features/projects/pipelines/pipeline_spec.rb
ee/spec/features/projects/pipelines/pipeline_spec.rb
+3
-12
No files found.
ee/spec/features/projects/pipelines/pipeline_spec.rb
View file @
e5162c4a
...
@@ -166,7 +166,7 @@ RSpec.describe 'Pipeline', :js do
...
@@ -166,7 +166,7 @@ RSpec.describe 'Pipeline', :js do
end
end
end
end
describe
'GET /:project/pipelines/:id/codequality_report'
do
describe
'GET /:project/pipelines/:id/codequality_report'
,
:aggregate_failures
do
shared_examples_for
'full codequality report'
do
shared_examples_for
'full codequality report'
do
context
'with no code quality artifact'
do
context
'with no code quality artifact'
do
before
do
before
do
...
@@ -184,25 +184,16 @@ RSpec.describe 'Pipeline', :js do
...
@@ -184,25 +184,16 @@ RSpec.describe 'Pipeline', :js do
before
do
before
do
create
(
:ee_ci_build
,
:codequality
,
pipeline:
pipeline
)
create
(
:ee_ci_build
,
:codequality
,
pipeline:
pipeline
)
visit
codequality_report_project_pipeline_path
(
project
,
pipeline
)
visit
codequality_report_project_pipeline_path
(
project
,
pipeline
)
wait_for_requests
end
end
it
'shows code quality tab pane as active'
do
it
'shows code quality tab pane as active
, quality issue with link to file, and events for data tracking
'
do
expect
(
page
).
to
have_content
(
'Code Quality'
)
expect
(
page
).
to
have_content
(
'Code Quality'
)
expect
(
page
).
to
have_css
(
'#js-tab-codequality'
)
expect
(
page
).
to
have_css
(
'#js-tab-codequality'
)
end
it
'shows code quality report section'
do
expect
(
page
).
to
have_content
(
'Loading codeclimate report'
)
end
it
'shows code quality issue with link to file'
do
wait_for_requests
expect
(
page
).
to
have_content
(
'Method `new_array` has 12 arguments (exceeds 4 allowed). Consider refactoring.'
)
expect
(
page
).
to
have_content
(
'Method `new_array` has 12 arguments (exceeds 4 allowed). Consider refactoring.'
)
expect
(
find_link
(
'foo.rb:10'
)[
:href
]).
to
end_with
(
project_blob_path
(
project
,
File
.
join
(
pipeline
.
commit
.
id
,
'foo.rb'
))
+
'#L10'
)
expect
(
find_link
(
'foo.rb:10'
)[
:href
]).
to
end_with
(
project_blob_path
(
project
,
File
.
join
(
pipeline
.
commit
.
id
,
'foo.rb'
))
+
'#L10'
)
end
it
'contains events for data tracking'
,
:aggregate_failures
do
expect
(
page
).
to
have_selector
(
'[data-track-event="click_button"]'
)
expect
(
page
).
to
have_selector
(
'[data-track-event="click_button"]'
)
expect
(
page
).
to
have_selector
(
'[data-track-label="get_codequality_report"]'
)
expect
(
page
).
to
have_selector
(
'[data-track-label="get_codequality_report"]'
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment