Commit e5bccfee authored by peterhegman's avatar peterhegman

Move number of skeleton lines to a constant

parent c1a65cb4
...@@ -4,8 +4,11 @@ import Icon from '~/vue_shared/components/icon.vue'; ...@@ -4,8 +4,11 @@ import Icon from '~/vue_shared/components/icon.vue';
import UserAvatarImage from '../user_avatar/user_avatar_image.vue'; import UserAvatarImage from '../user_avatar/user_avatar_image.vue';
import { glEmojiTag } from '../../../emoji'; import { glEmojiTag } from '../../../emoji';
const MAX_SKELETON_LINES = 4;
export default { export default {
name: 'UserPopover', name: 'UserPopover',
maxSkeletonLines: MAX_SKELETON_LINES,
components: { components: {
Icon, Icon,
GlPopover, GlPopover,
...@@ -53,8 +56,10 @@ export default { ...@@ -53,8 +56,10 @@ export default {
</div> </div>
<div class="p-1 w-100"> <div class="p-1 w-100">
<template v-if="userIsLoading"> <template v-if="userIsLoading">
<!-- `gl-skeleton-loading` does not support equal length lines -->
<!-- This can be migrated to `gl-skeleton-loader` when https://gitlab.com/gitlab-org/gitlab-ui/-/issues/872 is completed -->
<gl-skeleton-loading <gl-skeleton-loading
v-for="n in 4" v-for="n in $options.maxSkeletonLines"
:key="n" :key="n"
:lines="1" :lines="1"
class="animation-container-small mb-1" class="animation-container-small mb-1"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment