Merge branch '330937-remove-allow_group_deploy_token-ff' into 'master'

Remove allow_group_deploy_token feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!63727

app/models/group_deploy_token.rb

@@ -9,8 +9,6 @@ class GroupDeployToken < ApplicationRecord
   validates :deploy_token_id, uniqueness: { scope: [:group_id] }
 
   def has_access_to?(requested_project)
-    return false unless Feature.enabled?(:allow_group_deploy_token, default_enabled: true)
-
     requested_project_group = requested_project&.group
     return false unless requested_project_group
     return true if requested_project_group.id == group_id

config/feature_flags/development/allow_group_deploy_token.yml

----
-name: allow_group_deploy_token
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/23460
-rollout_issue_url: 
-milestone: '12.8'
-type: development
-group: group::release
-default_enabled: true

spec/models/deploy_token_spec.rb

@@ -248,19 +248,6 @@ RSpec.describe DeployToken do
           deploy_token.groups << group
         end
 
-        context 'and the allow_group_deploy_token feature flag is turned off' do
-          it 'is false' do
-            stub_feature_flags(allow_group_deploy_token: false)
-
-            is_expected.to be_falsy
-          end
-        end
-
-        context 'and the allow_group_deploy_token feature flag is turned on' do
-          before do
-            stub_feature_flags(allow_group_deploy_token: true)
-          end
-
         context 'and the passed-in project does not belong to any group' do
           it { is_expected.to be_falsy }
         end
@@ -312,7 +299,6 @@ RSpec.describe DeployToken do
           end
         end
       end
-      end
 
       context 'and the token is of project type' do
         let(:deploy_token) { create(:deploy_token, projects: [project]) }