Merge branch '195309-remove-special-user-action-buttons' into 'master'

Remove action buttons for special users

See merge request gitlab-org/gitlab!27162

app/views/admin/users/_user.html.haml

@@ -14,6 +14,7 @@
       = _('Last activity')
     .table-mobile-content
       = user.last_activity_on.nil? ? _('Never') : l(user.last_activity_on, format: :admin)
+  - unless user.internal?
     .table-section.section-20.table-button-footer
       .table-action-buttons
         = link_to _('Edit'), edit_admin_user_path(user), id: "edit_#{dom_id(user)}", class: 'btn btn-default'

changelogs/unreleased/195309-remove-special-user-action-buttons.yml

+---
+title: Hide admin user actions for ghost and bot users
+merge_request: 27162
+author:
+type: fixed

spec/views/admin/users/_user.html.haml_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'admin/users/_user.html.haml' do
+  before do
+    allow(view).to receive(:user).and_return(user)
+  end
+
+  context 'internal users' do
+    context 'when showing a `Ghost User`' do
+      let(:user) { create(:user, ghost: true) }
+
+      it 'does not render action buttons' do
+        render
+
+        expect(rendered).not_to have_selector('.table-action-buttons')
+      end
+    end
+
+    context 'when showing a `Bot User`' do
+      let(:user) { create(:user, user_type: :alert_bot) }
+
+      it 'does not render action buttons' do
+        render
+
+        expect(rendered).not_to have_selector('.table-action-buttons')
+      end
+    end
+  end
+
+  context 'when showing an external user' do
+    let(:user) { create(:user) }
+
+    it 'renders action buttons' do
+      render
+
+      expect(rendered).to have_selector('.table-action-buttons')
+    end
+  end
+end