refactor commitSha - commitUrl - commitTitle in pipelines.js.es6

e8b55c51 · Regis · 715461a9 · e8b55c51
Commit e8b55c51 authored Dec 16, 2016 by Regis
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 6 deletions

app/assets/javascripts/vue_pipelines_index/pipelines.js.es6 app/assets/javascripts/vue_pipelines_index/pipelines.js.es6 +3 -6

No files found.
--- a/app/assets/javascripts/vue_pipelines_index/pipelines.js.es6
+++ b/app/assets/javascripts/vue_pipelines_index/pipelines.js.es6
@@ -55,16 +55,13 @@
        return ({ name: ref.name, tag: ref['tag?'], ref_url: ref.url });
      },
      commitTitle(pipeline) {
-        if (pipeline.commit) return pipeline.commit.title;
+        return pipeline.commit ? pipeline.commit.title : '';
-        return '';
      },
      commitSha(pipeline) {
-        if (pipeline.commit) return pipeline.commit.short_id;
+        return pipeline.commit ? pipeline.commit.short_id : '';
-        return '';
      },
      commitUrl(pipeline) {
-        if (pipeline.commit) return pipeline.commit.commit_url;
+        return pipeline.commit ? pipeline.commit.commit_url : '';
-        return '';
      },
      match(string) {
        return string.replace(/_([a-z])/g, (m, w) => w.toUpperCase());