Apply reviewer notes: update CHANGELOG, adjust code formatting

parent fcbb14f6
...@@ -2,7 +2,7 @@ Please view this file on the master branch, on stable branches it's out of date. ...@@ -2,7 +2,7 @@ Please view this file on the master branch, on stable branches it's out of date.
v 8.9.0 (unreleased) v 8.9.0 (unreleased)
- Fix Error 500 when using closes_issues API with an external issue tracker - Fix Error 500 when using closes_issues API with an external issue tracker
- Add more information into RSS feed for issues. - Add more information into RSS feed for issues (Alexander Matyushentsev)
- Bulk assign/unassign labels to issues. - Bulk assign/unassign labels to issues.
- Ability to prioritize labels !4009 / !3205 (Thijs Wouters) - Ability to prioritize labels !4009 / !3205 (Thijs Wouters)
- Fix endless redirections when accessing user OAuth applications when they are disabled - Fix endless redirections when accessing user OAuth applications when they are disabled
...@@ -124,7 +124,6 @@ v 8.8.1 ...@@ -124,7 +124,6 @@ v 8.8.1
v 8.8.0 v 8.8.0
- Implement GFM references for milestones (Alejandro Rodríguez) - Implement GFM references for milestones (Alejandro Rodríguez)
v 8.8.0 (unreleased)
- Snippets tab under user profile. !4001 (Long Nguyen) - Snippets tab under user profile. !4001 (Long Nguyen)
- Fix error when using link to uploads in global snippets - Fix error when using link to uploads in global snippets
- Fix Error 500 when attempting to retrieve project license when HEAD points to non-existent ref - Fix Error 500 when attempting to retrieve project license when HEAD points to non-existent ref
......
...@@ -12,7 +12,7 @@ describe "Dashboard Issues Feed", feature: true do ...@@ -12,7 +12,7 @@ describe "Dashboard Issues Feed", feature: true do
end end
describe "atom feed" do describe "atom feed" do
it "should render atom feed via private token" do it "renders atom feed via private token" do
visit issues_dashboard_path(:atom, private_token: user.private_token) visit issues_dashboard_path(:atom, private_token: user.private_token)
expect(response_headers['Content-Type']).to have_content('application/atom+xml') expect(response_headers['Content-Type']).to have_content('application/atom+xml')
...@@ -22,7 +22,7 @@ describe "Dashboard Issues Feed", feature: true do ...@@ -22,7 +22,7 @@ describe "Dashboard Issues Feed", feature: true do
context "issue with basic fields" do context "issue with basic fields" do
let!(:issue2) { create(:issue, author: user, assignee: user, project: project2, description: 'test desc') } let!(:issue2) { create(:issue, author: user, assignee: user, project: project2, description: 'test desc') }
it "should render issue fields" do it "renders issue fields" do
visit issues_dashboard_path(:atom, private_token: user.private_token) visit issues_dashboard_path(:atom, private_token: user.private_token)
entry = find(:xpath, "//feed/entry[contains(summary/text(),'#{issue2.title}')]") entry = find(:xpath, "//feed/entry[contains(summary/text(),'#{issue2.title}')]")
...@@ -45,7 +45,7 @@ describe "Dashboard Issues Feed", feature: true do ...@@ -45,7 +45,7 @@ describe "Dashboard Issues Feed", feature: true do
issue1.labels << label1 issue1.labels << label1
end end
it "should render issue label and milestone info" do it "renders issue label and milestone info" do
visit issues_dashboard_path(:atom, private_token: user.private_token) visit issues_dashboard_path(:atom, private_token: user.private_token)
entry = find(:xpath, "//feed/entry[contains(summary/text(),'#{issue1.title}')]") entry = find(:xpath, "//feed/entry[contains(summary/text(),'#{issue1.title}')]")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment