Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ebe417d6
Commit
ebe417d6
authored
Jul 15, 2021
by
Justin Boyson
Committed by
Phil Hughes
Jul 15, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve "Update merged widget state to match designs"
parent
645608ac
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
12 additions
and
22 deletions
+12
-22
app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_merged.vue
...rge_request_widget/components/states/mr_widget_merged.vue
+12
-17
locale/gitlab.pot
locale/gitlab.pot
+0
-3
spec/frontend/vue_mr_widget/components/states/mr_widget_merged_spec.js
.../vue_mr_widget/components/states/mr_widget_merged_spec.js
+0
-2
No files found.
app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_merged.vue
View file @
ebe417d6
<
script
>
<
script
>
/* eslint-disable @gitlab/vue-require-i18n-strings */
/* eslint-disable @gitlab/vue-require-i18n-strings */
import
{
GlLoadingIcon
,
GlButton
,
GlTooltipDirective
}
from
'
@gitlab/ui
'
;
import
{
GlLoadingIcon
,
GlButton
,
GlTooltipDirective
,
GlIcon
}
from
'
@gitlab/ui
'
;
import
createFlash
from
'
~/flash
'
;
import
createFlash
from
'
~/flash
'
;
import
{
s__
,
__
}
from
'
~/locale
'
;
import
{
s__
,
__
}
from
'
~/locale
'
;
import
{
OPEN_REVERT_MODAL
,
OPEN_CHERRY_PICK_MODAL
}
from
'
~/projects/commit/constants
'
;
import
{
OPEN_REVERT_MODAL
,
OPEN_CHERRY_PICK_MODAL
}
from
'
~/projects/commit/constants
'
;
...
@@ -8,7 +8,6 @@ import modalEventHub from '~/projects/commit/event_hub';
...
@@ -8,7 +8,6 @@ import modalEventHub from '~/projects/commit/event_hub';
import
ClipboardButton
from
'
~/vue_shared/components/clipboard_button.vue
'
;
import
ClipboardButton
from
'
~/vue_shared/components/clipboard_button.vue
'
;
import
eventHub
from
'
../../event_hub
'
;
import
eventHub
from
'
../../event_hub
'
;
import
MrWidgetAuthorTime
from
'
../mr_widget_author_time.vue
'
;
import
MrWidgetAuthorTime
from
'
../mr_widget_author_time.vue
'
;
import
statusIcon
from
'
../mr_widget_status_icon.vue
'
;
export
default
{
export
default
{
name
:
'
MRWidgetMerged
'
,
name
:
'
MRWidgetMerged
'
,
...
@@ -17,7 +16,7 @@ export default {
...
@@ -17,7 +16,7 @@ export default {
},
},
components
:
{
components
:
{
MrWidgetAuthorTime
,
MrWidgetAuthorTime
,
status
Icon
,
Gl
Icon
,
ClipboardButton
,
ClipboardButton
,
GlLoadingIcon
,
GlLoadingIcon
,
GlButton
,
GlButton
,
...
@@ -116,7 +115,7 @@ export default {
...
@@ -116,7 +115,7 @@ export default {
</
script
>
</
script
>
<
template
>
<
template
>
<div
class=
"mr-widget-body media"
>
<div
class=
"mr-widget-body media"
>
<
status-icon
status=
"success
"
/>
<
gl-icon
name=
"merge"
:size=
"24"
class=
"gl-text-blue-500 gl-mr-3 gl-mt-1
"
/>
<div
class=
"media-body"
>
<div
class=
"media-body"
>
<div
class=
"space-children"
>
<div
class=
"space-children"
>
<mr-widget-author-time
<mr-widget-author-time
...
@@ -131,7 +130,6 @@ export default {
...
@@ -131,7 +130,6 @@ export default {
:title=
"revertTitle"
:title=
"revertTitle"
size=
"small"
size=
"small"
category=
"secondary"
category=
"secondary"
variant=
"warning"
data-qa-selector=
"revert_button"
data-qa-selector=
"revert_button"
@
click=
"openRevertModal"
@
click=
"openRevertModal"
>
>
...
@@ -144,7 +142,6 @@ export default {
...
@@ -144,7 +142,6 @@ export default {
:title=
"revertTitle"
:title=
"revertTitle"
size=
"small"
size=
"small"
category=
"secondary"
category=
"secondary"
variant=
"warning"
data-method=
"post"
data-method=
"post"
>
>
{{
revertLabel
}}
{{
revertLabel
}}
...
@@ -169,6 +166,15 @@ export default {
...
@@ -169,6 +166,15 @@ export default {
>
>
{{
cherryPickLabel
}}
{{
cherryPickLabel
}}
</gl-button>
</gl-button>
<gl-button
v-if=
"shouldShowRemoveSourceBranch"
:disabled=
"isMakingRequest"
size=
"small"
class=
"js-remove-branch-button"
@
click=
"removeSourceBranch"
>
{{
s__
(
'
mrWidget|Delete source branch
'
)
}}
</gl-button>
</div>
</div>
<section
class=
"mr-info-list"
data-qa-selector=
"merged_status_content"
>
<section
class=
"mr-info-list"
data-qa-selector=
"merged_status_content"
>
<p>
<p>
...
@@ -196,17 +202,6 @@ export default {
...
@@ -196,17 +202,6 @@ export default {
<p
v-if=
"mr.sourceBranchRemoved"
>
<p
v-if=
"mr.sourceBranchRemoved"
>
{{ s__('mrWidget|The source branch has been deleted') }}
{{ s__('mrWidget|The source branch has been deleted') }}
</p>
</p>
<p
v-if=
"shouldShowRemoveSourceBranch"
class=
"space-children"
>
<span>
{{ s__('mrWidget|You can delete the source branch now') }}
</span>
<gl-button
:disabled=
"isMakingRequest"
size=
"small"
class=
"js-remove-branch-button"
@
click=
"removeSourceBranch"
>
{{ s__('mrWidget|Delete source branch') }}
</gl-button>
</p>
<p
v-if=
"shouldShowSourceBranchRemoving"
>
<p
v-if=
"shouldShowSourceBranchRemoving"
>
<gl-loading-icon
size=
"sm"
:inline=
"true"
/>
<gl-loading-icon
size=
"sm"
:inline=
"true"
/>
<span>
{{ s__('mrWidget|The source branch is being deleted') }}
</span>
<span>
{{ s__('mrWidget|The source branch is being deleted') }}
</span>
...
...
locale/gitlab.pot
View file @
ebe417d6
...
@@ -39402,9 +39402,6 @@ msgstr ""
...
@@ -39402,9 +39402,6 @@ msgstr ""
msgid "mrWidget|You are not allowed to edit this project directly. Please fork to make changes."
msgid "mrWidget|You are not allowed to edit this project directly. Please fork to make changes."
msgstr ""
msgstr ""
msgid "mrWidget|You can delete the source branch now"
msgstr ""
msgid "mrWidget|You can merge after removing denied licenses"
msgid "mrWidget|You can merge after removing denied licenses"
msgstr ""
msgstr ""
...
...
spec/frontend/vue_mr_widget/components/states/mr_widget_merged_spec.js
View file @
ebe417d6
...
@@ -217,7 +217,6 @@ describe('MRWidgetMerged', () => {
...
@@ -217,7 +217,6 @@ describe('MRWidgetMerged', () => {
vm
.
mr
.
sourceBranchRemoved
=
false
;
vm
.
mr
.
sourceBranchRemoved
=
false
;
Vue
.
nextTick
(()
=>
{
Vue
.
nextTick
(()
=>
{
expect
(
vm
.
$el
.
innerText
).
toContain
(
'
You can delete the source branch now
'
);
expect
(
vm
.
$el
.
innerText
).
not
.
toContain
(
'
The source branch has been deleted
'
);
expect
(
vm
.
$el
.
innerText
).
not
.
toContain
(
'
The source branch has been deleted
'
);
done
();
done
();
});
});
...
@@ -229,7 +228,6 @@ describe('MRWidgetMerged', () => {
...
@@ -229,7 +228,6 @@ describe('MRWidgetMerged', () => {
Vue
.
nextTick
(()
=>
{
Vue
.
nextTick
(()
=>
{
expect
(
vm
.
$el
.
innerText
).
toContain
(
'
The source branch is being deleted
'
);
expect
(
vm
.
$el
.
innerText
).
toContain
(
'
The source branch is being deleted
'
);
expect
(
vm
.
$el
.
innerText
).
not
.
toContain
(
'
You can delete the source branch now
'
);
expect
(
vm
.
$el
.
innerText
).
not
.
toContain
(
'
The source branch has been deleted
'
);
expect
(
vm
.
$el
.
innerText
).
not
.
toContain
(
'
The source branch has been deleted
'
);
done
();
done
();
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment