Merge branch 'djensen-revert-metrics-definitions-in-ui' into 'master'

Fix the reversed in-app metric definitions for group-level VSA

See merge request gitlab-org/gitlab!61182

ee/app/assets/javascripts/analytics/cycle_analytics/components/time_metrics_card.vue

@@ -9,13 +9,13 @@ import { removeFlash, prepareTimeMetricsData } from '../utils';
 
 const POPOVER_CONTENT = {
   'lead-time': {
+    description: s__('ValueStreamAnalytics|Median time from issue created to issue closed.'),
+  },
+  'cycle-time': {
     description: s__(
       'ValueStreamAnalytics|Median time from issue first merge request created to issue closed.',
     ),
   },
-  'cycle-time': {
-    description: s__('ValueStreamAnalytics|Median time from issue created to issue closed.'),
-  },
   'new-issues': { description: s__('ValueStreamAnalytics|Number of new issues created.') },
   deploys: { description: s__('ValueStreamAnalytics|Total number of deploys to production.') },
   'deployment-frequency': {

ee/spec/frontend/analytics/cycle_analytics/components/__snapshots__/time_metrics_card_spec.js.snap

@@ -21,11 +21,11 @@ exports[`TimeMetricsCard Time summary renders the Time summary metric 1`] = `
 "<div>
   <div class=\\"gl-pr-9\\">
     <gl-single-stat-stub title=\\"Lead Time\\" value=\\"4.5\\" unit=\\"days\\" variant=\\"muted\\" shouldanimate=\\"true\\" animationdecimalplaces=\\"0\\" id=\\"lead-time\\" tabindex=\\"0\\"></gl-single-stat-stub>
-    <gl-popover-stub cssclasses=\\"\\" target=\\"lead-time\\" placement=\\"bottom\\"> <span>Median time from issue first merge request created to issue closed.</span></gl-popover-stub>
+    <gl-popover-stub cssclasses=\\"\\" target=\\"lead-time\\" placement=\\"bottom\\"> <span>Median time from issue created to issue closed.</span></gl-popover-stub>
   </div>
   <div class=\\"gl-pr-9\\">
     <gl-single-stat-stub title=\\"Cycle Time\\" value=\\"3.0\\" unit=\\"days\\" variant=\\"muted\\" shouldanimate=\\"true\\" animationdecimalplaces=\\"0\\" id=\\"cycle-time\\" tabindex=\\"0\\"></gl-single-stat-stub>
-    <gl-popover-stub cssclasses=\\"\\" target=\\"cycle-time\\" placement=\\"bottom\\"> <span>Median time from issue created to issue closed.</span></gl-popover-stub>
+    <gl-popover-stub cssclasses=\\"\\" target=\\"cycle-time\\" placement=\\"bottom\\"> <span>Median time from issue first merge request created to issue closed.</span></gl-popover-stub>
   </div>
 </div>"
 `;