Merge branch '347317-re-enable-review-apps-on-2-hour-scheduled-pipelines' into 'master'

ci: Re-enable Review Apps on scheduled pipelines

See merge request gitlab-org/gitlab!76243

.gitlab/ci/review.gitlab-ci.yml

@@ -5,7 +5,7 @@ review-cleanup:
   image: registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-helm3-kubectl1.14
   stage: prepare
   environment:
-    name: review/auto-cleanup
+    name: review/${CI_COMMIT_REF_SLUG}${FREQUENCY}
     action: stop
   before_script:
     - source scripts/utils.sh
@@ -13,6 +13,8 @@ review-cleanup:
     - install_gitlab_gem
     - setup_gcp_dependencies
   script:
+    - delete_release
+    - delete_k8s_release_namespace
     - ruby -rrubygems scripts/review_apps/automated_cleanup.rb
     - gcp_cleanup
 

.gitlab/ci/rules.gitlab-ci.yml

@@ -1623,6 +1623,9 @@
       allow_failure: true
     - <<: *if-dot-com-gitlab-org-merge-request
       changes: *qa-patterns
+    - <<: *if-dot-com-gitlab-org-schedule
+      variables:
+        KNAPSACK_GENERATE_REPORT: "true"
 
 .review:rules:review-build-cng:
   rules:
@@ -1662,10 +1665,6 @@
 
 .review:rules:review-qa-reliable:
   rules:
-    - <<: *if-dot-com-ee-2-hourly-schedule
-      allow_failure: true
-      variables:
-        KNAPSACK_GENERATE_REPORT: "true"
     - when: on_success
       allow_failure: true
 
@@ -1676,10 +1675,6 @@
       changes: *code-patterns
       when: manual
       allow_failure: true # manual jobs needs to be allowd to fail, otherwise they block the pipeline
-    - <<: *if-dot-com-ee-2-hourly-schedule
-      allow_failure: true
-      variables:
-        KNAPSACK_GENERATE_REPORT: "true"
     - when: on_success
       allow_failure: true
 
@@ -1699,13 +1694,13 @@
 # Reliable suite will pass most of the time so this should yield best distribution
 .review:rules:knapsack-report-qa-reliable:
   rules:
-    - <<: *if-dot-com-ee-2-hourly-schedule
+    - if: '$KNAPSACK_GENERATE_REPORT == "true"'
       when: on_success
       allow_failure: true
 
 .review:rules:knapsack-report-qa-all:
   rules:
-    - <<: *if-dot-com-ee-2-hourly-schedule
+    - if: '$KNAPSACK_GENERATE_REPORT == "true"'
       when: always
       allow_failure: true
 

doc/development/testing_guide/review_apps.md

@@ -15,6 +15,7 @@ For any of the following scenarios, the `start-review-app-pipeline` job would be
 - for merge requests with CI config changes
 - for merge requests with frontend changes
 - for merge requests with QA changes
+- for scheduled pipelines
 - the MR has the `pipeline:run-review-app` label set
 
 ## QA runs on Review Apps