Change service to be a worker, feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342#note_16118195

app/models/ci/pipeline.rb

@@ -83,8 +83,8 @@ module Ci
         end
       end
 
-      after_transition any => [:success, :failed] do |pipeline, transition|
-        SendPipelineNotificationService.new(pipeline).execute
+      after_transition any => [:success, :failed] do |pipeline|
+        SendPipelineNotificationWorker.perform_async(pipeline.id)
       end
     end
 

app/models/project_services/pipelines_email_service.rb

@@ -31,8 +31,8 @@ class PipelinesEmailService < Service
 
     return unless all_recipients.any?
 
-    pipeline = Ci::Pipeline.find(data[:object_attributes][:id])
-    Ci::SendPipelineNotificationService.new(pipeline).execute(all_recipients)
+    pipeline_id = data[:object_attributes][:id]
+    SendPipelineNotificationWorker.perform_async(pipeline_id, all_recipients)
   end
 
   def can_test?

app/services/ci/send_pipeline_notification_service.rb

-module Ci
-  class SendPipelineNotificationService < BaseService
-    attr_reader :pipeline
-
-    def initialize(new_pipeline)
-      @pipeline = new_pipeline
-    end
-
-    def execute(recipients = nil)
-      notification_service.pipeline_finished(pipeline, recipients)
-    end
-  end
-end

app/workers/send_pipeline_notification_worker.rb

+class SendPipelineNotificationWorker
+  include Sidekiq::Worker
+
+  def perform(pipeline_id, recipients = nil)
+    pipeline = Ci::Pipeline.find(pipeline_id)
+
+    NotificationService.new.pipeline_finished(pipeline, recipients)
+  end
+end

spec/models/ci/pipeline_spec.rb

@@ -537,9 +537,11 @@ describe Ci::Pipeline, models: true do
     before do
       reset_delivered_emails!
 
+      perform_enqueued_jobs do
         pipeline.enqueue
         pipeline.run
       end
+    end
 
     shared_examples 'sending a notification' do
       it 'sends an email' do

spec/services/ci/send_pipeline_notification_service_spec.rb → spec/workers/send_pipeline_notification_worker_spec.rb

 require 'spec_helper'
 
-describe Ci::SendPipelineNotificationService, services: true do
+describe SendPipelineNotificationWorker, services: true do
   let(:pipeline) do
     create(:ci_pipeline,
            project: project,
@@ -23,7 +23,7 @@ describe Ci::SendPipelineNotificationService, services: true do
     shared_examples 'sending emails' do
       it 'sends emails' do
         perform_enqueued_jobs do
-          subject.execute
+          subject.perform(pipeline.id)
         end
 
         expected_receivers = [pusher, watcher].uniq.sort_by(&:email)