Implement review feedback

qa/qa/resource/user.rb

@@ -77,13 +77,13 @@ module QA
       end
 
       def self.fabricate_or_use(username, password)
-        if !Runtime::Env.signup_disabled?
-          self.fabricate!
-        else
+        if Runtime::Env.signup_disabled?
           self.new.tap do |user|
             user.username = username
             user.password = password
           end
+        else
+          self.fabricate!
         end
       end
 

qa/qa/runtime/env.rb

@@ -78,7 +78,7 @@ module QA
       end
 
       def gitlab_qa_username_1
-        ENV['GITLAB_QA_USERNAME_1']
+        ENV['GITLAB_QA_USERNAME_1'] || 'gitlab-qa-user1'
       end
 
       def gitlab_qa_password_1
@@ -86,7 +86,7 @@ module QA
       end
 
       def gitlab_qa_username_2
-        ENV['GITLAB_QA_USERNAME_2']
+        ENV['GITLAB_QA_USERNAME_2'] || 'gitlab-qa-user2'
       end
 
       def gitlab_qa_password_2